From 2d265f253c4f0654dba768d33dd69f05c93ccf7d Mon Sep 17 00:00:00 2001 From: Saman Ehsan Date: Tue, 22 Aug 2023 11:04:09 -0400 Subject: [PATCH] Update to from node 14->16 Fixes build issue with vite --- .github/workflows/lint.yml | 2 +- .github/workflows/test-e2e.yml | 2 +- .github/workflows/test-unit.yml | 2 +- Dockerfile | 2 +- Dockerfile.direct | 2 +- README.md | 8 ++++---- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 56dc5156d..ca1653caa 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -8,7 +8,7 @@ jobs: timeout-minutes: 180 strategy: matrix: - node-version: [14.x] + node-version: [16.x] if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')" runs-on: ubuntu-latest steps: diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index dfdc57813..291a38c1b 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -18,7 +18,7 @@ jobs: timeout-minutes: 180 strategy: matrix: - node-version: [14.x] + node-version: [16.x] if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')" runs-on: ubuntu-latest steps: diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml index da840e83d..80f79214a 100644 --- a/.github/workflows/test-unit.yml +++ b/.github/workflows/test-unit.yml @@ -12,7 +12,7 @@ jobs: timeout-minutes: 60 strategy: matrix: - node-version: [14.x] + node-version: [16.x] if: "!contains( github.event.pull_request.labels.*.name, 'skip-ci')" runs-on: ubuntu-latest steps: diff --git a/Dockerfile b/Dockerfile index 1ebd3e330..2f56154ec 100644 --- a/Dockerfile +++ b/Dockerfile @@ -11,7 +11,7 @@ RUN /usr/local/bin/docker-entrypoint.sh generate -g typescript-axios -i $TDR_OPE ## Step 2. Build the deployable UI artifacts -FROM node:14.0-buster as build +FROM node:16.20-buster as build # Check out the build RUN set -x \ && git clone https://github.com/DataBiosphere/jade-data-repo-ui \ diff --git a/Dockerfile.direct b/Dockerfile.direct index 64c1c3b69..68a39f3f2 100644 --- a/Dockerfile.direct +++ b/Dockerfile.direct @@ -10,7 +10,7 @@ ARG TDR_OPEN_API_YAML_LOCATION RUN /usr/local/bin/docker-entrypoint.sh generate -g typescript-axios -i $TDR_OPEN_API_YAML_LOCATION -o /local/src/generated/tdr --skip-validate-spec ## Step 2. Build the deployable UI artifacts -FROM node:14.0-buster as build +FROM node:16.20-buster as build # Copy the local code COPY . / # Copy the generated code diff --git a/README.md b/README.md index 05fa41643..3525d5329 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ rm -R ~/.avn (if you want to reset an existing or failed avn setup) nvm exec 10.0.0 npm install -g avn avn-nvm avn-n nvm exec 10.0.0 avn setup nvm install lts/erbium --default -nvm use lts/erbium +nvm use lts/gallium ``` - Run `npm install` to download dependencies defined in the package.json file and generate the node_modules folder with the installed modules. @@ -61,14 +61,14 @@ gcloud auth login --no-activate ### Development -- webpack-dev-server 3.x +- vite-dev-server 5.x - redux-devtools (with browser plugin) `npm start` ### Building -- webpack 4.x +- vite 4.x - babel 7.x `npm run build` @@ -82,7 +82,7 @@ gcloud auth login --no-activate ### Testing -- cypress 9.x +- cypress 12.x To run end-to-end tests: `npx cypress run` or `npx cypress open` (interactive mode)