From 336ebe7c6cd3dc9c87499cbf9cac6bb5e8fe6da8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt?= Date: Thu, 9 Jun 2022 18:05:52 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=8F=B7=EF=B8=8F=20adjust=20types=20to=20a?= =?UTF-8?q?llow=20updating=20the=20SDK=20in=20Datadog=20app=20(#1587)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * make `startView` argument optional * export TimeStamp from `/internal` Since 85e732de18bef9a37af5a9405135e35811ccd79e , Records timestamp is using the TimeStamp type. We need it to mock records in web-ui --- packages/rum-core/src/boot/rumPublicApi.ts | 2 +- packages/rum/src/entries/internal.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/rum-core/src/boot/rumPublicApi.ts b/packages/rum-core/src/boot/rumPublicApi.ts index d267a44a87..b8ace3be22 100644 --- a/packages/rum-core/src/boot/rumPublicApi.ts +++ b/packages/rum-core/src/boot/rumPublicApi.ts @@ -155,7 +155,7 @@ export function makeRumPublicApi( } const startView: { - (name: string): void + (name?: string): void // (options: ViewOptions): void // uncomment when removing the feature flag } = monitor((options?: string) => { const sanitizedOptions = typeof options === 'object' ? options : { name: options } diff --git a/packages/rum/src/entries/internal.ts b/packages/rum/src/entries/internal.ts index c08a2b80e4..8b78b62997 100644 --- a/packages/rum/src/entries/internal.ts +++ b/packages/rum/src/entries/internal.ts @@ -5,6 +5,7 @@ * WARNING: this module is not intended for public usages, and won't follow semver for breaking * changes. */ +export type { TimeStamp } from '@datadog/browser-core' export { PRIVACY_ATTR_NAME, PRIVACY_ATTR_VALUE_HIDDEN, PRIVACY_CLASS_HIDDEN, NodePrivacyLevel } from '../constants' export * from '../types'