Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DataDog/test-infra-definitions#1267 #31558

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Nov 28, 2024

What does this PR do?

Test DataDog/test-infra-definitions#1267

Motivation

Better understand the impact of DataDog/test-infra-definitions#1265 on e2e tests.

Describe how to test/QA your changes

Validate that all containers e2e tests are passing.

Possible Drawbacks / Trade-offs

Additional Notes

@L3n41c L3n41c added team/containers changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Nov 28, 2024
@L3n41c L3n41c added this to the 7.61.0 milestone Nov 28, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Nov 28, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50100661 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 944256d3-88af-400c-b2f7-418736403b0d

Baseline: 90bfbe5
Comparison: 9697ae2
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.05 [+1.07, +9.03] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.05 [+1.07, +9.03] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +2.05 [+1.31, +2.79] 1 Logs
quality_gate_logs % cpu utilization +0.40 [-2.53, +3.33] 1 Logs
quality_gate_idle_all_features memory utilization +0.35 [+0.23, +0.47] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.30 [-0.46, +1.06] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.29 [+0.24, +0.34] 1 Logs
otel_to_otel_logs ingress throughput +0.26 [-0.41, +0.93] 1 Logs
quality_gate_idle memory utilization +0.25 [+0.21, +0.29] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.15 [-0.31, +0.61] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.73, +0.87] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.68, +0.76] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.10] 1 Logs
file_tree memory utilization -0.04 [-0.19, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.64 [-1.41, +0.14] 1 Logs
pycheck_lots_of_tags % cpu utilization -3.30 [-6.67, +0.08] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 7/10
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant