-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVIS-2892] Code coverage events writer #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad with a buffer to collect and send out code coverage events
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #150 +/- ##
==========================================
- Coverage 99.19% 99.03% -0.17%
==========================================
Files 176 179 +3
Lines 7741 8049 +308
Branches 314 333 +19
==========================================
+ Hits 7679 7971 +292
- Misses 62 78 +16 ☔ View full report in Codecov by Sentry. |
…mponents#shutdown! to correctly flush coverage events on test suite end
make sure that cucumber feature files are covered
marcotc
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
Datadog::CI::ITR::Coverage::Writer
that asynchronously sends coverage events to backend.It starts a worker thread that is later gracefully stopped in
ITR::Runner#shutdown!
method.Unit tests are provided
How to test the change?
Tested using anmarchenko/sidekiq project and executing the following DDSQL queries:
Unit tests are provided. Note that Codecov reports 12 uncovered lines from
writer_spec.rb
file: this is due to simplecov missing coverage by forked processes.