From 8ca450d861dc34f9ccde5ebea4beb02e06a2df5f Mon Sep 17 00:00:00 2001 From: Elijah Andrews Date: Tue, 28 May 2013 18:30:01 -0400 Subject: [PATCH 1/2] Log exception when dogstatsd server fails to start. Fixes #480 --- dogstatsd.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dogstatsd.py b/dogstatsd.py index 3c58a53508..0f43aecd33 100755 --- a/dogstatsd.py +++ b/dogstatsd.py @@ -221,6 +221,8 @@ def run(self): self.reporter.start() try: self.server.start() + except Exception: + log.exception('Error starting server') finally: # The server will block until it's done. Once we're here, shutdown # the reporting thread. From 98e17bec1a90a11d87bc85f37a31bb0d2e6f589a Mon Sep 17 00:00:00 2001 From: Elijah Andrews Date: Tue, 28 May 2013 19:06:08 -0400 Subject: [PATCH 2/2] Update dogstatsd run exception handling to be compatible with 2.4 --- dogstatsd.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dogstatsd.py b/dogstatsd.py index 0f43aecd33..22b8898734 100755 --- a/dogstatsd.py +++ b/dogstatsd.py @@ -220,9 +220,11 @@ def run(self): signal.signal(signal.SIGINT, self._handle_sigterm) self.reporter.start() try: - self.server.start() - except Exception: - log.exception('Error starting server') + try: + self.server.start() + except Exception, e: + log.exception('Error starting server') + raise e finally: # The server will block until it's done. Once we're here, shutdown # the reporting thread.