Fix unit tests compilation after merging Tracking Consent feature #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
approved these changes
Dec 17, 2020
ncreated
deleted the
ncreated/fix-unit-tests-compilation-after-merging-tracking-consent-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
⚙️ This PR fixes unit tests compilation issue after merging #347.
How?
Recently merged #347 was quite outdated comparing to the main branch, and it was not rebased before the merge. Because of this, updates to unit tests API introduced in NTP time sync feature were not applied in #347, causing the compiler issue on
master.Review checklist
- [ ] Make sure each commit and the PR mention the Issue number or JIRA reference