[CIVIS-9212] send tests skipped by ITR to the backend #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainkomorn-exdatadog
approved these changes
Mar 28, 2024
maciejburda
reviewed
Mar 28, 2024
|
|
||
| func testBundleWillStart(_ testBundle: Bundle) { | ||
| let bundleName = testBundle.bundleURL.deletingPathExtension().lastPathComponent | ||
| guard case .none = state else { |
There was a problem hiding this comment.
Maybe it would make sense to make State implement Equatable and use simple == here
There was a problem hiding this comment.
there is only one case .none without associated object. I think Equatable implementation will need more lines of code than 2 case unwraps. And this is internal state enum, which is used only in that observer.
maciejburda
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Added sending of skipped tests to the backend. Fixed span serialisation
How?
Review checklist