diff --git a/tracer/src/Datadog.Trace.BenchmarkDotNet/DatadogDiagnoser.cs b/tracer/src/Datadog.Trace.BenchmarkDotNet/DatadogDiagnoser.cs
index 552778dd4a08..aec1a82bf3ce 100644
--- a/tracer/src/Datadog.Trace.BenchmarkDotNet/DatadogDiagnoser.cs
+++ b/tracer/src/Datadog.Trace.BenchmarkDotNet/DatadogDiagnoser.cs
@@ -216,12 +216,12 @@ private static void SetEnvironmentVariables(DiagnoserActionParameters parameters
if (!environment.TryGetValue(ConfigurationKeys.Environment, out _))
{
- environment[ConfigurationKeys.Environment] = tracer.Settings.EnvironmentInternal;
+ environment[ConfigurationKeys.Environment] = tracer.Settings.Environment;
}
if (!environment.TryGetValue(ConfigurationKeys.ServiceVersion, out _))
{
- environment[ConfigurationKeys.ServiceVersion] = tracer.Settings.ServiceVersionInternal;
+ environment[ConfigurationKeys.ServiceVersion] = tracer.Settings.ServiceVersion;
}
const string ProfilerId = "{846F5F1C-F9AE-4B07-969E-05C26BC060D8}";
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/NamingProblemDiagnostic.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/NamingProblemDiagnostic.cs
deleted file mode 100644
index 6fb8a8b41671..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/NamingProblemDiagnostic.cs
+++ /dev/null
@@ -1,27 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using Datadog.Trace.SourceGenerators.Helpers;
-using Microsoft.CodeAnalysis;
-
-namespace Datadog.Trace.SourceGenerators.PublicApi.Diagnostics;
-
-internal static class NamingProblemDiagnostic
-{
- internal const string Id = "PA4";
- private const string Message = "Field names should start with '_' or end with 'Internal'";
- private const string Title = "Unknown naming";
-
- public static DiagnosticInfo CreateInfo(SyntaxNode? currentNode)
- => new(
- new DiagnosticDescriptor(
- Id,
- Title,
- Message,
- category: SourceGenerators.Constants.Usage,
- defaultSeverity: DiagnosticSeverity.Warning,
- isEnabledByDefault: true),
- currentNode?.GetLocation());
-}
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/OnlySupportsClassesDiagnostic.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/OnlySupportsClassesDiagnostic.cs
deleted file mode 100644
index 7bcb95b8cb87..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/OnlySupportsClassesDiagnostic.cs
+++ /dev/null
@@ -1,27 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using Datadog.Trace.SourceGenerators.Helpers;
-using Microsoft.CodeAnalysis;
-
-namespace Datadog.Trace.SourceGenerators.PublicApi.Diagnostics;
-
-internal static class OnlySupportsClassesDiagnostic
-{
- internal const string Id = "PA1";
- private const string Message = "The GeneratePublicApiAttribute is only supported on classes";
- private const string Title = "Not a class";
-
- public static DiagnosticInfo CreateInfo(SyntaxNode? currentNode)
- => new(
- new DiagnosticDescriptor(
- Id,
- Title,
- Message,
- category: SourceGenerators.Constants.Usage,
- defaultSeverity: DiagnosticSeverity.Warning,
- isEnabledByDefault: true),
- currentNode?.GetLocation());
-}
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/PartialModifierIsRequiredDiagnostic.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/PartialModifierIsRequiredDiagnostic.cs
deleted file mode 100644
index 744bbb80ef81..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/PartialModifierIsRequiredDiagnostic.cs
+++ /dev/null
@@ -1,28 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using Datadog.Trace.SourceGenerators.Helpers;
-using Microsoft.CodeAnalysis;
-
-namespace Datadog.Trace.SourceGenerators.PublicApi.Diagnostics
-{
- internal static class PartialModifierIsRequiredDiagnostic
- {
- internal const string Id = "PA4";
- private const string Message = "The partial modifier is required when using GeneratePublicApiAttribute";
- private const string Title = "Requires 'partial'";
-
- public static DiagnosticInfo CreateInfo(SyntaxNode? currentNode)
- => new(
- new DiagnosticDescriptor(
- Id,
- Title,
- Message,
- category: SourceGenerators.Constants.Usage,
- defaultSeverity: DiagnosticSeverity.Warning,
- isEnabledByDefault: true),
- currentNode?.GetLocation());
- }
-}
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/SetterOnReadonlyFieldDiagnostic.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/SetterOnReadonlyFieldDiagnostic.cs
deleted file mode 100644
index 4ee27daf9b26..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Diagnostics/SetterOnReadonlyFieldDiagnostic.cs
+++ /dev/null
@@ -1,28 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using Datadog.Trace.SourceGenerators.Helpers;
-using Microsoft.CodeAnalysis;
-
-namespace Datadog.Trace.SourceGenerators.PublicApi.Diagnostics
-{
- internal static class SetterOnReadonlyFieldDiagnostic
- {
- internal const string Id = "PA3";
- private const string Message = "You can't generate a setter for a readonly or const field";
- private const string Title = "Setter not supported";
-
- public static DiagnosticInfo CreateInfo(SyntaxNode? currentNode)
- => new(
- new DiagnosticDescriptor(
- Id,
- Title,
- Message,
- category: SourceGenerators.Constants.Usage,
- defaultSeverity: DiagnosticSeverity.Warning,
- isEnabledByDefault: true),
- currentNode?.GetLocation());
- }
-}
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/PublicApiGenerator.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/PublicApiGenerator.cs
deleted file mode 100644
index a37228b24390..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/PublicApiGenerator.cs
+++ /dev/null
@@ -1,315 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-using System.Text;
-using System.Threading;
-using Datadog.Trace.SourceGenerators.Helpers;
-using Datadog.Trace.SourceGenerators.PublicApi;
-using Datadog.Trace.SourceGenerators.PublicApi.Diagnostics;
-using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
-using Microsoft.CodeAnalysis.Text;
-
-///
-/// Source generator that creates instrumented public properties from fields decorated with [GeneratePublicApi].
-///
-[Generator]
-public class PublicApiGenerator : IIncrementalGenerator
-{
- private const string GeneratePublicApiAttribute = "Datadog.Trace.SourceGenerators.GeneratePublicApiAttribute";
-
- ///
- public void Initialize(IncrementalGeneratorInitializationContext context)
- {
- // Register the attribute source
- context.RegisterPostInitializationOutput(ctx => ctx.AddSource("GeneratePublicApiAttribute.g.cs", Sources.Attributes));
-
- // Expected syntax
- // FieldDeclaration
- // - VariableDeclaration
- // - VariableDeclaration
- var properties =
- context.SyntaxProvider.ForAttributeWithMetadataName(
- GeneratePublicApiAttribute,
- static (node, _) => node is PropertyDeclarationSyntax,
- static (context, ct) => GetPublicApiProperties(context, ct))
- .Where(static m => m is not null)!
- .WithTrackingName(TrackingNames.PostTransform);
-
- context.ReportDiagnostics(
- properties
- .Where(static m => m.Errors.Count > 0)
- .SelectMany(static (x, _) => x.Errors)
- .WithTrackingName(TrackingNames.Diagnostics));
-
- var allValidProperties = properties
- .Where(static m => m.Value.IsValid)
- .Select(static (x, _) => x.Value.PropertyTag)
- .WithTrackingName(TrackingNames.ValidValues)
- .Collect();
-
- context.RegisterSourceOutput(allValidProperties, Execute);
- }
-
- private static void Execute(SourceProductionContext context, ImmutableArray properties)
- {
- if (properties.IsDefaultOrEmpty)
- {
- // nothing to do yet
- return;
- }
-
- var sb = new StringBuilder();
- foreach (var partialClass in properties.GroupBy(x => (x.ClassName, x.Namespace, x.IsRecord)))
- {
- sb.Clear();
-
- var (className, nameSpace, isRecord) = partialClass.Key;
- var source = Sources.CreatePartialClass(sb, nameSpace, className, isRecord, partialClass);
- context.AddSource($"{nameSpace}.{className}.g.cs", SourceText.From(source, Encoding.UTF8));
- }
- }
-
- private static Result<(PublicApiProperty PropertyTag, bool IsValid)> GetPublicApiProperties(
- GeneratorAttributeSyntaxContext ctx, CancellationToken ct)
- {
- var property = (PropertyDeclarationSyntax)ctx.TargetNode;
- var classDec = ctx.TargetNode.Parent as TypeDeclarationSyntax;
-
- bool isReferenceType;
-
- if (classDec is RecordDeclarationSyntax recordDeclaration)
- {
- var keyword = recordDeclaration.ClassOrStructKeyword.Text;
- isReferenceType = string.IsNullOrEmpty(keyword) || keyword == "class";
- }
- else
- {
- isReferenceType = classDec is ClassDeclarationSyntax;
- }
-
- if (classDec is null || !isReferenceType)
- {
- // only support properties on classes
- return new Result<(PublicApiProperty PropertyTag, bool IsValid)>(
- (default, false),
- new EquatableArray(new[] { OnlySupportsClassesDiagnostic.CreateInfo(property) }));
- }
-
- var propertySymbol = ctx.TargetSymbol as IPropertySymbol;
- if (propertySymbol is null)
- {
- // something weird going on
- return new Result<(PublicApiProperty PropertyTag, bool IsValid)>((default, false), default);
- }
-
- List? diagnostics = null;
- bool hasMisconfiguredInput = false;
- int? publicApiGetter = null;
- int? publicApiSetter = null;
- string? obsoleteMessage = null;
-
- foreach (AttributeData attributeData in propertySymbol.GetAttributes())
- {
- if ((attributeData.AttributeClass?.Name == "GeneratePublicApiAttribute" ||
- attributeData.AttributeClass?.Name == "GeneratePublicApi")
- && attributeData.AttributeClass.ToDisplayString() == GeneratePublicApiAttribute)
- {
- var args = attributeData.ConstructorArguments;
- if (args.Length == 0)
- {
- hasMisconfiguredInput = true;
- break;
- }
-
- foreach (TypedConstant typedConstant in attributeData.ConstructorArguments)
- {
- if (typedConstant.Kind == TypedConstantKind.Error)
- {
- hasMisconfiguredInput = true;
- break;
- }
- }
-
- if (hasMisconfiguredInput)
- {
- break;
- }
-
- publicApiGetter = args[0].Value as int?;
-
- if (args.Length > 1)
- {
- publicApiSetter = args[1].Value as int?;
- if (propertySymbol.IsReadOnly && publicApiSetter.HasValue)
- {
- diagnostics ??= new List();
- diagnostics.Add(SetterOnReadonlyFieldDiagnostic.CreateInfo(attributeData.ApplicationSyntaxReference?.GetSyntax()));
- hasMisconfiguredInput = true;
- }
- }
- }
- else if (attributeData.AttributeClass?.ToDisplayString() == "System.ObsoleteAttribute")
- {
- var args = attributeData.ConstructorArguments;
- if (args.Length == 0)
- {
- obsoleteMessage = string.Empty;
- continue;
- }
-
- foreach (TypedConstant typedConstant in args)
- {
- if (typedConstant.Kind == TypedConstantKind.Error)
- {
- hasMisconfiguredInput = true;
- break;
- }
- }
-
- obsoleteMessage = args[0].Value as string;
- }
- }
-
- var fieldName = propertySymbol.Name;
- var propertyName = GetCalculatedPropertyName(fieldName);
- if (string.IsNullOrEmpty(propertyName))
- {
- diagnostics ??= new List();
- diagnostics.Add(NamingProblemDiagnostic.CreateInfo(property));
- hasMisconfiguredInput = true;
- }
-
- if (!classDec.Modifiers.Any(x => x.IsKind(SyntaxKind.PartialKeyword)))
- {
- diagnostics ??= new List();
- diagnostics.Add(PartialModifierIsRequiredDiagnostic.CreateInfo(property));
- }
-
- var errors = diagnostics is { Count: > 0 }
- ? new EquatableArray(diagnostics.ToArray())
- : default;
-
- if (hasMisconfiguredInput)
- {
- return new Result<(PublicApiProperty PropertyTag, bool IsValid)>((default, false), errors);
- }
-
- var tag = new PublicApiProperty(
- nameSpace: GetClassNamespace(classDec),
- className: classDec.Identifier.ToString() + classDec.TypeParameterList,
- isRecord: classDec is RecordDeclarationSyntax,
- fieldName: fieldName,
- propertyName: propertyName!,
- publicApiGetter: publicApiGetter,
- publicApiSetter: publicApiSetter,
- returnType: propertySymbol.Type.ToDisplayString(),
- leadingTrivia: property.GetLeadingTrivia().ToFullString(),
- obsoleteMessage: obsoleteMessage);
-
- return new Result<(PublicApiProperty PropertyTag, bool IsValid)>((tag, true), errors);
- }
-
- private static string? GetCalculatedPropertyName(string fieldName)
- {
- if (string.IsNullOrEmpty(fieldName))
- {
- return null;
- }
-
- if (fieldName[0] == '_')
- {
- return fieldName.Substring(1);
- }
-
- if (fieldName.EndsWith("Internal"))
- {
- return fieldName.Substring(0, fieldName.Length - 8);
- }
-
- return null;
- }
-
- private static string GetClassNamespace(TypeDeclarationSyntax classDec)
- {
- string? nameSpace;
-
- // determine the namespace the class is declared in, if any
- SyntaxNode? potentialNamespaceParent = classDec.Parent;
- while (potentialNamespaceParent != null &&
- potentialNamespaceParent is not NamespaceDeclarationSyntax
- && potentialNamespaceParent is not FileScopedNamespaceDeclarationSyntax)
- {
- potentialNamespaceParent = potentialNamespaceParent.Parent;
- }
-
- if (potentialNamespaceParent is BaseNamespaceDeclarationSyntax namespaceParent)
- {
- nameSpace = namespaceParent.Name.ToString();
- while (true)
- {
- if (namespaceParent.Parent is NamespaceDeclarationSyntax parent)
- {
- namespaceParent = parent;
- nameSpace = $"{namespaceParent.Name}.{nameSpace}";
- }
- else
- {
- return nameSpace;
- }
- }
- }
-
- return string.Empty;
- }
-
- internal readonly struct PartialClasses
- {
- public readonly string Namespace;
- public readonly string ClassName;
- public readonly ImmutableArray TagProperties;
- public readonly ImmutableArray MetricProperties;
-
- public PartialClasses(string nameSpace, string className, ImmutableArray tagProperties, ImmutableArray metricProperties)
- {
- Namespace = nameSpace;
- ClassName = className;
- TagProperties = tagProperties;
- MetricProperties = metricProperties;
- }
- }
-
- internal readonly record struct PublicApiProperty
- {
- public readonly string Namespace;
- public readonly string ClassName;
- public readonly bool IsRecord;
- public readonly string FieldName;
- public readonly int? PublicApiGetter;
- public readonly int? PublicApiSetter;
- public readonly string PropertyName;
- public readonly string ReturnType;
- public readonly string LeadingTrivia;
- public readonly string? ObsoleteMessage;
-
- public PublicApiProperty(string nameSpace, string className, bool isRecord, string fieldName, int? publicApiGetter, int? publicApiSetter, string propertyName, string returnType, string leadingTrivia, string? obsoleteMessage)
- {
- Namespace = nameSpace;
- ClassName = className;
- IsRecord = isRecord;
- FieldName = fieldName;
- PublicApiGetter = publicApiGetter;
- PublicApiSetter = publicApiSetter;
- PropertyName = propertyName;
- ReturnType = returnType;
- LeadingTrivia = leadingTrivia;
- ObsoleteMessage = obsoleteMessage;
- }
- }
-}
diff --git a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Sources.cs b/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Sources.cs
deleted file mode 100644
index a4f99f54d959..000000000000
--- a/tracer/src/Datadog.Trace.SourceGenerators/PublicApi/Sources.cs
+++ /dev/null
@@ -1,141 +0,0 @@
-//
-// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
-// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
-//
-
-using System;
-using System.Collections.Generic;
-using System.Text;
-
-namespace Datadog.Trace.SourceGenerators.PublicApi;
-
-internal class Sources
-{
- public const string Attributes = Constants.FileHeader + """
- namespace Datadog.Trace.SourceGenerators;
-
- ///
- /// Used to generate a public property for a decorated field,
- /// allowing adding aspect-oriented changes such as telemetry etc.
- /// Any documentation added to the field is copied to the public API
- ///
- [System.AttributeUsage(System.AttributeTargets.Property, AllowMultiple = false)]
- internal class GeneratePublicApiAttribute : System.Attribute
- {
- ///
- /// Initializes a new instance of the class.
- /// Adds a getter and a setter.
- ///
- /// Gets the name of the public API used for the property getter
- /// Gets the name of the public API used for the property setter
- public GeneratePublicApiAttribute(
- Datadog.Trace.Telemetry.Metrics.PublicApiUsage getApiUsage,
- Datadog.Trace.Telemetry.Metrics.PublicApiUsage setApiUsage)
- {
- Getter = getApiUsage;
- Setter = setApiUsage;
- }
-
- ///
- /// Initializes a new instance of the class.
- /// Adds a getter only.
- ///
- /// Gets the name of the public API used for the property getter. If null, no getter will be generated.
- public GeneratePublicApiAttribute(Datadog.Trace.Telemetry.Metrics.PublicApiUsage getApiUsage)
- {
- Getter = getApiUsage;
- }
-
- ///
- /// Gets the name of the public API used for the getter
- ///
- public Datadog.Trace.Telemetry.Metrics.PublicApiUsage Getter { get; }
-
- ///
- /// Gets the name of the public API used for the setter
- ///
- public Datadog.Trace.Telemetry.Metrics.PublicApiUsage? Setter { get; }
- }
-
- ///
- /// A marker attribute added to a public API to indicate it should only be
- /// called by consumers. Used by analyzers to confirm we're not calling a public API method.
- ///
- [System.Diagnostics.Conditional("DEBUG")]
- [System.AttributeUsage(
- System.AttributeTargets.Field
- | System.AttributeTargets.Property
- | System.AttributeTargets.Method
- | System.AttributeTargets.Constructor)]
- internal sealed class PublicApiAttribute : System.Attribute
- {
- }
-
- """;
-
- public static string CreatePartialClass(StringBuilder sb, string nameSpace, string className, bool isRecord, IEnumerable properties)
- {
- var classKeyword = isRecord ? "record" : "class";
-
- return Constants.FileHeader + $$"""
- namespace {{nameSpace}};
- partial {{classKeyword}} {{className}}
- {{{GetProperties(sb, properties)}}
- }
- """;
- }
-
- private static string GetProperties(StringBuilder sb, IEnumerable properties)
- {
- foreach (var property in properties)
- {
- sb.AppendLine();
- // The leading trivia may have arbitrary whitespace, so the indentation might not be right here, but
- // it's not worth worrying about IMO
- if (!string.IsNullOrWhiteSpace(property.LeadingTrivia))
- {
- sb.AppendLine(property.LeadingTrivia.TrimEnd());
- }
-
- if (property.ObsoleteMessage is { } obsolete)
- {
- sb.Append(" [System.Obsolete");
- if (obsolete != string.Empty)
- {
- sb.Append("(\"").Append(obsolete).Append("\")");
- }
-
- sb.Append(']').AppendLine();
- }
-
- sb.AppendLine(
- $$"""
- [Datadog.Trace.SourceGenerators.PublicApi]
- public {{property.ReturnType}} {{property.PropertyName}}
- {
- get
- {
- Datadog.Trace.Telemetry.TelemetryFactory.Metrics.Record(
- (Datadog.Trace.Telemetry.Metrics.PublicApiUsage){{property.PublicApiGetter}});
- return {{property.FieldName}};
- }
- """);
- if (property.PublicApiSetter.HasValue)
- {
- sb.AppendLine(
- $$"""
- set
- {
- Datadog.Trace.Telemetry.TelemetryFactory.Metrics.Record(
- (Datadog.Trace.Telemetry.Metrics.PublicApiUsage){{property.PublicApiSetter}});
- {{property.FieldName}} = value;
- }
- """);
- }
-
- sb.Append(" }");
- }
-
- return sb.ToString();
- }
-}
diff --git a/tracer/src/Datadog.Trace.Tools.Runner/Utils.cs b/tracer/src/Datadog.Trace.Tools.Runner/Utils.cs
index ed2b683ba877..1a0064c0029c 100644
--- a/tracer/src/Datadog.Trace.Tools.Runner/Utils.cs
+++ b/tracer/src/Datadog.Trace.Tools.Runner/Utils.cs
@@ -409,9 +409,9 @@ public static string GetEnvironmentVariable(string key, string defaultValue = nu
var tracerSettings = new TracerSettings(configurationSource, new ConfigurationTelemetry(), new OverrideErrorLog());
var settings = new ImmutableTracerSettings(tracerSettings, unusedParamNotToUsePublicApi: true);
- Log.Debug("Creating DiscoveryService for: {AgentUriInternal}", settings.ExporterInternal.AgentUriInternal);
+ Log.Debug("Creating DiscoveryService for: {AgentUri}", settings.Exporter.AgentUri);
var discoveryService = DiscoveryService.Create(
- settings.ExporterInternal,
+ settings.Exporter,
tcpTimeout: TimeSpan.FromSeconds(5),
initialRetryDelayMs: 200,
maxRetryDelayMs: 1000,
@@ -425,7 +425,7 @@ public static string GetEnvironmentVariable(string key, string defaultValue = nu
using (cts.Token.Register(
() =>
{
- WriteError($"Error connecting to the Datadog Agent at {tracerSettings.ExporterInternal.AgentUriInternal}.");
+ WriteError($"Error connecting to the Datadog Agent at {tracerSettings.Exporter.AgentUriInternal}.");
tcs.TrySetResult(null);
}))
{
diff --git a/tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/AgentConnectivityCheck.cs b/tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/AgentConnectivityCheck.cs
index d29aaf4a0606..3925f421ac51 100644
--- a/tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/AgentConnectivityCheck.cs
+++ b/tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/AgentConnectivityCheck.cs
@@ -110,7 +110,7 @@ private static HttpClient CreateHttpClient(ExporterSettings settings)
ConnectCallback = async (context, token) =>
{
var socket = new Socket(AddressFamily.Unix, SocketType.Stream, ProtocolType.IP);
- var endpoint = new UnixDomainSocketEndPoint(settings.TracesUnixDomainSocketPathInternal!);
+ var endpoint = new UnixDomainSocketEndPoint(settings.TracesUnixDomainSocketPath!);
await socket.ConnectAsync(endpoint, token).ConfigureAwait(false);
return new NetworkStream(socket, ownsSocket: false);
}
@@ -125,7 +125,7 @@ private static HttpClient CreateHttpClient(ExporterSettings settings)
{
ConnectCallback = async (context, token) =>
{
- var pipeStream = new NamedPipeClientStream(".", settings.TracesPipeNameInternal!, PipeDirection.InOut, PipeOptions.Asynchronous);
+ var pipeStream = new NamedPipeClientStream(".", settings.TracesPipeName!, PipeDirection.InOut, PipeOptions.Asynchronous);
await pipeStream.ConnectAsync(500, token).ConfigureAwait(false);
return pipeStream;
}
@@ -147,7 +147,7 @@ private static void DisplayInfoMessage(ExporterSettings settings)
if (settings.TracesTransport == TracesTransportType.UnixDomainSocket)
{
transport = "domain sockets";
- endpoint = settings.TracesUnixDomainSocketPathInternal ?? "";
+ endpoint = settings.TracesUnixDomainSocketPath ?? "";
}
else
{
diff --git a/tracer/src/Datadog.Trace.Tools.dd_dotnet/ExporterSettings.cs b/tracer/src/Datadog.Trace.Tools.dd_dotnet/ExporterSettings.cs
index 2b0b2008fcd7..2917c86c17ef 100644
--- a/tracer/src/Datadog.Trace.Tools.dd_dotnet/ExporterSettings.cs
+++ b/tracer/src/Datadog.Trace.Tools.dd_dotnet/ExporterSettings.cs
@@ -60,9 +60,9 @@ internal enum TelemetryErrorCode
internal TracesTransportType TracesTransport { get; private set; }
- internal string? TracesPipeNameInternal { get; private set; }
+ internal string? TracesPipeName { get; private set; }
- internal string? TracesUnixDomainSocketPathInternal { get; private set; }
+ internal string? TracesUnixDomainSocketPath { get; private set; }
private static string? GetValue(IConfigurationSource? configuration, params string[] keys)
{
diff --git a/tracer/src/Datadog.Trace/Activity/OtlpHelpers.cs b/tracer/src/Datadog.Trace/Activity/OtlpHelpers.cs
index 443135368ded..91ad56f5a3bf 100644
--- a/tracer/src/Datadog.Trace/Activity/OtlpHelpers.cs
+++ b/tracer/src/Datadog.Trace/Activity/OtlpHelpers.cs
@@ -62,7 +62,7 @@ private static void AgentConvertSpan(TInner activity, Span span)
// Fixup "version" tag
// Fallback to static instance if no tracer associated with the trace
var tracer = span.Context.TraceContext?.Tracer ?? Tracer.Instance;
- if (tracer.Settings.ServiceVersionInternal is null
+ if (tracer.Settings.ServiceVersion is null
&& span.GetTag("service.version") is { Length: > 1 } otelServiceVersion)
{
span.SetTag(Tags.Version, otelServiceVersion);
diff --git a/tracer/src/Datadog.Trace/Agent/AgentTransportStrategy.cs b/tracer/src/Datadog.Trace/Agent/AgentTransportStrategy.cs
index 556cda96440b..7ac448ef987f 100644
--- a/tracer/src/Datadog.Trace/Agent/AgentTransportStrategy.cs
+++ b/tracer/src/Datadog.Trace/Agent/AgentTransportStrategy.cs
@@ -31,7 +31,7 @@ internal static class AgentTransportStrategy
/// A func that returns an for use
/// with
/// A func that returns the endpoint to send requests to for a given "base" endpoint.
- /// The base endpoint will be for TCP requests and
+ /// The base endpoint will be for TCP requests and
/// http://localhost/ for named pipes/UDS
public static IApiRequestFactory Get(
ImmutableExporterSettings settings,
@@ -46,24 +46,24 @@ public static IApiRequestFactory Get(
switch (strategy)
{
case TracesTransportType.WindowsNamedPipe:
- Log.Information("Using " + nameof(NamedPipeClientStreamFactory) + " for {ProductName} transport, with pipe name {TracesPipeName} and timeout {TracesPipeTimeoutMs}ms.", productName, settings.TracesPipeNameInternal, settings.TracesPipeTimeoutMsInternal);
+ Log.Information("Using " + nameof(NamedPipeClientStreamFactory) + " for {ProductName} transport, with pipe name {TracesPipeName} and timeout {TracesPipeTimeoutMs}ms.", productName, settings.TracesPipeName, settings.TracesPipeTimeoutMs);
return new HttpStreamRequestFactory(
- new NamedPipeClientStreamFactory(settings.TracesPipeNameInternal, settings.TracesPipeTimeoutMsInternal),
+ new NamedPipeClientStreamFactory(settings.TracesPipeName, settings.TracesPipeTimeoutMs),
new DatadogHttpClient(getHttpHeaderHelper()),
getBaseEndpoint(Localhost));
case TracesTransportType.UnixDomainSocket:
#if NET5_0_OR_GREATER
- Log.Information("Using " + nameof(SocketHandlerRequestFactory) + " for {ProductName} transport, with UDS path {Path}.", productName, settings.TracesUnixDomainSocketPathInternal);
+ Log.Information("Using " + nameof(SocketHandlerRequestFactory) + " for {ProductName} transport, with UDS path {Path}.", productName, settings.TracesUnixDomainSocketPath);
// use http://localhost as base endpoint
return new SocketHandlerRequestFactory(
- new UnixDomainSocketStreamFactory(settings.TracesUnixDomainSocketPathInternal),
+ new UnixDomainSocketStreamFactory(settings.TracesUnixDomainSocketPath),
defaultAgentHeaders,
getBaseEndpoint(Localhost));
#elif NETCOREAPP3_1_OR_GREATER
- Log.Information("Using " + nameof(UnixDomainSocketStreamFactory) + " for {ProductName} transport, with Unix Domain Sockets path {TracesUnixDomainSocketPath} and timeout {TracesPipeTimeoutMs}ms.", productName, settings.TracesUnixDomainSocketPathInternal, settings.TracesPipeTimeoutMsInternal);
+ Log.Information("Using " + nameof(UnixDomainSocketStreamFactory) + " for {ProductName} transport, with Unix Domain Sockets path {TracesUnixDomainSocketPath} and timeout {TracesPipeTimeoutMs}ms.", productName, settings.TracesUnixDomainSocketPath, settings.TracesPipeTimeoutMs);
return new HttpStreamRequestFactory(
- new UnixDomainSocketStreamFactory(settings.TracesUnixDomainSocketPathInternal),
+ new UnixDomainSocketStreamFactory(settings.TracesUnixDomainSocketPath),
new DatadogHttpClient(getHttpHeaderHelper()),
getBaseEndpoint(Localhost));
#else
@@ -74,10 +74,10 @@ public static IApiRequestFactory Get(
default:
#if NETCOREAPP
Log.Information("Using " + nameof(HttpClientRequestFactory) + " for {ProductName} transport.", productName);
- return new HttpClientRequestFactory(getBaseEndpoint(settings.AgentUriInternal), defaultAgentHeaders, timeout: tcpTimeout);
+ return new HttpClientRequestFactory(getBaseEndpoint(settings.AgentUri), defaultAgentHeaders, timeout: tcpTimeout);
#else
Log.Information("Using " + nameof(ApiWebRequestFactory) + " for {ProductName} transport.", productName);
- return new ApiWebRequestFactory(getBaseEndpoint(settings.AgentUriInternal), defaultAgentHeaders, timeout: tcpTimeout);
+ return new ApiWebRequestFactory(getBaseEndpoint(settings.AgentUri), defaultAgentHeaders, timeout: tcpTimeout);
#endif
}
}
diff --git a/tracer/src/Datadog.Trace/Agent/MessagePack/SpanMessagePackFormatter.cs b/tracer/src/Datadog.Trace/Agent/MessagePack/SpanMessagePackFormatter.cs
index 661562a8b707..2844781f9fa0 100644
--- a/tracer/src/Datadog.Trace/Agent/MessagePack/SpanMessagePackFormatter.cs
+++ b/tracer/src/Datadog.Trace/Agent/MessagePack/SpanMessagePackFormatter.cs
@@ -147,7 +147,7 @@ private int Serialize(ref byte[] bytes, int offset, in SpanModel spanModel)
// It should be the number of members of the object to be serialized.
var len = 8;
- if (span.Context.ParentIdInternal > 0)
+ if (span.Context.ParentId > 0)
{
len++;
}
@@ -200,10 +200,10 @@ private int Serialize(ref byte[] bytes, int offset, in SpanModel spanModel)
offset += MessagePackBinary.WriteStringBytes(ref bytes, offset, _durationBytes);
offset += MessagePackBinary.WriteInt64(ref bytes, offset, span.Duration.ToNanoseconds());
- if (span.Context.ParentIdInternal > 0)
+ if (span.Context.ParentId > 0)
{
offset += MessagePackBinary.WriteStringBytes(ref bytes, offset, _parentIdBytes);
- offset += MessagePackBinary.WriteUInt64(ref bytes, offset, (ulong)span.Context.ParentIdInternal);
+ offset += MessagePackBinary.WriteUInt64(ref bytes, offset, (ulong)span.Context.ParentId);
}
if (span.Error)
@@ -420,7 +420,7 @@ private int WriteTags(ref byte[] bytes, int offset, in SpanModel model, ITagProc
offset += MessagePackBinary.WriteStringBytes(ref bytes, offset, _languageValueBytes);
// add "version" tags to all spans whose service name is the default service name
- var serviceNameEqualsDefault = string.Equals(span.Context.ServiceNameInternal, model.TraceChunk.DefaultServiceName, StringComparison.OrdinalIgnoreCase);
+ var serviceNameEqualsDefault = string.Equals(span.Context.ServiceName, model.TraceChunk.DefaultServiceName, StringComparison.OrdinalIgnoreCase);
if (serviceNameEqualsDefault)
{
var versionRawBytes = MessagePackStringCache.GetVersionBytes(model.TraceChunk.ServiceVersion);
diff --git a/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs b/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs
index 7903e1b39246..e47384bb0295 100644
--- a/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs
+++ b/tracer/src/Datadog.Trace/Agent/MessagePack/TraceChunkModel.cs
@@ -126,7 +126,7 @@ internal TraceChunkModel(in ArraySegment spans, Span? localRootSpan)
// skip the HashSet to avoid initializing it yet, always iterate the array of spans.
ContainsLocalRootSpan = IndexOf(localRootSpanId, spans.Count - 1) >= 0;
- HasUpstreamService = localRootSpan.Context.ParentIdInternal is not (null or 0);
+ HasUpstreamService = localRootSpan.Context.ParentId is not (null or 0);
}
}
@@ -143,7 +143,7 @@ public SpanModel GetSpanModel(int spanIndex)
}
var span = _spans.Array![_spans.Offset + spanIndex];
- var parentId = span.Context.ParentIdInternal ?? 0;
+ var parentId = span.Context.ParentId ?? 0;
bool isLocalRoot = parentId is 0 || span.SpanId == LocalRootSpanId;
bool isFirstSpan = spanIndex == 0;
diff --git a/tracer/src/Datadog.Trace/Agent/StatsAggregator.cs b/tracer/src/Datadog.Trace/Agent/StatsAggregator.cs
index 1055086568ca..a6e531a7af9d 100644
--- a/tracer/src/Datadog.Trace/Agent/StatsAggregator.cs
+++ b/tracer/src/Datadog.Trace/Agent/StatsAggregator.cs
@@ -65,8 +65,8 @@ internal StatsAggregator(IApi api, ImmutableTracerSettings settings, IDiscoveryS
var header = new ClientStatsPayload
{
- Environment = settings.EnvironmentInternal,
- Version = settings.ServiceVersionInternal,
+ Environment = settings.Environment,
+ Version = settings.ServiceVersion,
HostName = HostMetadata.Instance.Hostname
};
@@ -93,7 +93,7 @@ internal StatsAggregator(IApi api, ImmutableTracerSettings settings, IDiscoveryS
public static IStatsAggregator Create(IApi api, ImmutableTracerSettings settings, IDiscoveryService discoveryService)
{
- return settings.StatsComputationEnabledInternal ? new StatsAggregator(api, settings, discoveryService) : new NullStatsAggregator();
+ return settings.StatsComputationEnabled ? new StatsAggregator(api, settings, discoveryService) : new NullStatsAggregator();
}
public Task DisposeAsync()
diff --git a/tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs b/tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs
index 90ac82691df8..df4f96fd4b6b 100644
--- a/tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs
+++ b/tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs
@@ -79,14 +79,14 @@ public void Dispose()
internal static void AddHeaderTagsFromHttpResponse(HttpContext httpContext, Scope scope)
{
- if (!Tracer.Instance.Settings.HeaderTagsInternal.IsNullOrEmpty() &&
+ if (!Tracer.Instance.Settings.HeaderTags.IsNullOrEmpty() &&
httpContext != null &&
HttpRuntime.UsingIntegratedPipeline &&
_canReadHttpResponseHeaders)
{
try
{
- scope.Span.SetHeaderTags(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTagsInternal, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
+ scope.Span.SetHeaderTags(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
}
catch (PlatformNotSupportedException ex)
{
@@ -158,7 +158,7 @@ private void OnBeginRequest(object sender, EventArgs eventArgs)
scope.Span.DecorateWebServerSpan(resourceName: null, httpMethod, host, url, userAgent, tags);
if (headers is not null)
{
- SpanContextPropagator.Instance.AddHeadersToSpanAsTags(scope.Span, headers.Value, tracer.Settings.HeaderTagsInternal, defaultTagPrefix: SpanContextPropagator.HttpRequestHeadersTagPrefix);
+ SpanContextPropagator.Instance.AddHeadersToSpanAsTags(scope.Span, headers.Value, tracer.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpRequestHeadersTagPrefix);
}
if (tracer.Settings.IpHeaderEnabled || Security.Instance.AppsecEnabled)
diff --git a/tracer/src/Datadog.Trace/AsyncLocalScopeManager.cs b/tracer/src/Datadog.Trace/AsyncLocalScopeManager.cs
index 8ed4d2405899..47833357cc0e 100644
--- a/tracer/src/Datadog.Trace/AsyncLocalScopeManager.cs
+++ b/tracer/src/Datadog.Trace/AsyncLocalScopeManager.cs
@@ -52,7 +52,7 @@ public void Close(Scope scope)
Active = scope.Parent;
// scope.Parent is null for distributed traces, so use scope.Span.Context.Parent
- DistributedTracer.Instance.SetSpanContext(scope.Span.Context.ParentInternal as SpanContext);
+ DistributedTracer.Instance.SetSpanContext(scope.Span.Context.Parent as SpanContext);
}
private static AsyncLocal CreateScope()
diff --git a/tracer/src/Datadog.Trace/Ci/Agent/ApmAgentWriter.cs b/tracer/src/Datadog.Trace/Ci/Agent/ApmAgentWriter.cs
index a23907e712e1..48193f34c91b 100644
--- a/tracer/src/Datadog.Trace/Ci/Agent/ApmAgentWriter.cs
+++ b/tracer/src/Datadog.Trace/Ci/Agent/ApmAgentWriter.cs
@@ -27,8 +27,8 @@ internal class ApmAgentWriter : IEventWriter
public ApmAgentWriter(ImmutableTracerSettings settings, Action> updateSampleRates, IDiscoveryService discoveryService, int maxBufferSize = DefaultMaxBufferSize)
{
- var partialFlushEnabled = settings.ExporterInternal.PartialFlushEnabledInternal;
- var apiRequestFactory = TracesTransportStrategy.Get(settings.ExporterInternal);
+ var partialFlushEnabled = settings.Exporter.PartialFlushEnabled;
+ var apiRequestFactory = TracesTransportStrategy.Get(settings.Exporter);
var api = new Api(apiRequestFactory, null, updateSampleRates, partialFlushEnabled);
var statsAggregator = StatsAggregator.Create(api, settings, discoveryService);
diff --git a/tracer/src/Datadog.Trace/Ci/Agent/MessagePack/CIEventMessagePackFormatter.cs b/tracer/src/Datadog.Trace/Ci/Agent/MessagePack/CIEventMessagePackFormatter.cs
index 392cf31d9277..4496e31eb012 100644
--- a/tracer/src/Datadog.Trace/Ci/Agent/MessagePack/CIEventMessagePackFormatter.cs
+++ b/tracer/src/Datadog.Trace/Ci/Agent/MessagePack/CIEventMessagePackFormatter.cs
@@ -39,9 +39,9 @@ internal class CIEventMessagePackFormatter : EventMessagePackFormatter Process(ArraySegment trace)
for (var i = trace.Offset + trace.Count - 1; i >= trace.Offset; i--)
{
var span = trace.Array![i];
- if (span.Context.ParentInternal is null &&
+ if (span.Context.Parent is null &&
span.Type != SpanTypes.Test &&
span.Type != SpanTypes.Browser &&
span.Type != SpanTypes.TestSuite &&
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetMvcIntegration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetMvcIntegration.cs
index bbb8de8a0567..51b7910bbed5 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetMvcIntegration.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetMvcIntegration.cs
@@ -164,7 +164,7 @@ internal static Scope CreateScope(ControllerContextStruct controllerContext)
if (headers is not null)
{
- SpanContextPropagator.Instance.AddHeadersToSpanAsTags(span, headers.Value, tracer.Settings.HeaderTagsInternal, SpanContextPropagator.HttpRequestHeadersTagPrefix);
+ SpanContextPropagator.Instance.AddHeadersToSpanAsTags(span, headers.Value, tracer.Settings.HeaderTags, SpanContextPropagator.HttpRequestHeadersTagPrefix);
}
if (tracer.Settings.IpHeaderEnabled || Security.Instance.AppsecEnabled)
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetWebApi2Integration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetWebApi2Integration.cs
index 28d65bc254f4..4c4810829f45 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetWebApi2Integration.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/AspNetWebApi2Integration.cs
@@ -101,7 +101,7 @@ internal static Scope CreateScope(IHttpControllerContext controllerContext, out
if (headersCollection is not null)
{
- SpanContextPropagator.Instance.AddHeadersToSpanAsTags(scope.Span, headersCollection.Value, tracer.Settings.HeaderTagsInternal, SpanContextPropagator.HttpRequestHeadersTagPrefix, request.Headers.UserAgent.ToString());
+ SpanContextPropagator.Instance.AddHeadersToSpanAsTags(scope.Span, headersCollection.Value, tracer.Settings.HeaderTags, SpanContextPropagator.HttpRequestHeadersTagPrefix, request.Headers.UserAgent.ToString());
}
tags.SetAnalyticsSampleRate(IntegrationId, tracer.Settings, enabledWithGlobalSetting: true);
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/HttpContextHelper.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/HttpContextHelper.cs
index e831e3f573ff..0f5460ae0b08 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/HttpContextHelper.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNet/HttpContextHelper.cs
@@ -19,11 +19,11 @@ internal static class HttpContextHelper
internal static void AddHeaderTagsFromHttpResponse(System.Web.HttpContext httpContext, Scope scope)
{
- if (httpContext != null && HttpRuntime.UsingIntegratedPipeline && _canReadHttpResponseHeaders && !Tracer.Instance.Settings.HeaderTagsInternal.IsNullOrEmpty())
+ if (httpContext != null && HttpRuntime.UsingIntegratedPipeline && _canReadHttpResponseHeaders && !Tracer.Instance.Settings.HeaderTags.IsNullOrEmpty())
{
try
{
- scope.Span.SetHeaderTags(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTagsInternal, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
+ scope.Span.SetHeaderTags(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
}
catch (PlatformNotSupportedException ex)
{
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/GrpcProtocolHelpersBuildHttpErrorResponseIntegration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/GrpcProtocolHelpersBuildHttpErrorResponseIntegration.cs
index d4c0b939975f..d6fa373f5204 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/GrpcProtocolHelpersBuildHttpErrorResponseIntegration.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/GrpcProtocolHelpersBuildHttpErrorResponseIntegration.cs
@@ -54,7 +54,7 @@ internal static CallTargetState OnMethodBegin(HttpResponse response, int httpSta
// There won't be any response metadata, as interceptors haven't executed, but we can grab
// the request metadata directly from the HttpRequest
var request = response.HttpContext.Request;
- span.SetHeaderTags(new HeadersCollectionAdapter(request.Headers), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
+ span.SetHeaderTags(new HeadersCollectionAdapter(request.Headers), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
}
return CallTargetState.GetDefault();
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/HttpContextServerCallContextLogCallEndIntegration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/HttpContextServerCallContextLogCallEndIntegration.cs
index d7488ef8986d..6ee6314d759d 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/HttpContextServerCallContextLogCallEndIntegration.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcAspNetCoreServer/HttpContextServerCallContextLogCallEndIntegration.cs
@@ -49,12 +49,12 @@ internal static CallTargetState OnMethodBegin(TTarget instance)
if (callContext.RequestHeaders is { Count: > 0 } requestMetadata)
{
- span.SetHeaderTags(new MetadataHeadersCollection(requestMetadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(requestMetadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
}
if (callContext.ResponseTrailers is { Count: > 0 } responseMetadata)
{
- span.SetHeaderTags(new MetadataHeadersCollection(responseMetadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(responseMetadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
}
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcNetClient/GrpcDotNetClientCommon.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcNetClient/GrpcDotNetClientCommon.cs
index 26e164b54c66..70ecc1f31ca9 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcNetClient/GrpcDotNetClientCommon.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcDotNet/GrpcNetClient/GrpcDotNetClientCommon.cs
@@ -62,7 +62,7 @@ internal static class GrpcDotNetClientCommon
if (grpcCall.Options.Headers is { Count: > 0 })
{
var metadata = new MetadataHeadersCollection(grpcCall.Options.Headers);
- span.SetHeaderTags(metadata, tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
+ span.SetHeaderTags(metadata, tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.RequestMetadataTagPrefix);
}
tracer.TracerManager.Telemetry.IntegrationGeneratedSpan(IntegrationId.Grpc);
@@ -90,20 +90,20 @@ public static void RecordResponseMetadataAndStatus(Tracer tracer, TGr
if (grpcCall.HttpResponse is { Headers: { } responseHeaders })
{
var metadata = new HttpResponseHeadersCollection(responseHeaders);
- span.SetHeaderTags(metadata, tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(metadata, tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
// Note that this will be null if they haven't read the response body yet, but we can't force that on users
if (grpcCall.TryGetTrailers(out var trailers) && trailers is { Count: > 0 })
{
var metadata = new MetadataHeadersCollection(trailers);
- span.SetHeaderTags(metadata, tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(metadata, tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
else if (grpcCall.HttpResponse is { } httpResponse
&& httpResponse.DuckCast().TrailingHeaders is { } trailingHeaders)
{
var metadata = new HttpResponseHeadersCollection(trailingHeaders);
- span.SetHeaderTags(metadata, tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(metadata, tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
GrpcCommon.RecordFinalClientSpanStatus(Tracer.Instance, grpcStatusCode, errorMessage, ex);
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleFinishedInstrumentation.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleFinishedInstrumentation.cs
index 67b530d6b0fc..cabc3a93fb63 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleFinishedInstrumentation.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleFinishedInstrumentation.cs
@@ -46,14 +46,14 @@ internal static CallTargetState OnMethodBegin(TTarget instance
{
if (receivedStatus.Trailers is { Count: > 0 })
{
- span.SetHeaderTags(new MetadataHeadersCollection(receivedStatus.Trailers), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(receivedStatus.Trailers), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
else if (asyncCall.ResponseHeadersAsync is { IsCompleted: true } task)
{
var metadata = task.DuckCast().Result;
if (metadata?.Count > 0)
{
- span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
}
}
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleUnaryResponseInstrumentation.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleUnaryResponseInstrumentation.cs
index 6924577f1e3c..c22270145b8d 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleUnaryResponseInstrumentation.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/AsyncCallHandleUnaryResponseInstrumentation.cs
@@ -53,14 +53,14 @@ internal static CallTargetState OnMethodBegin 0 })
{
- span.SetHeaderTags(new MetadataHeadersCollection(receivedStatus.Trailers), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(receivedStatus.Trailers), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
else if (responseHeaders is not null)
{
var responseMetadata = responseHeaders.DuckCast();
if (responseMetadata.Count > 0)
{
- span.SetHeaderTags(new MetadataHeadersCollection(responseMetadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(responseMetadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
}
}
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/GrpcLegacyClientCommon.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/GrpcLegacyClientCommon.cs
index 3594b23d4eca..2b2c314c6b27 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/GrpcLegacyClientCommon.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Client/GrpcLegacyClientCommon.cs
@@ -76,7 +76,7 @@ internal static class GrpcLegacyClientCommon
span.Type = SpanTypes.Grpc;
span.ResourceName = methodFullName;
- span.SetHeaderTags(requestMetadataWrapper, tracer.Settings.GrpcTagsInternal, GrpcCommon.RequestMetadataTagPrefix);
+ span.SetHeaderTags(requestMetadataWrapper, tracer.Settings.GrpcTags, GrpcCommon.RequestMetadataTagPrefix);
scope = tracer.ActivateSpan(span);
if (setSamplingPriority && existingSpanContext?.SamplingPriority is { } samplingPriority)
@@ -141,7 +141,7 @@ public static void InjectHeaders(Tracer tracer, TMethod m
methodName: method.Name,
serviceName: method.ServiceName,
startTime: span.StartTime,
- parentContext: span.Context.ParentInternal);
+ parentContext: span.Context.Parent);
// Add the propagation headers
var context = new PropagationContext(span.Context, Baggage.Current);
@@ -194,7 +194,7 @@ private static void AddTemporaryHeaders(IMetadata metadata, int grpcType, string
if (parentContext is not null)
{
metadata.Add(TemporaryHeaders.ParentId, parentContext.SpanId.ToString());
- var parentService = parentContext is SpanContext s ? s.ServiceNameInternal : parentContext.ServiceName;
+ var parentService = parentContext is SpanContext s ? s.ServiceName : parentContext.ServiceName;
if (parentService is not null)
{
metadata.Add(TemporaryHeaders.ParentService, parentService);
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendInitialMetadataAsyncInstrumentation.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendInitialMetadataAsyncInstrumentation.cs
index cc66ecedc5ec..036425d01e15 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendInitialMetadataAsyncInstrumentation.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendInitialMetadataAsyncInstrumentation.cs
@@ -37,7 +37,7 @@ internal static CallTargetState OnMethodBegin(TTarget instan
var metadata = headers.DuckCast();
if (metadata.Count > 0)
{
- span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
}
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendStatusFromServerAsyncInstrumentation.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendStatusFromServerAsyncInstrumentation.cs
index 1bddbc433b1f..fa5eb3d27d0e 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendStatusFromServerAsyncInstrumentation.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/AsyncCallServerSendStatusFromServerAsyncInstrumentation.cs
@@ -43,7 +43,7 @@ internal static CallTargetState OnMethodBegin();
if (metadata.Count > 0)
{
- span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTagsInternal, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTags, defaultTagPrefix: GrpcCommon.ResponseMetadataTagPrefix);
}
}
}
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/GrpcLegacyServerCommon.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/GrpcLegacyServerCommon.cs
index 24c89a0d2c87..5bb0aa9e03d2 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/GrpcLegacyServerCommon.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Grpc/GrpcLegacy/Server/GrpcLegacyServerCommon.cs
@@ -49,7 +49,7 @@ internal class GrpcLegacyServerCommon
if (metadata?.Count > 0)
{
- span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTagsInternal, GrpcCommon.RequestMetadataTagPrefix);
+ span.SetHeaderTags(new MetadataHeadersCollection(metadata), tracer.Settings.GrpcTags, GrpcCommon.RequestMetadataTagPrefix);
}
tracer.TracerManager.Telemetry.IntegrationGeneratedSpan(IntegrationId.Grpc);
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaConsumerConsumeIntegration.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaConsumerConsumeIntegration.cs
index 98d734d58216..603458b81f85 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaConsumerConsumeIntegration.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaConsumerConsumeIntegration.cs
@@ -74,7 +74,7 @@ internal static CallTargetReturn OnMethodEnd(TTar
consumeResult.Offset,
consumeResult.Message);
- if (!Tracer.Instance.Settings.KafkaCreateConsumerScopeEnabledInternal)
+ if (!Tracer.Instance.Settings.KafkaCreateConsumerScopeEnabled)
{
// Close and dispose the scope immediately
scope.DisposeWithException(exception);
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaHelper.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaHelper.cs
index 0b5dcec22daf..6c77a345aa6c 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaHelper.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Kafka/KafkaHelper.cs
@@ -247,7 +247,7 @@ private static long GetMessageSize(T message)
pathwayContext);
message?.Headers?.Remove(DataStreamsPropagationHeaders.TemporaryBase64PathwayContext); // remove eventual junk
- if (!tracer.Settings.KafkaCreateConsumerScopeEnabledInternal && message?.Headers is not null && span.Context.PathwayContext != null)
+ if (!tracer.Settings.KafkaCreateConsumerScopeEnabled && message?.Headers is not null && span.Context.PathwayContext != null)
{
// write the _new_ pathway (the "consume" checkpoint that we just set above) to the headers as a way to pass its value to an eventual
// call to SpanContextExtractor.Extract by a user who'd like to re-pair pathways after a batch consume.
@@ -270,7 +270,7 @@ internal static void CloseConsumerScope(Tracer tracer)
try
{
if (!tracer.Settings.IsIntegrationEnabled(KafkaConstants.IntegrationId)
- || !tracer.Settings.KafkaCreateConsumerScopeEnabledInternal)
+ || !tracer.Settings.KafkaCreateConsumerScopeEnabled)
{
// integration disabled, skip this trace
return;
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/DatadogLoggingScope.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/DatadogLoggingScope.cs
index 21effb6ef4f2..cb7005aa4280 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/DatadogLoggingScope.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/DatadogLoggingScope.cs
@@ -27,8 +27,8 @@ internal DatadogLoggingScope(Tracer tracer)
{
_tracer = tracer;
_service = tracer.DefaultServiceName ?? string.Empty;
- _env = tracer.Settings.EnvironmentInternal ?? string.Empty;
- _version = tracer.Settings.ServiceVersionInternal ?? string.Empty;
+ _env = tracer.Settings.Environment ?? string.Empty;
+ _version = tracer.Settings.ServiceVersion ?? string.Empty;
_cachedFormat = string.Format(
CultureInfo.InvariantCulture,
"dd_service:\"{0}\", dd_env:\"{1}\", dd_version:\"{2}\"",
diff --git a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/LoggerIntegrationCommon.cs b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/LoggerIntegrationCommon.cs
index 80fb3921753a..33a78d311608 100644
--- a/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/LoggerIntegrationCommon.cs
+++ b/tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Logging/ILogger/LogsInjection/LoggerIntegrationCommon.cs
@@ -17,7 +17,7 @@ internal static class LoggerIntegrationCommon
public static void AddScope(Tracer tracer, TAction callback, TState state)
{
- if (tracer.Settings.LogsInjectionEnabledInternal
+ if (tracer.Settings.LogsInjectionEnabled
&& tracer.Settings.IsIntegrationEnabled(IntegrationId)
&& callback is Action