Skip to content

Expose Context.empty() as building block for creating custom root contexts #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 1 commit into from
Mar 17, 2025
Merged

Expose Context.empty() as building block for creating custom root contexts #8575

mcculls merged 1 commit into from
Mar 17, 2025

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 17, 2025 •
edited by atlassian bot
Loading

Motivation

This supports custom ContextManagers that want to define their own root context without needing to expose all the different context implementations. They can start with Context.empty() and add any elements they want, storing the final context as a constant so it can be supplied as Context.root()

Contributor Checklist

Jira ticket: APMAPI-981

@mcculls
Expose Context.empty() as building block for creating custom root con…
46b5f4a 
…texts

This supports custom ContextManagers that want to define their own root context without needing to expose all the different context implementations. They can start with Context.empty() and add any elements they want, storing the final context as a constant so it can be supplied as Context.root()
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 17, 2025
@mcculls mcculls marked this pull request as ready for review March 17, 2025 16:54
@mcculls mcculls requested a review from a team as a code owner March 17, 2025 16:54
@pr-commenter
Copy link

pr-commenter bot commented Mar 17, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/expose-empty-context
git_commit_date 1742221809 1742228809
git_commit_sha 5fb00dc 46b5f4a
release_version 1.48.0-SNAPSHOT~5fb00dc125 1.48.0-SNAPSHOT~46b5f4a24d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742231245 1742231245
ci_job_id 851115030 851115030
ci_pipeline_id 59058194 59058194
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tatjeic-project-304-concurrent-0-d0hdigga 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tatjeic-project-304-concurrent-0-d0hdigga 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051189
Total [baseline] (8.678 s) : 0, 8677653
Agent [candidate] (1.052 s) : 0, 1052387
Total [candidate] (8.712 s) : 0, 8711554
section iast
Agent [baseline] (1.186 s) : 0, 1185694
Total [baseline] (9.236 s) : 0, 9236482
Agent [candidate] (1.172 s) : 0, 1171560
Total [candidate] (9.284 s) : 0, 9283608
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169048
Total [baseline] (9.163 s) : 0, 9163148
Agent [candidate] (1.178 s) : 0, 1178403
Total [candidate] (9.194 s) : 0, 9193885
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180181
Total [baseline] (9.216 s) : 0, 9216076
Agent [candidate] (1.169 s) : 0, 1169138
Total [candidate] (9.233 s) : 0, 9233013
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.186 s 134.505 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 117.859 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.18 s 128.992 ms (12.3%)
Total tracing 8.678 s -
Total iast 9.236 s 558.828 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.163 s 485.495 ms (5.6%)
Total iast_TELEMETRY_OFF 9.216 s 538.423 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.172 s 119.173 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 126.017 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.169 s 116.752 ms (11.1%)
Total tracing 8.712 s -
Total iast 9.284 s 572.054 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.194 s 482.331 ms (5.5%)
Total iast_TELEMETRY_OFF 9.233 s 521.459 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.385 ms) : 0, 726385
BytebuddyAgent [candidate] (725.284 ms) : 0, 725284
GlobalTracer [baseline] (239.824 ms) : 0, 239824
GlobalTracer [candidate] (241.548 ms) : 0, 241548
AppSec [baseline] (54.719 ms) : 0, 54719
AppSec [candidate] (55.168 ms) : 0, 55168
Remote Config [baseline] (682.257 µs) : 0, 682
Remote Config [candidate] (695.823 µs) : 0, 696
Telemetry [baseline] (14.266 ms) : 0, 14266
Telemetry [candidate] (14.394 ms) : 0, 14394
section iast
BytebuddyAgent [baseline] (850.009 ms) : 0, 850009
BytebuddyAgent [candidate] (838.548 ms) : 0, 838548
GlobalTracer [baseline] (231.101 ms) : 0, 231101
GlobalTracer [candidate] (229.544 ms) : 0, 229544
IAST [baseline] (23.163 ms) : 0, 23163
IAST [candidate] (22.695 ms) : 0, 22695
AppSec [baseline] (56.655 ms) : 0, 56655
AppSec [candidate] (56.27 ms) : 0, 56270
Remote Config [baseline] (603.235 µs) : 0, 603
Remote Config [candidate] (607.505 µs) : 0, 608
Telemetry [baseline] (8.827 ms) : 0, 8827
Telemetry [candidate] (8.71 ms) : 0, 8710
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.209 ms) : 0, 836209
BytebuddyAgent [candidate] (844.071 ms) : 0, 844071
GlobalTracer [baseline] (230.02 ms) : 0, 230020
GlobalTracer [candidate] (230.341 ms) : 0, 230341
IAST [baseline] (22.572 ms) : 0, 22572
IAST [candidate] (23.799 ms) : 0, 23799
AppSec [baseline] (55.909 ms) : 0, 55909
AppSec [candidate] (55.467 ms) : 0, 55467
Remote Config [baseline] (594.394 µs) : 0, 594
Remote Config [candidate] (621.126 µs) : 0, 621
Telemetry [baseline] (8.556 ms) : 0, 8556
Telemetry [candidate] (8.757 ms) : 0, 8757
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (844.475 ms) : 0, 844475
BytebuddyAgent [candidate] (834.749 ms) : 0, 834749
GlobalTracer [baseline] (231.85 ms) : 0, 231850
GlobalTracer [candidate] (231.367 ms) : 0, 231367
IAST [baseline] (22.737 ms) : 0, 22737
IAST [candidate] (22.5 ms) : 0, 22500
AppSec [baseline] (56.448 ms) : 0, 56448
AppSec [candidate] (56.028 ms) : 0, 56028
Remote Config [baseline] (605.332 µs) : 0, 605
Remote Config [candidate] (611.264 µs) : 0, 611
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.648 ms) : 0, 8648
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044316
Total [baseline] (10.426 s) : 0, 10425509
Agent [candidate] (1.047 s) : 0, 1047050
Total [candidate] (10.503 s) : 0, 10503379
section appsec
Agent [baseline] (1.19 s) : 0, 1189848
Total [baseline] (10.751 s) : 0, 10751320
Agent [candidate] (1.188 s) : 0, 1188442
Total [candidate] (10.764 s) : 0, 10763712
section iast
Agent [baseline] (1.18 s) : 0, 1180047
Total [baseline] (11.037 s) : 0, 11036696
Agent [candidate] (1.182 s) : 0, 1182399
Total [candidate] (11.002 s) : 0, 11002112
section profiling
Agent [baseline] (1.263 s) : 0, 1263075
Total [baseline] (10.856 s) : 0, 10856393
Agent [candidate] (1.258 s) : 0, 1258483
Total [candidate] (10.854 s) : 0, 10853787
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.19 s 145.533 ms (13.9%)
Agent iast 1.18 s 135.732 ms (13.0%)
Agent profiling 1.263 s 218.759 ms (20.9%)
Total tracing 10.426 s -
Total appsec 10.751 s 325.812 ms (3.1%)
Total iast 11.037 s 611.187 ms (5.9%)
Total profiling 10.856 s 430.885 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.188 s 141.392 ms (13.5%)
Agent iast 1.182 s 135.349 ms (12.9%)
Agent profiling 1.258 s 211.433 ms (20.2%)
Total tracing 10.503 s -
Total appsec 10.764 s 260.332 ms (2.5%)
Total iast 11.002 s 498.732 ms (4.7%)
Total profiling 10.854 s 350.407 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.857 ms) : 0, 721857
BytebuddyAgent [candidate] (723.242 ms) : 0, 723242
GlobalTracer [baseline] (239.194 ms) : 0, 239194
GlobalTracer [candidate] (240.782 ms) : 0, 240782
AppSec [baseline] (54.541 ms) : 0, 54541
AppSec [candidate] (54.825 ms) : 0, 54825
Remote Config [baseline] (683.007 µs) : 0, 683
Remote Config [candidate] (691.541 µs) : 0, 692
Telemetry [baseline] (12.808 ms) : 0, 12808
Telemetry [candidate] (12.269 ms) : 0, 12269
section appsec
BytebuddyAgent [baseline] (741.673 ms) : 0, 741673
BytebuddyAgent [candidate] (739.871 ms) : 0, 739871
GlobalTracer [baseline] (236.93 ms) : 0, 236930
GlobalTracer [candidate] (237.462 ms) : 0, 237462
AppSec [baseline] (176.102 ms) : 0, 176102
AppSec [candidate] (175.62 ms) : 0, 175620
Remote Config [baseline] (666.503 µs) : 0, 667
Remote Config [candidate] (663.839 µs) : 0, 664
Telemetry [baseline] (8.324 ms) : 0, 8324
Telemetry [candidate] (8.734 ms) : 0, 8734
IAST [baseline] (21.608 ms) : 0, 21608
IAST [candidate] (21.653 ms) : 0, 21653
section iast
BytebuddyAgent [baseline] (844.983 ms) : 0, 844983
BytebuddyAgent [candidate] (846.659 ms) : 0, 846659
GlobalTracer [baseline] (230.987 ms) : 0, 230987
GlobalTracer [candidate] (231.385 ms) : 0, 231385
AppSec [baseline] (56.371 ms) : 0, 56371
AppSec [candidate] (56.539 ms) : 0, 56539
Remote Config [baseline] (604.307 µs) : 0, 604
Remote Config [candidate] (610.637 µs) : 0, 611
Telemetry [baseline] (8.779 ms) : 0, 8779
Telemetry [candidate] (8.77 ms) : 0, 8770
IAST [baseline] (23.06 ms) : 0, 23060
IAST [candidate] (23.05 ms) : 0, 23050
section profiling
ProfilingAgent [baseline] (96.69 ms) : 0, 96690
ProfilingAgent [candidate] (96.086 ms) : 0, 96086
BytebuddyAgent [baseline] (711.159 ms) : 0, 711159
BytebuddyAgent [candidate] (709.021 ms) : 0, 709021
GlobalTracer [baseline] (350.319 ms) : 0, 350319
GlobalTracer [candidate] (349.674 ms) : 0, 349674
AppSec [baseline] (54.25 ms) : 0, 54250
AppSec [candidate] (53.302 ms) : 0, 53302
Remote Config [baseline] (681.457 µs) : 0, 681
Remote Config [candidate] (665.796 µs) : 0, 666
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (9.013 ms) : 0, 9013
Profiling [baseline] (96.715 ms) : 0, 96715
Profiling [candidate] (96.11 ms) : 0, 96110
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-17T16:37:42 2025-03-17T16:45:29
git_branch master mcculls/expose-empty-context
git_commit_date 1742221809 1742228809
git_commit_sha 5fb00dc 46b5f4a
release_version 1.48.0-SNAPSHOT~5fb00dc125 1.48.0-SNAPSHOT~46b5f4a24d
start_time 2025-03-17T16:37:28 2025-03-17T16:45:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1742230330 1742230330
ci_job_id 851115032 851115032
ci_pipeline_id 59058194 59058194
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tatjeic-project-304-concurrent-1-g72twtnd 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tatjeic-project-304-concurrent-1-g72twtnd 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.112 µs) : 364, 404
.   : milestone, 384,
iast (518.608 µs) : 496, 541
.   : milestone, 519,
iast_FULL (739.959 µs) : 718, 762
.   : milestone, 740,
iast_GLOBAL (565.601 µs) : 543, 588
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (520.242 µs) : 499, 542
.   : milestone, 520,
iast_INACTIVE (466.731 µs) : 446, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (515.657 µs) : 494, 537
.   : milestone, 516,
tracing (464.218 µs) : 444, 485
.   : milestone, 464,
section candidate
no_agent (384.509 µs) : 364, 405
.   : milestone, 385,
iast (515.652 µs) : 494, 538
.   : milestone, 516,
iast_FULL (734.017 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (562.557 µs) : 540, 585
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (524.04 µs) : 502, 546
.   : milestone, 524,
iast_INACTIVE (466.722 µs) : 446, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (507.92 µs) : 486, 530
.   : milestone, 508,
tracing (464.768 µs) : 443, 486
.   : milestone, 465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.112 µs [364.487 µs, 403.737 µs] -
iast 518.608 µs [496.375 µs, 540.841 µs] 134.495 µs (35.0%)
iast_FULL 739.959 µs [718.082 µs, 761.837 µs] 355.847 µs (92.6%)
iast_GLOBAL 565.601 µs [543.42 µs, 587.781 µs] 181.488 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED 520.242 µs [498.662 µs, 541.823 µs] 136.13 µs (35.4%)
iast_INACTIVE 466.731 µs [445.504 µs, 487.958 µs] 82.619 µs (21.5%)
iast_TELEMETRY_OFF 515.657 µs [494.038 µs, 537.276 µs] 131.545 µs (34.2%)
tracing 464.218 µs [443.509 µs, 484.927 µs] 80.105 µs (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.509 µs [364.234 µs, 404.783 µs] -
iast 515.652 µs [493.662 µs, 537.641 µs] 131.143 µs (34.1%)
iast_FULL 734.017 µs [711.886 µs, 756.147 µs] 349.508 µs (90.9%)
iast_GLOBAL 562.557 µs [540.356 µs, 584.758 µs] 178.048 µs (46.3%)
iast_HARDCODED_SECRET_DISABLED 524.04 µs [501.784 µs, 546.295 µs] 139.531 µs (36.3%)
iast_INACTIVE 466.722 µs [445.513 µs, 487.932 µs] 82.214 µs (21.4%)
iast_TELEMETRY_OFF 507.92 µs [485.672 µs, 530.169 µs] 123.412 µs (32.1%)
tracing 464.768 µs [443.34 µs, 486.195 µs] 80.259 µs (20.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1390
.   : milestone, 1370,
appsec (1.728 ms) : 1704, 1752
.   : milestone, 1728,
appsec_no_iast (1.754 ms) : 1730, 1779
.   : milestone, 1754,
code_origins (1.71 ms) : 1683, 1736
.   : milestone, 1710,
iast (1.512 ms) : 1489, 1536
.   : milestone, 1512,
profiling (1.545 ms) : 1520, 1570
.   : milestone, 1545,
tracing (1.488 ms) : 1463, 1513
.   : milestone, 1488,
section candidate
no_agent (1.356 ms) : 1337, 1376
.   : milestone, 1356,
appsec (1.741 ms) : 1717, 1765
.   : milestone, 1741,
appsec_no_iast (1.759 ms) : 1735, 1782
.   : milestone, 1759,
code_origins (1.7 ms) : 1673, 1726
.   : milestone, 1700,
iast (1.52 ms) : 1496, 1545
.   : milestone, 1520,
profiling (1.579 ms) : 1554, 1604
.   : milestone, 1579,
tracing (1.491 ms) : 1466, 1517
.   : milestone, 1491,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.39 ms] -
appsec 1.728 ms [1.704 ms, 1.752 ms] 357.377 µs (26.1%)
appsec_no_iast 1.754 ms [1.73 ms, 1.779 ms] 383.963 µs (28.0%)
code_origins 1.71 ms [1.683 ms, 1.736 ms] 339.43 µs (24.8%)
iast 1.512 ms [1.489 ms, 1.536 ms] 142.14 µs (10.4%)
profiling 1.545 ms [1.52 ms, 1.57 ms] 174.674 µs (12.7%)
tracing 1.488 ms [1.463 ms, 1.513 ms] 117.865 µs (8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.376 ms] -
appsec 1.741 ms [1.717 ms, 1.765 ms] 384.464 µs (28.3%)
appsec_no_iast 1.759 ms [1.735 ms, 1.782 ms] 402.327 µs (29.7%)
code_origins 1.7 ms [1.673 ms, 1.726 ms] 343.453 µs (25.3%)
iast 1.52 ms [1.496 ms, 1.545 ms] 164.139 µs (12.1%)
profiling 1.579 ms [1.554 ms, 1.604 ms] 222.376 µs (16.4%)
tracing 1.491 ms [1.466 ms, 1.517 ms] 134.903 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/expose-empty-context
git_commit_date 1742221809 1742228809
git_commit_sha 5fb00dc 46b5f4a
release_version 1.48.0-SNAPSHOT~5fb00dc125 1.48.0-SNAPSHOT~46b5f4a24d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1742230996 1742230996
ci_job_id 851115034 851115034
ci_pipeline_id 59058194 59058194
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-9dwxuse-project-304-concurrent-2-it5va0dh 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-9dwxuse-project-304-concurrent-2-it5va0dh 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
appsec (14.845 s) : 14845000, 14845000
.   : milestone, 14845000,
iast (18.724 s) : 18724000, 18724000
.   : milestone, 18724000,
iast_GLOBAL (18.183 s) : 18183000, 18183000
.   : milestone, 18183000,
profiling (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
tracing (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,
section candidate
no_agent (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,
appsec (15.135 s) : 15135000, 15135000
.   : milestone, 15135000,
iast (18.185 s) : 18185000, 18185000
.   : milestone, 18185000,
iast_GLOBAL (17.983 s) : 17983000, 17983000
.   : milestone, 17983000,
profiling (14.949 s) : 14949000, 14949000
.   : milestone, 14949000,
tracing (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.957 s [14.957 s, 14.957 s] -
appsec 14.845 s [14.845 s, 14.845 s] -112.0 ms (-0.7%)
iast 18.724 s [18.724 s, 18.724 s] 3.767 s (25.2%)
iast_GLOBAL 18.183 s [18.183 s, 18.183 s] 3.226 s (21.6%)
profiling 15.117 s [15.117 s, 15.117 s] 160.0 ms (1.1%)
tracing 14.871 s [14.871 s, 14.871 s] -86.0 ms (-0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.977 s [14.977 s, 14.977 s] -
appsec 15.135 s [15.135 s, 15.135 s] 158.0 ms (1.1%)
iast 18.185 s [18.185 s, 18.185 s] 3.208 s (21.4%)
iast_GLOBAL 17.983 s [17.983 s, 17.983 s] 3.006 s (20.1%)
profiling 14.949 s [14.949 s, 14.949 s] -28.0 ms (-0.2%)
tracing 15.079 s [15.079 s, 15.079 s] 102.0 ms (0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~46b5f4a24d, baseline=1.48.0-SNAPSHOT~5fb00dc125
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
.   : milestone, 1483,
appsec (2.364 ms) : 2320, 2408
.   : milestone, 2364,
iast (2.128 ms) : 2071, 2184
.   : milestone, 2128,
iast_GLOBAL (2.186 ms) : 2130, 2242
.   : milestone, 2186,
profiling (2.454 ms) : 2279, 2630
.   : milestone, 2454,
tracing (1.959 ms) : 1917, 2001
.   : milestone, 1959,
section candidate
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.362 ms) : 2318, 2406
.   : milestone, 2362,
iast (2.133 ms) : 2077, 2189
.   : milestone, 2133,
iast_GLOBAL (2.174 ms) : 2118, 2230
.   : milestone, 2174,
profiling (2.011 ms) : 1965, 2057
.   : milestone, 2011,
tracing (1.962 ms) : 1919, 2005
.   : milestone, 1962,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.472 ms, 1.495 ms] -
appsec 2.364 ms [2.32 ms, 2.408 ms] 880.856 µs (59.4%)
iast 2.128 ms [2.071 ms, 2.184 ms] 644.332 µs (43.4%)
iast_GLOBAL 2.186 ms [2.13 ms, 2.242 ms] 702.663 µs (47.4%)
profiling 2.454 ms [2.279 ms, 2.63 ms] 971.128 µs (65.5%)
tracing 1.959 ms [1.917 ms, 2.001 ms] 475.84 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 2.362 ms [2.318 ms, 2.406 ms] 880.599 µs (59.4%)
iast 2.133 ms [2.077 ms, 2.189 ms] 651.355 µs (44.0%)
iast_GLOBAL 2.174 ms [2.118 ms, 2.23 ms] 692.148 µs (46.7%)
profiling 2.011 ms [1.965 ms, 2.057 ms] 529.502 µs (35.7%)
tracing 1.962 ms [1.919 ms, 2.005 ms] 479.84 µs (32.4%)

@mcculls mcculls requested a review from PerfectSlayer March 17, 2025 17:26
@mcculls mcculls merged commit 57fddd9 into master Mar 17, 2025
274 of 275 checks passed
@mcculls mcculls deleted the mcculls/expose-empty-context branch March 17, 2025 17:37
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 17, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@mcculls @mtoffl01
Expose Context.empty() as building block for creating custom root con…
888cbd4 
…texts (#8575)

This supports custom ContextManagers that want to define their own root context without needing to expose all the different context implementations. They can start with Context.empty() and add any elements they want, storing the final context as a constant so it can be supplied as Context.root()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez was automatically assigned from DataDog/apm-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @amarziali