Merge branch '4.0-breaking-changes' into taegyunkim/remove-stack-v1

Author: taegyunkim

ddtrace/_trace/span.py

@@ -269,19 +269,6 @@ def start(self, value: Union[int, float]) -> None:
     def finished(self) -> bool:
         return self.duration_ns is not None
 
-    @finished.setter
-    def finished(self, value: bool) -> None:
-        """Finishes the span if set to a truthy value.
-
-        If the span is already finished and a truthy value is provided
-        no action will occur.
-        """
-        if value:
-            if not self.finished:
-                self.duration_ns = Time.time_ns() - self.start_ns
-        else:
-            self.duration_ns = None
-
     @property
     def duration(self) -> Optional[float]:
         """The span duration in seconds."""
@@ -604,8 +591,6 @@ def record_exception(
         :param attributes: Optional dictionary of additional attributes to add to the exception event.
             These attributes will override the default exception attributes if they contain the same keys.
             Valid attribute values include (homogeneous array of) strings, booleans, integers, floats.
-        :param timestamp: Deprecated.
-        :param escaped: Deprecated.
         """
         tb = self._get_traceback(type(exception), exception, exception.__traceback__)
 
@@ -767,7 +752,7 @@ def _set_link_or_append_pointer(self, link: Union[SpanLink, _SpanPointer]) -> No
         except ValueError:
             self._links.append(link)
 
-    def finish_with_ancestors(self) -> None:
+    def _finish_with_ancestors(self) -> None:
         """Finish this span along with all (accessible) ancestors of this span.
 
         This method is useful if a sudden program shutdown is required and finishing

ddtrace/appsec/_iast/__init__.py

@@ -46,6 +46,7 @@ def wrapped_function(wrapped, instance, args, kwargs):
 _IAST_TO_BE_LOADED = True
 _iast_propagation_enabled = False
 _fork_handler_registered = False
+_iast_in_pytest_mode = False
 
 
 def _disable_iast_after_fork():
@@ -87,6 +88,15 @@ def _disable_iast_after_fork():
         from ddtrace.appsec._iast._iast_request_context_base import is_iast_request_enabled
         from ddtrace.appsec._iast._taint_tracking._context import clear_all_request_context_slots
 
+        # In pytest mode, always disable IAST in child processes to avoid segfaults
+        # when tests create multiprocesses (e.g., for testing fork behavior)
+        if _iast_in_pytest_mode:
+            log.debug("IAST fork handler: Pytest mode detected, disabling IAST in child process")
+            clear_all_request_context_slots()
+            IAST_CONTEXT.set(None)
+            asm_config._iast_enabled = False
+            return
+
         if not is_iast_request_enabled():
             # No active context - this is an early fork (web framework worker)
             # IAST can be safely initialized fresh in this child process
@@ -168,6 +178,7 @@ def enable_iast_propagation():
     """Add IAST AST patching in the ModuleWatchdog"""
     # DEV: These imports are here to avoid _ast.ast_patching import in the top level
     # because they are slow and affect serverless startup time
+
     if asm_config._iast_propagation_enabled:
         from ddtrace.appsec._iast._ast.ast_patching import _should_iast_patch
         from ddtrace.appsec._iast._loader import _exec_iast_patched_module
@@ -183,19 +194,30 @@ def enable_iast_propagation():
 
 
 def _iast_pytest_activation():
-    global _iast_propagation_enabled
-    if _iast_propagation_enabled:
+    """Configure IAST settings for pytest execution.
+
+    This function sets up IAST configuration but does NOT create a request context.
+    Request contexts should be created per-test or per-request to avoid threading issues.
+
+    Also sets a global flag to indicate we're in pytest mode, which ensures IAST is
+    disabled in forked child processes to prevent segfaults when tests use multiprocessing.
+    """
+    global _iast_in_pytest_mode
+
+    if not asm_config._iast_enabled:
         return
-    os.environ["DD_IAST_ENABLED"] = os.environ.get("DD_IAST_ENABLED") or "1"
+
+    # Mark that we're running in pytest mode
+    # This flag is checked by the fork handler to disable IAST in child processes
+    _iast_in_pytest_mode = True
+
     os.environ["DD_IAST_REQUEST_SAMPLING"] = os.environ.get("DD_IAST_REQUEST_SAMPLING") or "100.0"
     os.environ["_DD_APPSEC_DEDUPLICATION_ENABLED"] = os.environ.get("_DD_APPSEC_DEDUPLICATION_ENABLED") or "false"
     os.environ["DD_IAST_VULNERABILITIES_PER_REQUEST"] = os.environ.get("DD_IAST_VULNERABILITIES_PER_REQUEST") or "1000"
-    os.environ["DD_IAST_MAX_CONCURRENT_REQUESTS"] = os.environ.get("DD_IAST_MAX_CONCURRENT_REQUESTS") or "1000"
 
     asm_config._iast_request_sampling = 100.0
     asm_config._deduplication_enabled = False
     asm_config._iast_max_vulnerabilities_per_requests = 1000
-    asm_config._iast_max_concurrent_requests = 1000
     oce.reconfigure()
 
 

ddtrace/contrib/internal/aws_lambda/patch.py

@@ -103,7 +103,7 @@ def _crash_flush(self, _, __):
 
         current_span = tracer.current_span()
         if current_span is not None:
-            current_span.finish_with_ancestors()
+            current_span._finish_with_ancestors()
 
     def _remove_alarm_signal(self):
         """Removes the handler set for the signal `SIGALRM`."""

ddtrace/internal/packages.py

@@ -142,11 +142,11 @@ def _root_module(path: Path) -> str:
             pass
 
     # Bazel runfiles support: we assume that these paths look like
-    # /some/path.runfiles/.../site-packages/<root_module>/...
-    if any(p.suffix == ".runfiles" for p in path.parents):
-        for s in path.parents:
-            if s.parent.name == "site-packages":
-                return s.name
+    # /some/path.runfiles/<distribution_name>/site-packages/<root_module>/...
+    # /usr/local/runfiles/<distribution_name>/site-packages/<root_module>/...
+    for s in path.parents:
+        if s.parent.name == "site-packages":
+            return s.name
 
     msg = f"Could not find root module for path {path}"
     raise ValueError(msg)

ddtrace/internal/settings/__init__.py

@@ -1,35 +0,0 @@
-from ddtrace.internal.utils.deprecations import DDTraceDeprecationWarning
-from ddtrace.vendor.debtcollector import deprecate
-
-
-def __getattr__(name):
-    if name in set(
-        [
-            "ConfigException",
-            "HttpConfig",
-            "Hooks",
-            "IntegrationConfig",
-        ]
-    ):
-        deprecate(
-            ("%s.%s is deprecated" % (__name__, name)),
-            removal_version="4.0.0",  # TODO: update this to the correct version
-            category=DDTraceDeprecationWarning,
-        )
-        if name == "ConfigException":
-            from ddtrace.internal.settings.exceptions import ConfigException
-
-            return ConfigException
-        elif name == "HttpConfig":
-            from .http import HttpConfig
-
-            return HttpConfig
-        elif name == "Hooks":
-            from .._hooks import Hooks
-
-            return Hooks
-        elif name == "IntegrationConfig":
-            from .integration import IntegrationConfig
-
-            return IntegrationConfig
-    raise AttributeError("'%s' has no attribute '%s'" % (__name__, name))

ddtrace/internal/settings/asm.py

@@ -142,6 +142,8 @@ class ASMConfig(DDConfig):
         + r"ey[I-L][\w=-]+\.ey[I-L][\w=-]+(\.[\w.+\/=-]+)?|[\-]{5}BEGIN[a-z\s]+PRIVATE\sKEY"
         + r"[\-]{5}[^\-]+[\-]{5}END[a-z\s]+PRIVATE\sKEY|ssh-rsa\s*[a-z0-9\/\.+]{100,}",
     )
+    # We never use `asm_config._iast_max_concurrent_requests` directly,
+    # but we define it so it can be reported through telemetry, since it’s used from the C files.
     _iast_max_concurrent_requests = DDConfig.var(
         int,
         IAST.DD_IAST_MAX_CONCURRENT_REQUESTS,

lib-injection/sources/requirements.csv

@@ -1,9 +1,9 @@
 Dependency,Version Specifier,Python Version
-bytecode,>=0.17.0,python_version>='3.14.0'
-bytecode,>=0.16.0,python_version>='3.13.0'
-bytecode,>=0.15.1,python_version~='3.12.0'
-bytecode,>=0.14.0,python_version~='3.11.0'
-bytecode,>=0.13.0,python_version<'3.11'
+bytecode,">=0.17.0,<1",python_version>='3.14.0'
+bytecode,">=0.16.0,<1",python_version>='3.13.0'
+bytecode,">=0.15.1,<1",python_version~='3.12.0'
+bytecode,">=0.14.0,<1",python_version~='3.11.0'
+bytecode,">=0.13.0,<1",python_version<'3.11'
 envier,~=0.6.1,
 opentelemetry-api,">=1,<2",
 wrapt,">=1,<3",

pyproject.toml

@@ -35,11 +35,11 @@ classifiers = [
     "Programming Language :: Python :: 3.14",
 ]
 dependencies = [
-    "bytecode>=0.17.0; python_version>='3.14.0'",
-    "bytecode>=0.16.0; python_version>='3.13.0'",
-    "bytecode>=0.15.1; python_version~='3.12.0'",
-    "bytecode>=0.14.0; python_version~='3.11.0'",
-    "bytecode>=0.13.0; python_version<'3.11'",
+    "bytecode>=0.17.0,<1; python_version>='3.14.0'",
+    "bytecode>=0.16.0,<1; python_version>='3.13.0'",
+    "bytecode>=0.15.1,<1; python_version~='3.12.0'",
+    "bytecode>=0.14.0,<1; python_version~='3.11.0'",
+    "bytecode>=0.13.0,<1; python_version<'3.11'",
     "envier~=0.6.1",
     "opentelemetry-api>=1,<2",
     "wrapt>=1,<3",

releasenotes/notes/deprecate-span-finished-finish-with-ancestors-c75633a9baaa9463.yaml

@@ -0,0 +1,6 @@
+---
+deprecations:
+  - |
+    tracing: ``Span.finished`` setter is deprecated, use ``Span.finish()`` method instead.
+  - |
+    tracing: ``Span.finish_with_ancestors()`` is deprecated with no alternative.

releasenotes/notes/remove-span-finished-finish-with-ancestors-fb2d11b874206f59.yaml

@@ -0,0 +1,6 @@
+---
+upgrade:
+  - |
+    tracing: ``Span.finished`` setter was removed, please use ``Span.finish()`` method instead.
+  - |
+    tracing: ``Span.finish_with_ancestors`` was removed with no replacement.