Skip to content

Commit 4c58c59

Browse files
ci: disable appsec_iast_propagation benchmarks (#15279)
## Description They are failing with: > AttributeError: 'OverheadControl' object has no attribute 'release_request' Which means we aren't getting benchmark results, and now the SLO check will fail if the results for a given benchmark are missing. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com> (cherry picked from commit 52d499b)
1 parent fa40724 commit 4c58c59

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -724,22 +724,22 @@ experiments:
724724
- max_rss_usage < 39.00 MB
725725

726726
# iastpropagation
727-
- name: iastpropagation-no-propagation
728-
thresholds:
729-
- execution_time < 0.06 ms
730-
- max_rss_usage < 39.00 MB
731-
- name: iastpropagation-propagation_enabled
732-
thresholds:
733-
- execution_time < 0.19 ms
734-
- max_rss_usage < 39.00 MB
735-
- name: iastpropagation-propagation_enabled_100
736-
thresholds:
737-
- execution_time < 2.30 ms
738-
- max_rss_usage < 39.00 MB
739-
- name: iastpropagation-propagation_enabled_1000
740-
thresholds:
741-
- execution_time < 34.55 ms
742-
- max_rss_usage < 39.00 MB
727+
# - name: iastpropagation-no-propagation
728+
# thresholds:
729+
# - execution_time < 0.06 ms
730+
# - max_rss_usage < 39.00 MB
731+
# - name: iastpropagation-propagation_enabled
732+
# thresholds:
733+
# - execution_time < 0.19 ms
734+
# - max_rss_usage < 39.00 MB
735+
# - name: iastpropagation-propagation_enabled_100
736+
# thresholds:
737+
# - execution_time < 2.30 ms
738+
# - max_rss_usage < 39.00 MB
739+
# - name: iastpropagation-propagation_enabled_1000
740+
# thresholds:
741+
# - execution_time < 34.55 ms
742+
# - max_rss_usage < 39.00 MB
743743

744744
# otelsdkspan
745745
- name: otelsdkspan-add-event

.gitlab/benchmarks/microbenchmarks.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,9 @@ microbenchmarks:
159159
- "appsec_iast_aspects_split"
160160
# Flaky timeouts on starting up
161161
# - "appsec_iast_django_startup"
162-
- "appsec_iast_propagation"
162+
# TOOD: Re-enable when this issue is resolved:
163+
# AttributeError: 'OverheadControl' object has no attribute 'release_request'
164+
# - "appsec_iast_propagation"
163165
- "errortracking_django_simple"
164166
# They take a long time to run and frequently time out
165167
# TODO: Make benchmarks faster, or run less frequently, or as macrobenchmarks

0 commit comments

Comments
 (0)