From 665fed409f8cc49e0d2d2a64fa8cf96da4637e8e Mon Sep 17 00:00:00 2001 From: Brett Langdon Date: Tue, 1 Feb 2022 15:48:55 -0500 Subject: [PATCH] fix(internal): use correct max item size variable in log warning (#3210) fixes: #3209 --- ddtrace/internal/writer.py | 4 ++-- tests/integration/test_integration.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ddtrace/internal/writer.py b/ddtrace/internal/writer.py index f3ecc92e196..9dd7a122d11 100644 --- a/ddtrace/internal/writer.py +++ b/ddtrace/internal/writer.py @@ -476,9 +476,9 @@ def write(self, spans=None): except BufferItemTooLarge as e: payload_size = e.args[0] log.warning( - "trace (%db) larger than payload buffer limit (%db), dropping", + "trace (%db) larger than payload buffer item limit (%db), dropping", payload_size, - self._buffer_size, + self._encoder.max_item_size, ) self._metrics_dist("buffer.dropped.traces", 1, tags=["reason:t_too_big"]) self._metrics_dist("buffer.dropped.bytes", payload_size, tags=["reason:t_too_big"]) diff --git a/tests/integration/test_integration.py b/tests/integration/test_integration.py index 5fcbf6330e3..4f6528a015b 100644 --- a/tests/integration/test_integration.py +++ b/tests/integration/test_integration.py @@ -257,7 +257,7 @@ def test_single_trace_too_large(encoding, monkeypatch): s.set_tag("a" * 10, "b" * 10) t.shutdown() - calls = [mock.call("trace (%db) larger than payload buffer limit (%db), dropping", AnyInt(), AnyInt())] + calls = [mock.call("trace (%db) larger than payload buffer item limit (%db), dropping", AnyInt(), AnyInt())] log.warning.assert_has_calls(calls) log.error.assert_not_called()