Skip to content

Commit b4088d7

Browse files
authored
chore: add traceback info to the failed to send message (#14299)
## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
1 parent a5aee01 commit b4088d7

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1089,7 +1089,7 @@ experiments:
10891089
- max_rss_usage < 34.00 MB
10901090
- name: telemetryaddmetric-1-rate-metrics-100-times
10911091
thresholds:
1092-
- execution_time < 0.23 ms
1092+
- execution_time < 0.24 ms
10931093
- max_rss_usage < 34.00 MB
10941094
- name: telemetryaddmetric-100-count-metrics-100-times
10951095
thresholds:

ddtrace/internal/writer/writer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,7 @@ def _flush_single_payload(
443443
n_traces,
444444
self._intake_endpoint(client),
445445
self.RETRY_ATTEMPTS,
446+
exc_info=True,
446447
)
447448
finally:
448449
self._metrics_dist("http.sent.bytes", len(encoded))

tests/integration/test_integration.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def test_uds_wrong_socket_path():
107107
1,
108108
"unix:///tmp/ddagent/nosockethere/{}/traces".format(encoding if encoding else "v0.5"),
109109
3,
110+
exc_info=True,
110111
)
111112
]
112113
log.error.assert_has_calls(calls)
@@ -379,6 +380,7 @@ def test_trace_generates_error_logs_when_trace_agent_url_invalid():
379380
1,
380381
"http://localhost:8125/{}/traces".format(encoding if encoding else "v0.5"),
381382
3,
383+
exc_info=True,
382384
)
383385
]
384386
log.error.assert_has_calls(calls)

0 commit comments

Comments
 (0)