Skip to content

Commit c45e6b8

Browse files
authored
ci(iast): fix benchmark tests, deprecated function (#15334)
fix and revert this PR #15279
1 parent 0972046 commit c45e6b8

File tree

7 files changed

+17
-23
lines changed

7 files changed

+17
-23
lines changed

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -723,22 +723,22 @@ experiments:
723723
- max_rss_usage < 41.00 MB
724724

725725
# iastpropagation
726-
# - name: iastpropagation-no-propagation
727-
# thresholds:
728-
# - execution_time < 0.06 ms
729-
# - max_rss_usage < 40.50 MB
730-
# - name: iastpropagation-propagation_enabled
731-
# thresholds:
732-
# - execution_time < 0.19 ms
733-
# - max_rss_usage < 40.00 MB
734-
# - name: iastpropagation-propagation_enabled_100
735-
# thresholds:
736-
# - execution_time < 2.30 ms
737-
# - max_rss_usage < 40.00 MB
738-
# - name: iastpropagation-propagation_enabled_1000
739-
# thresholds:
740-
# - execution_time < 34.55 ms
741-
# - max_rss_usage < 40.00 MB
726+
- name: iastpropagation-no-propagation
727+
thresholds:
728+
- execution_time < 0.06 ms
729+
- max_rss_usage < 40.50 MB
730+
- name: iastpropagation-propagation_enabled
731+
thresholds:
732+
- execution_time < 0.19 ms
733+
- max_rss_usage < 40.00 MB
734+
- name: iastpropagation-propagation_enabled_100
735+
thresholds:
736+
- execution_time < 2.30 ms
737+
- max_rss_usage < 40.00 MB
738+
- name: iastpropagation-propagation_enabled_1000
739+
thresholds:
740+
- execution_time < 34.55 ms
741+
- max_rss_usage < 40.00 MB
742742

743743
# otelsdkspan
744744
- name: otelsdkspan-add-event

.gitlab/benchmarks/microbenchmarks.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,7 @@ microbenchmarks:
163163
# Flaky timeouts on starting up
164164
# - "appsec_iast_django_startup"
165165
# TOOD: Re-enable when this issue is resolved:
166-
# AttributeError: 'OverheadControl' object has no attribute 'release_request'
167-
# - "appsec_iast_propagation"
166+
- "appsec_iast_propagation"
168167
- "errortracking_django_simple"
169168
# They take a long time to run and frequently time out
170169
# TODO: Make benchmarks faster, or run less frequently, or as macrobenchmarks

benchmarks/appsec_iast_aspects/scenario.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def _start_iast_context_and_oce():
3939

4040
def _end_iast_context_and_oce():
4141
end_iast_context()
42-
# oce.release_request()
4342

4443

4544
@contextlib.contextmanager

benchmarks/appsec_iast_aspects_ospath/scenario.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def _start_iast_context_and_oce():
3737

3838
def _end_iast_context_and_oce():
3939
end_iast_context()
40-
# oce.release_request()
4140

4241

4342
with override_env({"DD_IAST_ENABLED": "True"}):

benchmarks/appsec_iast_aspects_re_module/scenario.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def _start_iast_context_and_oce():
3737

3838
def _end_iast_context_and_oce():
3939
end_iast_context()
40-
# oce.release_request()
4140

4241

4342
with override_env({"DD_IAST_ENABLED": "True"}):

benchmarks/appsec_iast_aspects_split/scenario.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def _start_iast_context_and_oce():
3737

3838
def _end_iast_context_and_oce():
3939
end_iast_context()
40-
# oce.release_request()
4140

4241

4342
with override_env({"DD_IAST_ENABLED": "True"}):

benchmarks/appsec_iast_propagation/scenario.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ def _start_iast_context_and_oce():
4848

4949
def _end_iast_context_and_oce():
5050
end_iast_context()
51-
oce.release_request()
5251

5352

5453
def normal_function(internal_loop, tainted):

0 commit comments

Comments
 (0)