Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): iast packages tests error #11673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

avara1986
Copy link
Member

New error in CircleCI but it works locally. It looks the same error of this old PR:
#11199

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/appsec/iast_packages/test_packages.py                             @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: avara1986/fix_flaky_Test
Commit report: b2e78db
Test service: dd-trace-py

✅ 0 Failed, 233 Passed, 1235 Skipped, 2m 59.34s Total duration (33m 51.07s time saved)

@avara1986 avara1986 added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 11, 2024
@avara1986 avara1986 marked this pull request as ready for review December 11, 2024 15:27
@avara1986 avara1986 requested a review from a team as a code owner December 11, 2024 15:27
@avara1986 avara1986 enabled auto-merge (squash) December 11, 2024 15:44
@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-11 16:08:38

Comparing candidate commit 7b5ea31 in PR branch avara1986/fix_flaky_Test with baseline commit aec08be in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 392 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+290.594ns; +345.865ns] or [+8.773%; +10.441%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+336.461ns; +401.051ns] or [+8.617%; +10.271%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants