-
Notifications
You must be signed in to change notification settings - Fork 467
fix(aap): fixing asyncio error for asgi [backport 3.14] #14701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
31ca0b8 to
51ce84f
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 267 ± 2 ms. The average import time from base is: 271 ± 4 ms. The import time difference between this PR and base is: -3.6 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-14700-to-3.14 (51ce84f) with baseline 3.14 (f38225b) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 26/26✅ appsecTime: ✅ 20.473ms (SLO: <22.300ms -8.2%) vs baseline: ~same Memory: ✅ 64.330MB (SLO: <66.000MB -2.5%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.361ms (SLO: <1.450ms -6.1%) vs baseline: ~same Memory: ✅ 63.303MB (SLO: <66.000MB -4.1%) vs baseline: +4.9% ✅ iastTime: ✅ 20.469ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 64.330MB (SLO: <66.000MB -2.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.162ms (SLO: <16.550ms -8.4%) vs baseline: -0.3% Memory: ✅ 53.025MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.169ms (SLO: <28.200ms -7.2%) vs baseline: +0.2% Memory: ✅ 66.535MB (SLO: <68.500MB -2.9%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.480ms (SLO: <21.750ms -5.8%) vs baseline: -0.3% Memory: ✅ 64.330MB (SLO: <66.000MB -2.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.175ms (SLO: <23.500ms -5.6%) vs baseline: ~same Memory: ✅ 65.551MB (SLO: <67.000MB -2.2%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.323ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.4% Memory: ✅ 64.330MB (SLO: <66.000MB -2.5%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.478ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 65.726MB (SLO: <66.000MB 🟡 -0.4%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.454ms (SLO: <19.650ms -6.1%) vs baseline: +0.1% Memory: ✅ 64.350MB (SLO: <66.000MB -2.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.801ms (SLO: <20.100ms -6.5%) vs baseline: -0.2% Memory: ✅ 64.310MB (SLO: <66.000MB -2.6%) vs baseline: +5.2% ✅ tracer-no-middlewareTime: ✅ 20.214ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 64.310MB (SLO: <66.000MB -2.6%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 20.366ms (SLO: <22.000ms -7.4%) vs baseline: ~same Memory: ✅ 64.310MB (SLO: <66.000MB -2.6%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.038ms (SLO: <19.850ms -9.1%) vs baseline: ~same Memory: ✅ 64.324MB (SLO: <65.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.076ms (SLO: <19.400ms -6.8%) vs baseline: ~same Memory: ✅ 64.242MB (SLO: <65.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 18.304ms (SLO: <19.450ms -5.9%) vs baseline: +1.3% Memory: ✅ 64.293MB (SLO: <65.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 17/17✅ appsec-getTime: ✅ 4.576ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 60.673MB (SLO: <64.500MB -5.9%) vs baseline: +2.3% ✅ appsec-postTime: ✅ 6.588ms (SLO: <6.750ms -2.4%) vs baseline: ~same Memory: ✅ 60.929MB (SLO: <64.500MB -5.5%) vs baseline: +2.6% ✅ appsec-telemetryTime: ✅ 4.572ms (SLO: <4.750ms -3.8%) vs baseline: -0.4% Memory: ✅ 60.693MB (SLO: <64.500MB -5.9%) vs baseline: +2.5% ✅ debuggerTime: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: -0.3% Memory: ✅ 44.728MB (SLO: <45.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.3% Memory: ✅ 41.740MB (SLO: <49.000MB 📉 -14.8%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: -0.2% Memory: ✅ 44.414MB (SLO: <46.500MB -4.5%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: -0.5% Memory: ✅ 51.315MB (SLO: <53.500MB -4.1%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 52.770MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.1% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.942ms (SLO: <4.200ms -6.1%) vs baseline: -0.3% Memory: ✅ 60.943MB (SLO: <66.000MB -7.7%) vs baseline: +2.4% ✅ iast-enabledTime: ✅ 2.516ms (SLO: <2.800ms 📉 -10.1%) vs baseline: -0.4% Memory: ✅ 58.054MB (SLO: <59.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.079ms (SLO: <2.250ms -7.6%) vs baseline: -0.1% Memory: ✅ 51.051MB (SLO: <53.500MB -4.6%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.338ms (SLO: <47.150ms -3.8%) vs baseline: ~same Memory: ✅ 44.614MB (SLO: <46.500MB -4.1%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 324.873ms (SLO: <344.800ms -5.8%) vs baseline: +1.4% Memory: ✅ 552.743MB (SLO: <562.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 294.760ms (SLO: <314.000ms -6.1%) vs baseline: +1.0% Memory: ✅ 556.270MB (SLO: <563.500MB 🟡 -1.3%) vs baseline: +5.3% ✅ get-contextTime: ✅ 82.552ms (SLO: <92.350ms 📉 -10.6%) vs baseline: +0.4% Memory: ✅ 39.702MB (SLO: <46.500MB 📉 -14.6%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 44.002ms (SLO: <44.500ms 🟡 -1.1%) vs baseline: +2.7% Memory: ✅ 44.114MB (SLO: <46.500MB -5.1%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 61.731ms (SLO: <67.650ms -8.7%) vs baseline: -0.7% Memory: ✅ 40.116MB (SLO: <46.500MB 📉 -13.7%) vs baseline: +5.1% ✅ set-statusTime: ✅ 49.243ms (SLO: <50.400ms -2.3%) vs baseline: +1.0% Memory: ✅ 44.073MB (SLO: <46.500MB -5.2%) vs baseline: +4.9% ✅ startTime: ✅ 42.210ms (SLO: <43.450ms -2.9%) vs baseline: -0.4% Memory: ✅ 44.045MB (SLO: <46.500MB -5.3%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.816ms (SLO: <88.000ms -5.9%) vs baseline: ~same Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 84.336ms (SLO: <89.000ms -5.2%) vs baseline: ~same Memory: ✅ 33.954MB (SLO: <46.500MB 📉 -27.0%) vs baseline: +4.6% ✅ update-nameTime: ✅ 44.372ms (SLO: <45.150ms 🟡 -1.7%) vs baseline: +0.3% Memory: ✅ 44.367MB (SLO: <46.500MB -4.6%) vs baseline: +5.0%
|
Backport ebd1e38 from #14700 to 3.14.
Description
Customer experienced error on stream endpoint on Daphne/Django application
Testing
This fix was tested on the repro application provided by the customer
Additional Notes
Importing asyncio globally may create bad interaction with gevent
APPSEC-59237
Checklist
Reviewer Checklist