fix(profiling): fix silent suppression of AssertionError exceptions in _ProfiledLock::_acquire #15089

vlad-scherbich · 2025-10-30T03:26:13Z

https://datadoghq.atlassian.net/browse/PROF-12594

Description

_ProfiledLock::_maybe_update_self_name raises AssertionError in two places when config.enable_asserts == True.

However, they're being silently suppressed by the try/catch block in the caller, _ProfiledLock::_acquire, method.

Current estimated impact is low, as it's only ever triggered for development workflows, but still, worth making it right. This PR fixes the bug by propagating AssertionError's by the caller.

Testing

Added two new tests: one for AssertionError and another for a non-AssertionError exception.

PROD
Test fails, since the AssertionError exception is not propagated

$ ./scripts/ddtest riot -v run --pass-env d667cb4 -- -k test_assertion_error_suppressed_in_acquire
...
FAILED tests/profiling_v2/collector/test_threading.py::TestThreadingLockCollector::test_assertion_error_suppressed_in_acquire - Failed: DID NOT RAISE <class 'AssertionError'>
FAILED tests/profiling_v2/collector/test_threading.py::TestThreadingRLockCollector::test_assertion_error_suppressed_in_acquire - Failed: DID NOT RAISE <class 'AssertionError'>

Highlighted code is for demonstration purposes only - not being merged

BRANCH
Test passes

$ ./scripts/ddtest riot -v run --pass-env d667cb4 -- -k test_assertion_error_suppressed_in_acquire
...
tests/profiling_v2/collector/test_threading.py::TestThreadingLockCollector::test_assertion_error_suppressed_in_acquire PASSED
tests/profiling_v2/collector/test_threading.py::TestThreadingRLockCollector::test_assertion_error_suppressed_in_acquire PASSED

Risks

none

github-actions · 2025-10-30T03:26:44Z

CODEOWNERS have been resolved as:

releasenotes/notes/fixed-silent-suppression-of-AssertionError-exceptions-in-Lock-profiler-20645079ab43b23d.yaml  @DataDog/apm-python
ddtrace/profiling/collector/_lock.py                                    @DataDog/profiling-python
tests/profiling_v2/collector/test_threading.py                          @DataDog/profiling-python

github-actions · 2025-10-30T03:51:49Z

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 241 ± 3 ms.

The average import time from base is: 243 ± 3 ms.

The import time difference between this PR and base is: -1.9 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.994 ms (0.83%)

ddtrace.bootstrap.sitecustomize 1.311 ms (0.54%)

ddtrace.bootstrap.preload 1.311 ms (0.54%)

ddtrace.internal.remoteconfig.client 0.643 ms (0.27%)

ddtrace 0.684 ms (0.28%)

ddtrace.internal._unpatched 0.030 ms (0.01%)

json 0.030 ms (0.01%)

json.decoder 0.030 ms (0.01%)

re 0.030 ms (0.01%)

enum 0.030 ms (0.01%)

types 0.030 ms (0.01%)

pr-commenter · 2025-10-30T04:24:54Z

Performance SLOs

Comparing candidate vlad/lockprof-fix-raise-on-asserts (d84f2ef) with baseline main (0a50af6)

🟡 Near SLO Breach (6 suites)

🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 20.500ms (SLO: <22.300ms -8.1%) vs baseline: +0.4%

Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0%

✅ exception-replay-enabled

Time: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: +0.5%

Memory: ✅ 64.049MB (SLO: <67.000MB -4.4%) vs baseline: +4.8%

✅ iast

Time: ✅ 20.509ms (SLO: <22.250ms -7.8%) vs baseline: +0.3%

Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0%

✅ profiler

Time: ✅ 15.604ms (SLO: <16.550ms -5.7%) vs baseline: +0.3%

Memory: ✅ 53.866MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9%

✅ resource-renaming

Time: ✅ 20.514ms (SLO: <21.750ms -5.7%) vs baseline: +0.3%

Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0%

✅ span-code-origin

Time: ✅ 25.408ms (SLO: <28.200ms -9.9%) vs baseline: +1.5%

Memory: ✅ 67.055MB (SLO: <69.500MB -3.5%) vs baseline: +4.5%

✅ tracer

Time: ✅ 20.495ms (SLO: <21.750ms -5.8%) vs baseline: ~same

Memory: ✅ 66.070MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9%

✅ tracer-and-profiler

Time: ✅ 22.658ms (SLO: <23.500ms -3.6%) vs baseline: -0.5%

Memory: ✅ 67.358MB (SLO: <68.000MB 🟡 -0.9%) vs baseline: +4.7%

✅ tracer-dont-create-db-spans

Time: ✅ 19.345ms (SLO: <21.500ms 📉 -10.0%) vs baseline: +0.3%

Memory: ✅ 66.109MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0%

✅ tracer-minimal

Time: ✅ 16.574ms (SLO: <17.500ms -5.3%) vs baseline: -0.3%

Memory: ✅ 65.755MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.6%

✅ tracer-native

Time: ✅ 20.483ms (SLO: <21.750ms -5.8%) vs baseline: ~same

Memory: ✅ 71.519MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.9%

✅ tracer-no-caches

Time: ✅ 18.486ms (SLO: <19.650ms -5.9%) vs baseline: +0.5%

Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9%

✅ tracer-no-databases

Time: ✅ 18.748ms (SLO: <20.100ms -6.7%) vs baseline: -0.2%

Memory: ✅ 65.628MB (SLO: <67.000MB -2.0%) vs baseline: +4.5%

✅ tracer-no-middleware

Time: ✅ 20.155ms (SLO: <21.500ms -6.3%) vs baseline: -0.1%

Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0%

✅ tracer-no-templates

Time: ✅ 20.276ms (SLO: <22.000ms -7.8%) vs baseline: -0.1%

Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0%

🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.060ms (SLO: <19.850ms -9.0%) vs baseline: +0.2%

Memory: ✅ 66.021MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 18.010ms (SLO: <19.400ms -7.2%) vs baseline: ~same

Memory: ✅ 66.001MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 18.354ms (SLO: <19.450ms -5.6%) vs baseline: +1.8%

Memory: ✅ 65.746MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.9%

🟡 errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.077ms (SLO: <2.300ms -9.7%) vs baseline: +0.4%

Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.7%

✅ errortracking-enabled-user

Time: ✅ 2.089ms (SLO: <2.250ms -7.1%) vs baseline: +0.7%

Memory: ✅ 52.455MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 2.083ms (SLO: <2.300ms -9.4%) vs baseline: +0.9%

Memory: ✅ 52.298MB (SLO: <53.500MB -2.2%) vs baseline: +4.7%

🟡 flasksimple - 18/18

✅ appsec-get

Time: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: -0.4%

Memory: ✅ 62.298MB (SLO: <65.000MB -4.2%) vs baseline: +5.0%

✅ appsec-post

Time: ✅ 6.619ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same

Memory: ✅ 62.273MB (SLO: <65.000MB -4.2%) vs baseline: +5.0%

✅ appsec-telemetry

Time: ✅ 4.600ms (SLO: <4.750ms -3.2%) vs baseline: -0.1%

Memory: ✅ 62.164MB (SLO: <65.000MB -4.4%) vs baseline: +4.6%

✅ debugger

Time: ✅ 1.853ms (SLO: <2.000ms -7.4%) vs baseline: -0.5%

Memory: ✅ 45.385MB (SLO: <47.000MB -3.4%) vs baseline: +5.5%

✅ iast-get

Time: ✅ 1.867ms (SLO: <2.000ms -6.6%) vs baseline: +0.3%

Memory: ✅ 42.089MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +5.1%

✅ profiler

Time: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: -0.2%

Memory: ✅ 46.543MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +5.2%

✅ resource-renaming

Time: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.4%

Memory: ✅ 52.494MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.9%

✅ tracer

Time: ✅ 3.351ms (SLO: <3.650ms -8.2%) vs baseline: -0.4%

Memory: ✅ 52.455MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.9%

✅ tracer-native

Time: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: ~same

Memory: ✅ 58.196MB (SLO: <60.000MB -3.0%) vs baseline: +4.9%

🟡 flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.958ms (SLO: <4.200ms -5.8%) vs baseline: -0.7%

Memory: ✅ 62.226MB (SLO: <66.000MB -5.7%) vs baseline: +4.7%

✅ iast-enabled

Time: ✅ 2.442ms (SLO: <2.800ms 📉 -12.8%) vs baseline: ~same

Memory: ✅ 59.081MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: +0.3%

Memory: ✅ 52.494MB (SLO: <54.500MB -3.7%) vs baseline: +4.9%

🟡 telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 2.953µs (SLO: <20.000µs 📉 -85.2%) vs baseline: ~same

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.8%

✅ 1-count-metrics-100-times

Time: ✅ 201.265µs (SLO: <220.000µs -8.5%) vs baseline: +1.3%

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.9%

✅ 1-distribution-metric-1-times

Time: ✅ 3.269µs (SLO: <20.000µs 📉 -83.7%) vs baseline: ~same

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +5.1%

✅ 1-distribution-metrics-100-times

Time: ✅ 213.432µs (SLO: <220.000µs -3.0%) vs baseline: +0.4%

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9%

✅ 1-gauge-metric-1-times

Time: ✅ 2.211µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.6%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9%

✅ 1-gauge-metrics-100-times

Time: ✅ 138.046µs (SLO: <150.000µs -8.0%) vs baseline: +0.7%

Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +5.1%

✅ 1-rate-metric-1-times

Time: ✅ 3.190µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +3.4%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.8%

✅ 1-rate-metrics-100-times

Time: ✅ 213.780µs (SLO: <250.000µs 📉 -14.5%) vs baseline: +0.5%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +5.1%

✅ 100-count-metrics-100-times

Time: ✅ 20.404ms (SLO: <22.000ms -7.3%) vs baseline: +1.5%

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.8%

✅ 100-distribution-metrics-100-times

Time: ✅ 2.281ms (SLO: <2.300ms 🟡 -0.8%) vs baseline: +2.0%

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.416ms (SLO: <1.550ms -8.6%) vs baseline: +0.5%

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.8%

✅ 100-rate-metrics-100-times

Time: ✅ 2.216ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +1.7%

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.8%

✅ flush-1-metric

Time: ✅ 4.596µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.5%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9%

✅ flush-100-metrics

Time: ✅ 174.476µs (SLO: <250.000µs 📉 -30.2%) vs baseline: ~same

Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9%

✅ flush-1000-metrics

Time: ✅ 2.130ms (SLO: <2.500ms 📉 -14.8%) vs baseline: -0.3%

Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +5.0%

⚠️ Unstable Tests (1 suite)

⚠️

coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.236µs (SLO: <20.000µs 📉 -33.8%) vs baseline: ~same

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%

✅ context_with_data_no_listeners

Time: ✅ 3.266µs (SLO: <10.000µs 📉 -67.3%) vs baseline: ~same

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.7%

✅ get_item_exists

Time: ✅ 0.579µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.2%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.8%

✅ get_item_missing

Time: ✅ 0.637µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +0.3%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +4.6%

✅ set_item

Time: ✅ 23.990µs (SLO: <30.000µs 📉 -20.0%) vs baseline: -1.1%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%

✅ All Tests Passing (17 suites)

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.656µs (SLO: <100.000µs 📉 -18.3%) vs baseline: +0.2%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +4.8%

✅ b3_headers

Time: ✅ 14.305µs (SLO: <20.000µs 📉 -28.5%) vs baseline: +0.4%

Memory: ✅ 31.988MB (SLO: <33.500MB -4.5%) vs baseline: +5.3%

✅ b3_single_headers

Time: ✅ 13.395µs (SLO: <20.000µs 📉 -33.0%) vs baseline: +1.3%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 64.402µs (SLO: <80.000µs 📉 -19.5%) vs baseline: +0.7%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.5%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.314µs (SLO: <80.000µs 📉 -17.1%) vs baseline: +0.1%

Memory: ✅ 32.008MB (SLO: <33.500MB -4.5%) vs baseline: +5.0%

✅ empty_headers

Time: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.6%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.6%

✅ full_t_id_datadog_headers

Time: ✅ 23.026µs (SLO: <30.000µs 📉 -23.2%) vs baseline: ~same

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +5.0%

✅ invalid_priority_header

Time: ✅ 6.564µs (SLO: <10.000µs 📉 -34.4%) vs baseline: -0.2%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.6%

✅ invalid_span_id_header

Time: ✅ 6.553µs (SLO: <10.000µs 📉 -34.5%) vs baseline: +0.1%

Memory: ✅ 31.988MB (SLO: <33.500MB -4.5%) vs baseline: +5.0%

✅ invalid_tags_header

Time: ✅ 6.533µs (SLO: <10.000µs 📉 -34.7%) vs baseline: ~same

Memory: ✅ 31.988MB (SLO: <33.500MB -4.5%) vs baseline: +4.9%

✅ invalid_trace_id_header

Time: ✅ 6.559µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.7%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ large_header_no_matches

Time: ✅ 27.753µs (SLO: <30.000µs -7.5%) vs baseline: +0.7%

Memory: ✅ 31.929MB (SLO: <33.500MB -4.7%) vs baseline: +4.7%

✅ large_valid_headers_all

Time: ✅ 28.750µs (SLO: <40.000µs 📉 -28.1%) vs baseline: +0.4%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +5.0%

✅ medium_header_no_matches

Time: ✅ 9.908µs (SLO: <20.000µs 📉 -50.5%) vs baseline: +0.3%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ medium_valid_headers_all

Time: ✅ 11.232µs (SLO: <20.000µs 📉 -43.8%) vs baseline: +0.2%

Memory: ✅ 32.008MB (SLO: <33.500MB -4.5%) vs baseline: +5.2%

✅ none_propagation_style

Time: ✅ 1.717µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +1.1%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.7%

✅ tracecontext_headers

Time: ✅ 34.783µs (SLO: <40.000µs 📉 -13.0%) vs baseline: +0.7%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ valid_headers_all

Time: ✅ 6.555µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.6%

Memory: ✅ 31.988MB (SLO: <33.500MB -4.5%) vs baseline: +5.1%

✅ valid_headers_basic

Time: ✅ 6.118µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.2%

Memory: ✅ 32.027MB (SLO: <33.500MB -4.4%) vs baseline: +4.9%

✅ wsgi_empty_headers

Time: ✅ 1.600µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.5%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.7%

✅ wsgi_invalid_priority_header

Time: ✅ 6.595µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +0.9%

Memory: ✅ 31.929MB (SLO: <33.500MB -4.7%) vs baseline: +4.7%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.587µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.2%

Memory: ✅ 31.929MB (SLO: <33.500MB -4.7%) vs baseline: +4.8%

✅ wsgi_invalid_tags_header

Time: ✅ 6.590µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +0.4%

Memory: ✅ 31.929MB (SLO: <33.500MB -4.7%) vs baseline: +5.0%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.621µs (SLO: <10.000µs 📉 -33.8%) vs baseline: +0.9%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ wsgi_large_header_no_matches

Time: ✅ 28.782µs (SLO: <40.000µs 📉 -28.0%) vs baseline: +0.3%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.7%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.882µs (SLO: <40.000µs 📉 -25.3%) vs baseline: +0.1%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +5.0%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.102µs (SLO: <20.000µs 📉 -49.5%) vs baseline: +0.2%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.7%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.544µs (SLO: <20.000µs 📉 -42.3%) vs baseline: +0.3%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.8%

✅ wsgi_valid_headers_all

Time: ✅ 6.556µs (SLO: <10.000µs 📉 -34.4%) vs baseline: -0.6%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +5.0%

✅ wsgi_valid_headers_basic

Time: ✅ 6.171µs (SLO: <10.000µs 📉 -38.3%) vs baseline: +0.5%

Memory: ✅ 31.890MB (SLO: <33.500MB -4.8%) vs baseline: +4.7%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.025µs (SLO: <30.000µs 📉 -29.9%) vs baseline: +0.2%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ with_all

Time: ✅ 28.406µs (SLO: <40.000µs 📉 -29.0%) vs baseline: +0.5%

Memory: ✅ 31.988MB (SLO: <33.500MB -4.5%) vs baseline: +5.1%

✅ with_dd_origin

Time: ✅ 24.784µs (SLO: <30.000µs 📉 -17.4%) vs baseline: +0.7%

Memory: ✅ 31.968MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ with_priority_and_origin

Time: ✅ 24.206µs (SLO: <40.000µs 📉 -39.5%) vs baseline: +0.4%

Memory: ✅ 31.909MB (SLO: <33.500MB -4.7%) vs baseline: +4.6%

✅ with_sampling_priority

Time: ✅ 21.166µs (SLO: <30.000µs 📉 -29.4%) vs baseline: +0.2%

Memory: ✅ 32.008MB (SLO: <33.500MB -4.5%) vs baseline: +5.1%

✅ with_tags

Time: ✅ 26.419µs (SLO: <40.000µs 📉 -34.0%) vs baseline: -0.1%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ with_tags_invalid

Time: ✅ 27.805µs (SLO: <40.000µs 📉 -30.5%) vs baseline: -0.7%

Memory: ✅ 31.929MB (SLO: <33.500MB -4.7%) vs baseline: +5.0%

✅ with_tags_max_size

Time: ✅ 27.050µs (SLO: <40.000µs 📉 -32.4%) vs baseline: +0.6%

Memory: ✅ 31.949MB (SLO: <33.500MB -4.6%) vs baseline: +4.9%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 32.212µs (SLO: <40.000µs 📉 -19.5%) vs baseline: +0.8%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ re_expand_noaspect

Time: ✅ 28.526µs (SLO: <40.000µs 📉 -28.7%) vs baseline: -1.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_findall_aspect

Time: ✅ 2.909µs (SLO: <10.000µs 📉 -70.9%) vs baseline: +0.5%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ re_findall_noaspect

Time: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ re_finditer_aspect

Time: ✅ 4.421µs (SLO: <10.000µs 📉 -55.8%) vs baseline: -0.6%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.5%

✅ re_finditer_noaspect

Time: ✅ 1.411µs (SLO: <10.000µs 📉 -85.9%) vs baseline: +0.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.8%

✅ re_fullmatch_aspect

Time: ✅ 2.626µs (SLO: <10.000µs 📉 -73.7%) vs baseline: -1.3%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_fullmatch_noaspect

Time: ✅ 1.297µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_group_aspect

Time: ✅ 2.898µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -4.1%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ re_group_noaspect

Time: ✅ 1.614µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.0%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_groups_aspect

Time: ✅ 3.049µs (SLO: <10.000µs 📉 -69.5%) vs baseline: -2.8%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ re_groups_noaspect

Time: ✅ 1.705µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.8%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.9%

✅ re_match_aspect

Time: ✅ 2.708µs (SLO: <10.000µs 📉 -72.9%) vs baseline: -2.2%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ re_match_noaspect

Time: ✅ 1.319µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +2.0%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ re_search_aspect

Time: ✅ 2.569µs (SLO: <10.000µs 📉 -74.3%) vs baseline: +1.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0%

✅ re_search_noaspect

Time: ✅ 1.200µs (SLO: <10.000µs 📉 -88.0%) vs baseline: ~same

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.6%

✅ re_sub_aspect

Time: ✅ 3.418µs (SLO: <10.000µs 📉 -65.8%) vs baseline: +1.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_sub_noaspect

Time: ✅ 1.551µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +2.1%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7%

✅ re_subn_aspect

Time: ✅ 3.720µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +0.8%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ re_subn_noaspect

Time: ✅ 1.616µs (SLO: <10.000µs 📉 -83.8%) vs baseline: -0.1%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.6%

✅ iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.7%

✅ add_inplace_aspect

Time: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.3%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ add_inplace_noaspect

Time: ✅ 0.318µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.2%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ add_noaspect

Time: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ bytearray_aspect

Time: ✅ 1.332µs (SLO: <10.000µs 📉 -86.7%) vs baseline: ~same

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.0%

✅ bytearray_extend_aspect

Time: ✅ 1.564µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.4%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.7%

✅ bytearray_extend_noaspect

Time: ✅ 0.620µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +1.0%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.8%

✅ bytes_aspect

Time: ✅ 1.265µs (SLO: <10.000µs 📉 -87.4%) vs baseline: -0.9%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ bytes_noaspect

Time: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.3%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.303µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.9%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.5%

✅ bytesio_noaspect

Time: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.6%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ capitalize_aspect

Time: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.3%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.6%

✅ capitalize_noaspect

Time: ✅ 0.431µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.7%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ casefold_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.8%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ casefold_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.3%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.7%

✅ decode_aspect

Time: ✅ 0.725µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.6%

✅ decode_noaspect

Time: ✅ 0.422µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.5%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ encode_aspect

Time: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.8%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ encode_noaspect

Time: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.3%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ format_aspect

Time: ✅ 3.406µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -0.7%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ format_map_aspect

Time: ✅ 3.650µs (SLO: <10.000µs 📉 -63.5%) vs baseline: ~same

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ format_map_noaspect

Time: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.6%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ format_noaspect

Time: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.3%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ index_aspect

Time: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.4%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7%

✅ index_noaspect

Time: ✅ 0.274µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.7%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ join_aspect

Time: ✅ 1.361µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.9%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ join_noaspect

Time: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.4%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ ljust_aspect

Time: ✅ 2.516µs (SLO: <20.000µs 📉 -87.4%) vs baseline: -1.4%

Memory: ✅ 37.906MB (SLO: <39.000MB -2.8%) vs baseline: +5.0%

✅ ljust_noaspect

Time: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.0%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.0%

✅ lower_aspect

Time: ✅ 2.181µs (SLO: <10.000µs 📉 -78.2%) vs baseline: -1.2%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.7%

✅ lower_noaspect

Time: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ lstrip_aspect

Time: ✅ 2.207µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -1.2%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ lstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.7%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.1%

✅ modulo_aspect

Time: ✅ 1.045µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.7%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.566µs (SLO: <10.000µs 📉 -84.3%) vs baseline: -0.7%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ modulo_aspect_for_bytes

Time: ✅ 0.974µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -0.5%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.280µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.2%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ modulo_noaspect

Time: ✅ 0.625µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.2%

Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +5.0%

✅ replace_aspect

Time: ✅ 4.887µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -1.0%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ replace_noaspect

Time: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.5%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.0%

✅ repr_aspect

Time: ✅ 0.910µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -1.5%

Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +5.1%

✅ repr_noaspect

Time: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.9%

Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ rstrip_aspect

Time: ✅ 1.901µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -1.5%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9%

✅ rstrip_noaspect

Time: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.8%

✅ slice_aspect

Time: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.1%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.1%

✅ slice_noaspect

Time: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.5%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.6%

✅ stringio_aspect

Time: ✅ 1.546µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -1.5%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7%

✅ stringio_noaspect

Time: ✅ 0.715µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.9%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.8%

✅ strip_aspect

Time: ✅ 2.197µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -1.2%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.7%

✅ strip_noaspect

Time: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.0%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.8%

✅ swapcase_aspect

Time: ✅ 2.409µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.3%

Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +5.0%

✅ swapcase_noaspect

Time: ✅ 0.536µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.1%

Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.7%

✅ title_aspect

Time: ✅ 2.383µs (SLO: <10.000µs 📉 -76.2%) vs baseline: +1.7%

Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +5.1%

✅ title_noaspect

Time: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2%

Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.0%

✅ translate_aspect

Time: ✅ 3.236µs (SLO: <10.000µs 📉 -67.6%) vs baseline: +0.3%

Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ translate_noaspect

Time: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.5%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ upper_aspect

Time: ✅ 2.188µs (SLO: <10.000µs 📉 -78.1%) vs baseline: -1.0%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0%

✅ upper_noaspect

Time: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.5%

Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.225µs (SLO: <10.000µs 📉 -57.7%) vs baseline: -0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ ospathbasename_noaspect

Time: ✅ 1.075µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.2%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ ospathjoin_aspect

Time: ✅ 6.123µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.3%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ ospathjoin_noaspect

Time: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.6%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.1%

✅ ospathnormcase_aspect

Time: ✅ 3.526µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +0.4%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ ospathnormcase_noaspect

Time: ✅ 0.561µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ ospathsplit_aspect

Time: ✅ 4.808µs (SLO: <10.000µs 📉 -51.9%) vs baseline: -1.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ ospathsplit_noaspect

Time: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ ospathsplitdrive_aspect

Time: ✅ 3.741µs (SLO: <10.000µs 📉 -62.6%) vs baseline: +0.7%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.7%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ ospathsplitext_aspect

Time: ✅ 4.563µs (SLO: <10.000µs 📉 -54.4%) vs baseline: -0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8%

✅ ospathsplitext_noaspect

Time: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.4%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.454µs (SLO: <10.000µs 📉 -85.5%) vs baseline: -0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%

✅ rsplit_noaspect

Time: ✅ 0.578µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0%

✅ split_aspect

Time: ✅ 1.418µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.6%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9%

✅ split_noaspect

Time: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7%

✅ splitlines_aspect

Time: ✅ 1.403µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.5%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.7%

✅ splitlines_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9%

✅ iastpropagation - 2/2

✅ no-propagation

Time: ✅ 48.748µs (SLO: <60.000µs 📉 -18.8%) vs baseline: ~same

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.5%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.574ms (SLO: <42.000ms -3.4%) vs baseline: ~same

Memory: ✅ 34.387MB (SLO: <39.000MB 📉 -11.8%) vs baseline: +4.9%

✅ add-link

Time: ✅ 36.562ms (SLO: <38.550ms -5.2%) vs baseline: +0.7%

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 219.266ms (SLO: <232.000ms -5.5%) vs baseline: -0.8%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.7%

✅ add-tags

Time: ✅ 210.077ms (SLO: <221.600ms -5.2%) vs baseline: -1.5%

Memory: ✅ 34.387MB (SLO: <39.000MB 📉 -11.8%) vs baseline: +5.1%

✅ get-context

Time: ✅ 29.081ms (SLO: <31.300ms -7.1%) vs baseline: ~same

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +4.6%

✅ is-recording

Time: ✅ 29.252ms (SLO: <31.000ms -5.6%) vs baseline: -0.2%

Memory: ✅ 34.269MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 63.022ms (SLO: <65.850ms -4.3%) vs baseline: -0.5%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +4.7%

✅ set-status

Time: ✅ 32.120ms (SLO: <34.150ms -5.9%) vs baseline: +0.7%

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +4.7%

✅ start

Time: ✅ 28.912ms (SLO: <30.150ms -4.1%) vs baseline: +0.6%

Memory: ✅ 34.367MB (SLO: <39.000MB 📉 -11.9%) vs baseline: +5.0%

✅ start-finish

Time: ✅ 34.086ms (SLO: <35.350ms -3.6%) vs baseline: +0.2%

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%) vs baseline: +5.0%

✅ start-finish-telemetry

Time: ✅ 34.028ms (SLO: <35.450ms -4.0%) vs baseline: -0.3%

Memory: ✅ 34.347MB (SLO: <39.000MB 📉 -11.9%) vs baseline: +4.9%

✅ update-name

Time: ✅ 31.272ms (SLO: <33.400ms -6.4%) vs baseline: ~same

Memory: ✅ 34.210MB (SLO: <39.000MB 📉 -12.3%) vs baseline: +4.5%

✅ otelspan - 22/22

✅ add-event

Time: ✅ 40.399ms (SLO: <47.150ms 📉 -14.3%) vs baseline: ~same

Memory: ✅ 43.605MB (SLO: <47.000MB -7.2%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 317.791ms (SLO: <344.800ms -7.8%) vs baseline: +0.4%

Memory: ✅ 651.694MB (SLO: <675.000MB -3.5%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 287.885ms (SLO: <314.000ms -8.3%) vs baseline: -0.7%

Memory: ✅ 654.172MB (SLO: <675.000MB -3.1%) vs baseline: +4.9%

✅ get-context

Time: ✅ 80.365ms (SLO: <92.350ms 📉 -13.0%) vs baseline: +0.1%

Memory: ✅ 39.434MB (SLO: <46.500MB 📉 -15.2%) vs baseline: +4.6%

✅ is-recording

Time: ✅ 38.835ms (SLO: <44.500ms 📉 -12.7%) vs baseline: +1.8%

Memory: ✅ 42.892MB (SLO: <47.500MB -9.7%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 58.059ms (SLO: <67.650ms 📉 -14.2%) vs baseline: ~same

Memory: ✅ 39.688MB (SLO: <47.000MB 📉 -15.6%) vs baseline: +4.9%

✅ set-status

Time: ✅ 44.383ms (SLO: <50.400ms 📉 -11.9%) vs baseline: +1.1%

Memory: ✅ 42.872MB (SLO: <47.000MB -8.8%) vs baseline: +4.5%

✅ start

Time: ✅ 38.134ms (SLO: <43.450ms 📉 -12.2%) vs baseline: +2.3%

Memory: ✅ 42.979MB (SLO: <47.000MB -8.6%) vs baseline: +4.9%

✅ start-finish

Time: ✅ 81.238ms (SLO: <88.000ms -7.7%) vs baseline: -0.7%

Memory: ✅ 34.446MB (SLO: <46.500MB 📉 -25.9%) vs baseline: +4.9%

✅ start-finish-telemetry

Time: ✅ 83.066ms (SLO: <89.000ms -6.7%) vs baseline: ~same

Memory: ✅ 34.406MB (SLO: <46.500MB 📉 -26.0%) vs baseline: +5.0%

✅ update-name

Time: ✅ 39.094ms (SLO: <45.150ms 📉 -13.4%) vs baseline: +0.5%

Memory: ✅ 43.329MB (SLO: <47.000MB -7.8%) vs baseline: +5.0%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 344.067ms (SLO: <354.300ms -2.9%) vs baseline: -0.3%

Memory: ✅ 37.476MB (SLO: <40.000MB -6.3%) vs baseline: +4.6%

✅ cache_on

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.4%

Memory: ✅ 36.975MB (SLO: <39.000MB -5.2%) vs baseline: +4.7%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 155.628µs (SLO: <170.000µs -8.5%) vs baseline: +0.4%

Memory: ✅ 36.813MB (SLO: <38.500MB -4.4%) vs baseline: +3.7%

✅ import_many_cached

Time: ✅ 120.411µs (SLO: <130.000µs -7.4%) vs baseline: -0.4%

Memory: ✅ 36.741MB (SLO: <38.500MB -4.6%) vs baseline: +4.5%

✅ import_many_stdlib

Time: ✅ 1.625ms (SLO: <1.750ms -7.1%) vs baseline: ~same

Memory: ✅ 36.432MB (SLO: <38.500MB -5.4%) vs baseline: +3.0%

✅ import_many_stdlib_cached

Time: ✅ 0.974ms (SLO: <1.100ms 📉 -11.5%) vs baseline: -0.3%

Memory: ✅ 36.506MB (SLO: <38.500MB -5.2%) vs baseline: +3.2%

✅ import_many_unknown

Time: ✅ 830.748µs (SLO: <890.000µs -6.7%) vs baseline: +0.2%

Memory: ✅ 37.189MB (SLO: <38.500MB -3.4%) vs baseline: +4.6%

✅ import_many_unknown_cached

Time: ✅ 793.214µs (SLO: <870.000µs -8.8%) vs baseline: -0.3%

Memory: ✅ 36.667MB (SLO: <38.500MB -4.8%) vs baseline: +3.7%

✅ import_one

Time: ✅ 19.863µs (SLO: <30.000µs 📉 -33.8%) vs baseline: +0.6%

Memory: ✅ 36.849MB (SLO: <39.000MB -5.5%) vs baseline: +4.8%

✅ import_one_cache

Time: ✅ 6.248µs (SLO: <10.000µs 📉 -37.5%) vs baseline: -0.8%

Memory: ✅ 36.779MB (SLO: <38.500MB -4.5%) vs baseline: +4.5%

✅ import_one_stdlib

Time: ✅ 18.773µs (SLO: <20.000µs -6.1%) vs baseline: +0.3%

Memory: ✅ 36.719MB (SLO: <38.500MB -4.6%) vs baseline: +4.4%

✅ import_one_stdlib_cache

Time: ✅ 6.265µs (SLO: <10.000µs 📉 -37.4%) vs baseline: -0.2%

Memory: ✅ 36.589MB (SLO: <38.500MB -5.0%) vs baseline: +3.9%

✅ import_one_unknown

Time: ✅ 45.612µs (SLO: <50.000µs -8.8%) vs baseline: +0.5%

Memory: ✅ 36.672MB (SLO: <38.500MB -4.7%) vs baseline: +3.9%

✅ import_one_unknown_cache

Time: ✅ 6.296µs (SLO: <10.000µs 📉 -37.0%) vs baseline: -0.4%

Memory: ✅ 36.589MB (SLO: <38.500MB -5.0%) vs baseline: +4.1%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.365µs (SLO: <10.000µs 📉 -76.4%) vs baseline: +0.5%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.7%

✅ high_rate_limit

Time: ✅ 2.399µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.1%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.7%

✅ long_window

Time: ✅ 2.360µs (SLO: <10.000µs 📉 -76.4%) vs baseline: -0.1%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.1%

✅ low_rate_limit

Time: ✅ 2.353µs (SLO: <10.000µs 📉 -76.5%) vs baseline: ~same

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9%

✅ no_rate_limit

Time: ✅ 0.819µs (SLO: <10.000µs 📉 -91.8%) vs baseline: -0.4%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.9%

✅ short_window

Time: ✅ 2.509µs (SLO: <10.000µs 📉 -74.9%) vs baseline: +0.7%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.0%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 308.834ms (SLO: <320.950ms -3.8%) vs baseline: +0.1%

Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +4.9%

✅ deep-profiled

Time: ✅ 328.777ms (SLO: <359.150ms -8.5%) vs baseline: ~same

Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.8%

✅ medium

Time: ✅ 7.005ms (SLO: <7.400ms -5.3%) vs baseline: +0.2%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +5.0%

✅ shallow

Time: ✅ 0.946ms (SLO: <1.050ms -9.9%) vs baseline: +0.4%

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.6%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 136.558µs (SLO: <290.000µs 📉 -52.9%) vs baseline: +0.1%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +4.8%

✅ high_match

Time: ✅ 173.605µs (SLO: <480.000µs 📉 -63.8%) vs baseline: -0.5%

Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +4.9%

✅ low_match

Time: ✅ 98.820µs (SLO: <120.000µs 📉 -17.6%) vs baseline: -0.7%

Memory: ✅ 600.632MB (SLO: <700.000MB 📉 -14.2%) vs baseline: +4.9%

✅ very_low_match

Time: ✅ 2.663ms (SLO: <8.500ms 📉 -68.7%) vs baseline: -0.6%

Memory: ✅ 67.952MB (SLO: <75.000MB -9.4%) vs baseline: +4.8%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.459µs (SLO: <20.000µs 📉 -47.7%) vs baseline: -0.6%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +4.6%

✅ all-enabled

Time: ✅ 40.458µs (SLO: <50.000µs 📉 -19.1%) vs baseline: +1.4%

Memory: ✅ 32.401MB (SLO: <34.000MB -4.7%) vs baseline: +4.9%

✅ collectipvariant_exists

Time: ✅ 40.767µs (SLO: <50.000µs 📉 -18.5%) vs baseline: +0.3%

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%) vs baseline: +4.9%

✅ no-collectipvariant

Time: ✅ 39.912µs (SLO: <50.000µs 📉 -20.2%) vs baseline: +0.4%

Memory: ✅ 32.460MB (SLO: <34.000MB -4.5%) vs baseline: +5.1%

✅ no-useragentvariant

Time: ✅ 38.734µs (SLO: <50.000µs 📉 -22.5%) vs baseline: +0.2%

Memory: ✅ 32.440MB (SLO: <34.000MB -4.6%) vs baseline: +5.0%

✅ obfuscation-no-query

Time: ✅ 40.229µs (SLO: <50.000µs 📉 -19.5%) vs baseline: -0.4%

Memory: ✅ 32.401MB (SLO: <34.000MB -4.7%) vs baseline: +5.0%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.426µs (SLO: <90.000µs 📉 -16.2%) vs baseline: -0.1%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +4.4%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.329µs (SLO: <90.000µs 📉 -15.2%) vs baseline: +0.1%

Memory: ✅ 32.853MB (SLO: <34.000MB -3.4%) vs baseline: +5.0%

✅ obfuscation-send-querystring-disabled

Time: ✅ 153.813µs (SLO: <170.000µs -9.5%) vs baseline: -0.1%

Memory: ✅ 32.735MB (SLO: <34.500MB -5.1%) vs baseline: +4.8%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.627µs (SLO: <160.000µs -7.1%) vs baseline: +0.1%

Memory: ✅ 32.775MB (SLO: <34.500MB -5.0%) vs baseline: +5.0%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.397µs (SLO: <170.000µs -9.2%) vs baseline: +0.2%

Memory: ✅ 32.775MB (SLO: <34.500MB -5.0%) vs baseline: +4.7%

✅ useragentvariant_exists_1

Time: ✅ 39.492µs (SLO: <50.000µs 📉 -21.0%) vs baseline: +0.1%

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%) vs baseline: +4.7%

✅ useragentvariant_exists_2

Time: ✅ 40.346µs (SLO: <50.000µs 📉 -19.3%) vs baseline: -0.4%

Memory: ✅ 32.440MB (SLO: <34.000MB -4.6%) vs baseline: +5.1%

✅ useragentvariant_exists_3

Time: ✅ 40.840µs (SLO: <50.000µs 📉 -18.3%) vs baseline: +2.3%

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%) vs baseline: +4.9%

✅ useragentvariant_not_exists_1

Time: ✅ 39.454µs (SLO: <50.000µs 📉 -21.1%) vs baseline: +0.4%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +4.9%

✅ useragentvariant_not_exists_2

Time: ✅ 39.333µs (SLO: <50.000µs 📉 -21.3%) vs baseline: +0.2%

Memory: ✅ 32.401MB (SLO: <34.000MB -4.7%) vs baseline: +5.0%

✅ span - 26/26

✅ add-event

Time: ✅ 20.086ms (SLO: <22.500ms 📉 -10.7%) vs baseline: +1.6%

Memory: ✅ 48.378MB (SLO: <53.000MB -8.7%) vs baseline: +4.6%

✅ add-metrics

Time: ✅ 89.936ms (SLO: <93.500ms -3.8%) vs baseline: ~same

Memory: ✅ 736.203MB (SLO: <961.000MB 📉 -23.4%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 146.527ms (SLO: <155.000ms -5.5%) vs baseline: -0.1%

Memory: ✅ 736.168MB (SLO: <962.500MB 📉 -23.5%) vs baseline: +4.9%

✅ get-context

Time: ✅ 18.347ms (SLO: <20.500ms 📉 -10.5%) vs baseline: +0.7%

Memory: ✅ 47.237MB (SLO: <53.000MB 📉 -10.9%) vs baseline: +4.7%

✅ is-recording

Time: ✅ 18.596ms (SLO: <20.500ms -9.3%) vs baseline: +0.8%

Memory: ✅ 47.271MB (SLO: <53.000MB 📉 -10.8%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 37.576ms (SLO: <40.000ms -6.1%) vs baseline: +0.4%

Memory: ✅ 41.569MB (SLO: <53.000MB 📉 -21.6%) vs baseline: +4.7%

✅ set-status

Time: ✅ 20.240ms (SLO: <22.000ms -8.0%) vs baseline: +1.1%

Memory: ✅ 47.260MB (SLO: <53.000MB 📉 -10.8%) vs baseline: +4.7%

✅ start

Time: ✅ 18.174ms (SLO: <20.500ms 📉 -11.3%) vs baseline: +0.4%

Memory: ✅ 47.231MB (SLO: <53.000MB 📉 -10.9%) vs baseline: +4.8%

✅ start-finish

Time: ✅ 50.815ms (SLO: <52.500ms -3.2%) vs baseline: ~same

Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +5.1%

✅ start-finish-telemetry

Time: ✅ 52.323ms (SLO: <54.500ms -4.0%) vs baseline: +0.8%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.7%

✅ start-finish-traceid128

Time: ✅ 53.912ms (SLO: <57.000ms -5.4%) vs baseline: +0.7%

Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +5.0%

✅ start-traceid128

Time: ✅ 19.053ms (SLO: <22.500ms 📉 -15.3%) vs baseline: +2.8%

Memory: ✅ 47.212MB (SLO: <53.000MB 📉 -10.9%) vs baseline: +4.8%

✅ update-name

Time: ✅ 18.780ms (SLO: <22.000ms 📉 -14.6%) vs baseline: +1.0%

Memory: ✅ 47.880MB (SLO: <53.000MB -9.7%) vs baseline: +4.7%

✅ tracer - 6/6

✅ large

Time: ✅ 29.330ms (SLO: <32.950ms 📉 -11.0%) vs baseline: +0.5%

Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +4.9%

✅ medium

Time: ✅ 2.868ms (SLO: <3.200ms 📉 -10.4%) vs baseline: -0.2%

Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +5.1%

✅ small

Time: ✅ 329.235µs (SLO: <370.000µs 📉 -11.0%) vs baseline: +1.1%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

coreapiscenario-core_dispatch_listeners
coreapiscenario-core_dispatch_no_listeners
coreapiscenario-core_dispatch_with_results_listeners
coreapiscenario-core_dispatch_with_results_no_listeners
djangosimple-baseline
errortrackingdjangosimple-baseline
errortrackingflasksqli-baseline
flasksimple-baseline
flasksqli-baseline

ddtrace/profiling/collector/_lock.py

taegyunkim · 2025-10-31T16:55:53Z

https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1207759222

Precheck is failing on style step

taegyunkim

Just OOC, how did you find this behavior? were you expecting some code to raise an AssertionError but it didn't?

ddtrace/profiling/collector/_lock.py

vlad-scherbich · 2025-11-03T14:06:50Z

Just OOC, how did you find this behavior? were you expecting some code to raise an AssertionError but it didn't?

By reading the code :)

I was trying to dedupe copy/pasted code so that it's easier to reason about it and maintain going forward (here: #15088). This was one of the things that I've realized in the process.

vlad-scherbich · 2025-11-03T14:15:25Z

https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1207759222

Precheck is failing on style step

Fixed

ddtrace/profiling/collector/_lock.py

…:_acquire

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch 2 times, most recently from 43e92af to b1c180c Compare October 30, 2025 15:02

vlad-scherbich changed the title ~~WIP: adding tests~~ fix(profiling): fix silent suppression of AssertionError exceptions in _ProfiledLock::_acquire Oct 30, 2025

vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 30, 2025

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from b1c180c to 5e752e1 Compare October 30, 2025 15:05

vlad-scherbich removed the changelog/no-changelog A changelog entry is not required for this PR. label Oct 30, 2025

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from 5e752e1 to 12e5e54 Compare October 30, 2025 15:12

vlad-scherbich marked this pull request as ready for review October 30, 2025 15:12

vlad-scherbich requested review from a team as code owners October 30, 2025 15:12

vlad-scherbich requested review from avara1986 and wconti27 October 30, 2025 15:12

taegyunkim reviewed Oct 30, 2025

View reviewed changes

ddtrace/profiling/collector/_lock.py Outdated Show resolved Hide resolved

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from 12e5e54 to 7290ce2 Compare October 30, 2025 17:19

vlad-scherbich commented Oct 30, 2025

View reviewed changes

ddtrace/profiling/collector/_lock.py Show resolved Hide resolved

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from 061d705 to 3821df5 Compare October 30, 2025 18:29

vlad-scherbich requested a review from a team October 30, 2025 19:03

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch 2 times, most recently from 7ef3b6a to a9b1eaa Compare October 30, 2025 19:06

taegyunkim reviewed Oct 31, 2025

View reviewed changes

taegyunkim added the Profiling Continous Profling label Oct 31, 2025

taegyunkim requested review from a team and KowalskiThomas October 31, 2025 18:33

taegyunkim added Profiling Continous Profling and removed Profiling Continous Profling labels Oct 31, 2025

KowalskiThomas reviewed Oct 31, 2025

View reviewed changes

ddtrace/profiling/collector/_lock.py Outdated Show resolved Hide resolved

ddtrace/profiling/collector/_lock.py Show resolved Hide resolved

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from a9b1eaa to 7e201dd Compare November 3, 2025 14:15

vlad-scherbich enabled auto-merge (squash) November 3, 2025 14:15

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from 7e201dd to ae3871e Compare November 3, 2025 14:20

KowalskiThomas reviewed Nov 3, 2025

View reviewed changes

ddtrace/profiling/collector/_lock.py Outdated Show resolved Hide resolved

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch 2 times, most recently from f1a6d4a to 62fd125 Compare November 3, 2025 21:10

taegyunkim reviewed Nov 3, 2025

View reviewed changes

ddtrace/profiling/collector/_lock.py Outdated Show resolved Hide resolved

vlad-scherbich added 5 commits November 3, 2025 21:39

Fix silent suppression of AssertionError exceptions in _ProfiledLock:…

1ee98e7

…:_acquire

rename tests for clarity

38f9677

replace inline frame collections with one-time globals definition

44ac911

new tests with different config settings

9556cd7

restore #nosec comment

d84f2ef

vlad-scherbich force-pushed the vlad/lockprof-fix-raise-on-asserts branch from 62fd125 to d84f2ef Compare November 4, 2025 02:47

KowalskiThomas approved these changes Nov 4, 2025

View reviewed changes

taegyunkim approved these changes Nov 4, 2025

View reviewed changes

vlad-scherbich merged commit 979e756 into main Nov 4, 2025
493 checks passed

vlad-scherbich deleted the vlad/lockprof-fix-raise-on-asserts branch November 4, 2025 15:51

fix(profiling): fix silent suppression of AssertionError exceptions in _ProfiledLock::_acquire #15089

fix(profiling): fix silent suppression of AssertionError exceptions in _ProfiledLock::_acquire #15089

Conversation

vlad-scherbich commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Risks

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bootstrap import analysis

Summary

Import time breakdown

Uh oh!

pr-commenter bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance SLOs

✅ appsec

✅ exception-replay-enabled

✅ iast

✅ profiler

✅ resource-renaming

✅ span-code-origin

✅ tracer

✅ tracer-and-profiler

✅ tracer-dont-create-db-spans

✅ tracer-minimal

✅ tracer-native

✅ tracer-no-caches

✅ tracer-no-databases

✅ tracer-no-middleware

✅ tracer-no-templates

✅ errortracking-enabled-all

✅ errortracking-enabled-user

✅ tracer-enabled

✅ errortracking-enabled-all

✅ errortracking-enabled-user

✅ tracer-enabled

✅ appsec-get

✅ appsec-post

✅ appsec-telemetry

✅ debugger

✅ iast-get

✅ profiler

✅ resource-renaming

✅ tracer

✅ tracer-native

✅ appsec-enabled

✅ iast-enabled

✅ tracer-enabled

✅ 1-count-metric-1-times

✅ 1-count-metrics-100-times

✅ 1-distribution-metric-1-times

✅ 1-distribution-metrics-100-times

✅ 1-gauge-metric-1-times

✅ 1-gauge-metrics-100-times

✅ 1-rate-metric-1-times

✅ 1-rate-metrics-100-times

✅ 100-count-metrics-100-times

✅ 100-distribution-metrics-100-times

✅ 100-gauge-metrics-100-times

✅ 100-rate-metrics-100-times

✅ flush-1-metric

✅ flush-100-metrics

✅ flush-1000-metrics

⚠️ context_with_data_listeners

✅ context_with_data_no_listeners

✅ get_item_exists

✅ get_item_missing

✅ set_item

✅ all_styles_all_headers

✅ b3_headers

✅ b3_single_headers

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

✅ empty_headers

vlad-scherbich commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

pr-commenter bot commented Oct 30, 2025 •

edited

Loading