-
Notifications
You must be signed in to change notification settings - Fork 469
chore: relax suffix cond site-packages search for modules
#15123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
site-packages search for modulesite-packages search for modules
b96f8a6 to
2855d97
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 200 ± 2 ms. The average import time from base is: 201 ± 1 ms. The import time difference between this PR and base is: -1.64 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate tyler.finethy/relax-root-module-lookup (e082bc5) with baseline main (a139e88) 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.462ms (SLO: <22.300ms -8.2%) vs baseline: +0.2% Memory: ✅ 66.122MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: -0.2% Memory: ✅ 64.189MB (SLO: <67.000MB -4.2%) vs baseline: +4.7% ✅ iastTime: ✅ 20.431ms (SLO: <22.250ms -8.2%) vs baseline: -0.2% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ profilerTime: ✅ 15.497ms (SLO: <16.550ms -6.4%) vs baseline: +0.3% Memory: ✅ 53.957MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.545ms (SLO: <21.750ms -5.5%) vs baseline: +0.3% Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 24.999ms (SLO: <28.200ms 📉 -11.3%) vs baseline: -1.6% Memory: ✅ 67.393MB (SLO: <69.500MB -3.0%) vs baseline: +5.4% ✅ tracerTime: ✅ 20.450ms (SLO: <21.750ms -6.0%) vs baseline: -0.2% Memory: ✅ 66.131MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.2% ✅ tracer-and-profilerTime: ✅ 22.693ms (SLO: <23.500ms -3.4%) vs baseline: ~same Memory: ✅ 67.830MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.346ms (SLO: <21.500ms 📉 -10.0%) vs baseline: ~same Memory: ✅ 66.083MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.635ms (SLO: <17.500ms -4.9%) vs baseline: ~same Memory: ✅ 66.082MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 20.487ms (SLO: <21.750ms -5.8%) vs baseline: -0.2% Memory: ✅ 68.007MB (SLO: <72.500MB -6.2%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.458ms (SLO: <19.650ms -6.1%) vs baseline: -0.2% Memory: ✅ 66.052MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.790ms (SLO: <20.100ms -6.5%) vs baseline: -0.2% Memory: ✅ 65.913MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ tracer-no-middlewareTime: ✅ 20.198ms (SLO: <21.500ms -6.1%) vs baseline: +0.5% Memory: ✅ 66.123MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.311ms (SLO: <22.000ms -7.7%) vs baseline: ~same Memory: ✅ 66.180MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.014ms (SLO: <19.850ms -9.2%) vs baseline: -0.4% Memory: ✅ 66.159MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.024ms (SLO: <19.400ms -7.1%) vs baseline: -0.4% Memory: ✅ 66.178MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.017ms (SLO: <19.450ms -7.4%) vs baseline: -0.3% Memory: ✅ 66.041MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +5.2% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.101ms (SLO: <2.300ms -8.6%) vs baseline: +1.7% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 2.105ms (SLO: <2.250ms -6.5%) vs baseline: +1.9% Memory: ✅ 52.671MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.072ms (SLO: <2.300ms -9.9%) vs baseline: -0.2% Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 62.385MB (SLO: <65.000MB -4.0%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.618ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 62.346MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.382MB (SLO: <65.000MB -4.0%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: ~same Memory: ✅ 45.191MB (SLO: <47.000MB -3.8%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.037MB (SLO: <49.000MB 📉 -14.2%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.617MB (SLO: <47.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: -0.3% Memory: ✅ 52.557MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: +0.1% Memory: ✅ 52.539MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.351ms (SLO: <3.650ms -8.2%) vs baseline: ~same Memory: ✅ 54.302MB (SLO: <60.000MB -9.5%) vs baseline: +4.9%
|
This came up reviewing some Exception Replay snapshots where the paths took the form: > /usr/local/runfiles/pypi_linux_x86_64_parsimonious/site-packages/parsimonious/expressions.py Rather than add another case for this, we can remove the suffix check since we're looping over `path.parents` anyways. This should improve the third-party detection for more unconvential build environments beyond bazel.
c755696 to
e082bc5
Compare
Description
This came up reviewing some Exception Replay snapshots where the paths took the form:
Rather than add another case for this, we can remove the suffix check since we're looping over
path.parentsanyways.This should improve the third-party detection for more unconvential build environments beyond bazel.
Testing
Manual QA and unittests
Risks
None
Additional Notes