-
Notifications
You must be signed in to change notification settings - Fork 467
fix(llmobs): safely output format bedrock cohere rerank spans #15124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 244 ± 4 ms. The average import time from base is: 246 ± 5 ms. The import time difference between this PR and base is: -2.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate yunkim/fix-cohere-bedrock (0dc9937) with baseline main (b2d11f1) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.1% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -1.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.8% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.319µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +0.3% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 1.568µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +0.8% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.615µs (SLO: <10.000µs 📉 -93.9%) vs baseline: ~same Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.6% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.5% ✅ bytes_aspectTime: ✅ 1.275µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +1.3% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.337µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.8% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ bytesio_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.6% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.5% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.522µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +3.9% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.674µs (SLO: <10.000µs 📉 -63.3%) vs baseline: -0.7% Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.775µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.2% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.592µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.4% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.9% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.1% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.540µs (SLO: <20.000µs 📉 -87.3%) vs baseline: -0.9% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.199µs (SLO: <10.000µs 📉 -78.0%) vs baseline: ~same Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 2.471µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +10.9% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.4% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 1.046µs (SLO: <10.000µs 📉 -89.5%) vs baseline: ~same Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.579µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -1.1% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.5% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.290µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +1.1% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.5% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 4.941µs (SLO: <10.000µs 📉 -50.6%) vs baseline: +0.8% Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.4% Memory: ✅ 37.886MB (SLO: <39.000MB -2.9%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.914µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.916µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.7% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.9% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.6% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.451µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.8% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.562µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +1.0% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.5% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 2.492µs (SLO: <20.000µs 📉 -87.5%) vs baseline: 📈 +13.1% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 2.440µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +1.7% Memory: ✅ 37.867MB (SLO: <39.000MB -2.9%) vs baseline: +5.1% ✅ swapcase_noaspectTime: ✅ 0.531µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.7% Memory: ✅ 37.847MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.421µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +3.8% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.9% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.6% ✅ translate_aspectTime: ✅ 3.429µs (SLO: <10.000µs 📉 -65.7%) vs baseline: +6.1% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.222µs (SLO: <10.000µs 📉 -77.8%) vs baseline: +0.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.118µs (SLO: <10.000µs 📉 -48.8%) vs baseline: 📈 +20.0% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.101µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +1.1% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.988µs (SLO: <10.000µs 📉 -30.1%) vs baseline: 📈 +14.3% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.316µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +0.9% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.3% ✅ ospathnormcase_aspectTime: ✅ 3.798µs (SLO: <10.000µs 📉 -62.0%) vs baseline: +7.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.574µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 5.984µs (SLO: <10.000µs 📉 -40.2%) vs baseline: 📈 +24.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.612µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.0% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 4.335µs (SLO: <10.000µs 📉 -56.6%) vs baseline: 📈 +17.2% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.705µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.554µs (SLO: <10.000µs 📉 -54.5%) vs baseline: -0.8% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.386µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +1.1% Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.402ms (SLO: <22.300ms -8.5%) vs baseline: ~same Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: -0.3% Memory: ✅ 64.077MB (SLO: <67.000MB -4.4%) vs baseline: +4.7% ✅ iastTime: ✅ 20.479ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.606ms (SLO: <16.550ms -5.7%) vs baseline: ~same Memory: ✅ 53.838MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.591ms (SLO: <21.750ms -5.3%) vs baseline: +0.2% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.361ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 67.227MB (SLO: <69.500MB -3.3%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.435ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.699ms (SLO: <23.500ms -3.4%) vs baseline: ~same Memory: ✅ 67.358MB (SLO: <68.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.329ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.597ms (SLO: <17.500ms -5.2%) vs baseline: +0.4% Memory: ✅ 65.622MB (SLO: <67.000MB -2.1%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.435ms (SLO: <21.750ms -6.0%) vs baseline: -0.3% Memory: ✅ 71.472MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.468ms (SLO: <19.650ms -6.0%) vs baseline: ~same Memory: ✅ 65.746MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ tracer-no-databasesTime: ✅ 18.791ms (SLO: <20.100ms -6.5%) vs baseline: +0.2% Memory: ✅ 65.628MB (SLO: <67.000MB -2.0%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.212ms (SLO: <21.500ms -6.0%) vs baseline: +0.3% Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.335ms (SLO: <22.000ms -7.6%) vs baseline: +0.3% Memory: ✅ 66.055MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.077ms (SLO: <19.850ms -8.9%) vs baseline: ~same Memory: ✅ 65.757MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.132ms (SLO: <19.400ms -6.5%) vs baseline: +0.2% Memory: ✅ 65.765MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.108ms (SLO: <19.450ms -6.9%) vs baseline: ~same Memory: ✅ 65.628MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.596ms (SLO: <4.750ms -3.2%) vs baseline: +0.3% Memory: ✅ 62.351MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.637ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: ~same Memory: ✅ 62.174MB (SLO: <65.000MB -4.3%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.597ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.248MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.147MB (SLO: <47.000MB -3.9%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.878ms (SLO: <2.000ms -6.1%) vs baseline: +1.2% Memory: ✅ 42.154MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: ~same Memory: ✅ 46.156MB (SLO: <47.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: +0.3% Memory: ✅ 52.561MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 52.524MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.352ms (SLO: <3.650ms -8.2%) vs baseline: ~same Memory: ✅ 58.019MB (SLO: <60.000MB -3.3%) vs baseline: +4.6% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.966ms (SLO: <4.200ms -5.6%) vs baseline: -0.4% Memory: ✅ 62.226MB (SLO: <66.000MB -5.7%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.442ms (SLO: <2.800ms 📉 -12.8%) vs baseline: -0.5% Memory: ✅ 59.061MB (SLO: <60.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: -0.2% Memory: ✅ 52.455MB (SLO: <54.500MB -3.8%) vs baseline: +4.7%
|
## Description Closes #14575. <!-- Provide an overview of the change and motivation for the change --> Adds safely accessing output response messages in the bedrock integration. This happens when cohere rerank models are invoked, since cohere rerank responses lack a response["text"] field and will return an empty list. ## Testing Added a test invoking cohere rerank models. <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 191f10e)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.17 3.17
# Navigate to the new working tree
cd .worktrees/backport-3.17
# Create a new branch
git switch --create backport-15124-to-3.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 191f10e1e04bf904557a3e91d2b1b11ef5741627
# Push it to GitHub
git push --set-upstream origin backport-15124-to-3.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.17Then, create a pull request where the |
## Description Closes #14575. <!-- Provide an overview of the change and motivation for the change --> Adds safely accessing output response messages in the bedrock integration. This happens when cohere rerank models are invoked, since cohere rerank responses lack a response["text"] field and will return an empty list. ## Testing Added a test invoking cohere rerank models. <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 191f10e) Signed-off-by: Yun Kim <yun.kim@datadoghq.com>
…rt 3.17] (#15137) Backport 191f10e from #15124 to 3.17. ## Description Closes #14575. <!-- Provide an overview of the change and motivation for the change --> Adds safely accessing output response messages in the bedrock integration. This happens when cohere rerank models are invoked, since cohere rerank responses lack a response["text"] field and will return an empty list. ## Testing Added a test invoking cohere rerank models. <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Signed-off-by: Yun Kim <yun.kim@datadoghq.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Description
Closes #14575.
Adds safely accessing output response messages in the bedrock integration. This happens when cohere rerank models are invoked, since cohere rerank responses lack a response["text"] field and will return an empty list.
Testing
Added a test invoking cohere rerank models.
Risks
Additional Notes