Skip to content

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Nov 14, 2025

Backport 52d499b from #15279 to 4.0.

Description

They are failing with:

AttributeError: 'OverheadControl' object has no attribute 'release_request'

Which means we aren't getting benchmark results, and now the SLO check will fail if the results for a given benchmark are missing.

Testing

Risks

Additional Notes

@dd-octo-sts dd-octo-sts bot added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 14, 2025
@dd-octo-sts dd-octo-sts bot requested review from a team as code owners November 14, 2025 18:25
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml         @DataDog/python-guild @DataDog/apm-core-python
.gitlab/benchmarks/microbenchmarks.yml                                  @DataDog/python-guild @DataDog/apm-core-python

## Description

They are failing with:

> AttributeError: 'OverheadControl' object has no attribute
'release_request'

Which means we aren't getting benchmark results, and now the SLO check
will fail if the results for a given benchmark are missing.

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 52d499b)
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 236 ± 3 ms.

The average import time from base is: 239 ± 4 ms.

The import time difference between this PR and base is: -2.5 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.045 ms (0.87%)
ddtrace.bootstrap.sitecustomize 1.359 ms (0.58%)
ddtrace.bootstrap.preload 1.359 ms (0.58%)
ddtrace.internal.remoteconfig.client 0.629 ms (0.27%)
ddtrace 0.686 ms (0.29%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@emmettbutler
Copy link
Collaborator

force-merging because the relevant benchmarks were successfully removed from the gitlab list

@emmettbutler emmettbutler merged commit 9e55f54 into 4.0 Nov 14, 2025
611 of 638 checks passed
@emmettbutler emmettbutler deleted the backport-15279-to-4.0 branch November 14, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants