From b63526b3b54d92e9c2d4c338c22ab31fefb663ee Mon Sep 17 00:00:00 2001 From: Alberto Vara Date: Wed, 19 Nov 2025 14:01:27 +0100 Subject: [PATCH 1/2] ci(iast): fix benchmark tests, deprecated function --- ...-runner.microbenchmarks.fail-on-breach.yml | 32 +++++++++---------- benchmarks/appsec_iast_aspects/scenario.py | 1 - .../appsec_iast_aspects_ospath/scenario.py | 1 - .../appsec_iast_aspects_re_module/scenario.py | 1 - .../appsec_iast_aspects_split/scenario.py | 1 - .../appsec_iast_propagation/scenario.py | 1 - 6 files changed, 16 insertions(+), 21 deletions(-) diff --git a/.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml b/.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml index fcd07eb7871..e3fe407fe72 100644 --- a/.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml +++ b/.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml @@ -723,22 +723,22 @@ experiments: - max_rss_usage < 41.00 MB # iastpropagation - # - name: iastpropagation-no-propagation - # thresholds: - # - execution_time < 0.06 ms - # - max_rss_usage < 40.50 MB - # - name: iastpropagation-propagation_enabled - # thresholds: - # - execution_time < 0.19 ms - # - max_rss_usage < 40.00 MB - # - name: iastpropagation-propagation_enabled_100 - # thresholds: - # - execution_time < 2.30 ms - # - max_rss_usage < 40.00 MB - # - name: iastpropagation-propagation_enabled_1000 - # thresholds: - # - execution_time < 34.55 ms - # - max_rss_usage < 40.00 MB + - name: iastpropagation-no-propagation + thresholds: + - execution_time < 0.06 ms + - max_rss_usage < 40.50 MB + - name: iastpropagation-propagation_enabled + thresholds: + - execution_time < 0.19 ms + - max_rss_usage < 40.00 MB + - name: iastpropagation-propagation_enabled_100 + thresholds: + - execution_time < 2.30 ms + - max_rss_usage < 40.00 MB + - name: iastpropagation-propagation_enabled_1000 + thresholds: + - execution_time < 34.55 ms + - max_rss_usage < 40.00 MB # otelsdkspan - name: otelsdkspan-add-event diff --git a/benchmarks/appsec_iast_aspects/scenario.py b/benchmarks/appsec_iast_aspects/scenario.py index 976d37632ab..381380a3af7 100644 --- a/benchmarks/appsec_iast_aspects/scenario.py +++ b/benchmarks/appsec_iast_aspects/scenario.py @@ -39,7 +39,6 @@ def _start_iast_context_and_oce(): def _end_iast_context_and_oce(): end_iast_context() - # oce.release_request() @contextlib.contextmanager diff --git a/benchmarks/appsec_iast_aspects_ospath/scenario.py b/benchmarks/appsec_iast_aspects_ospath/scenario.py index e46adc5f292..3bbd52a2983 100644 --- a/benchmarks/appsec_iast_aspects_ospath/scenario.py +++ b/benchmarks/appsec_iast_aspects_ospath/scenario.py @@ -37,7 +37,6 @@ def _start_iast_context_and_oce(): def _end_iast_context_and_oce(): end_iast_context() - # oce.release_request() with override_env({"DD_IAST_ENABLED": "True"}): diff --git a/benchmarks/appsec_iast_aspects_re_module/scenario.py b/benchmarks/appsec_iast_aspects_re_module/scenario.py index 905a32ebf1b..487c42ee1ad 100644 --- a/benchmarks/appsec_iast_aspects_re_module/scenario.py +++ b/benchmarks/appsec_iast_aspects_re_module/scenario.py @@ -37,7 +37,6 @@ def _start_iast_context_and_oce(): def _end_iast_context_and_oce(): end_iast_context() - # oce.release_request() with override_env({"DD_IAST_ENABLED": "True"}): diff --git a/benchmarks/appsec_iast_aspects_split/scenario.py b/benchmarks/appsec_iast_aspects_split/scenario.py index 5dcb0a70912..bdeefa57fee 100644 --- a/benchmarks/appsec_iast_aspects_split/scenario.py +++ b/benchmarks/appsec_iast_aspects_split/scenario.py @@ -37,7 +37,6 @@ def _start_iast_context_and_oce(): def _end_iast_context_and_oce(): end_iast_context() - # oce.release_request() with override_env({"DD_IAST_ENABLED": "True"}): diff --git a/benchmarks/appsec_iast_propagation/scenario.py b/benchmarks/appsec_iast_propagation/scenario.py index e534339d7ac..6d40ad0c57b 100644 --- a/benchmarks/appsec_iast_propagation/scenario.py +++ b/benchmarks/appsec_iast_propagation/scenario.py @@ -48,7 +48,6 @@ def _start_iast_context_and_oce(): def _end_iast_context_and_oce(): end_iast_context() - oce.release_request() def normal_function(internal_loop, tainted): From fe05b5738633571c0aedb1a200d4056f78452b21 Mon Sep 17 00:00:00 2001 From: Alberto Vara Date: Wed, 19 Nov 2025 16:03:06 +0100 Subject: [PATCH 2/2] Update microbenchmarks.yml --- .gitlab/benchmarks/microbenchmarks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/benchmarks/microbenchmarks.yml b/.gitlab/benchmarks/microbenchmarks.yml index 89825c58e04..e99ff0069c2 100644 --- a/.gitlab/benchmarks/microbenchmarks.yml +++ b/.gitlab/benchmarks/microbenchmarks.yml @@ -163,8 +163,7 @@ microbenchmarks: # Flaky timeouts on starting up # - "appsec_iast_django_startup" # TOOD: Re-enable when this issue is resolved: - # AttributeError: 'OverheadControl' object has no attribute 'release_request' - # - "appsec_iast_propagation" + - "appsec_iast_propagation" - "errortracking_django_simple" # They take a long time to run and frequently time out # TODO: Make benchmarks faster, or run less frequently, or as macrobenchmarks