Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtoff /read me edits #2913

Merged
merged 27 commits into from
Oct 19, 2021
Merged

Mtoff /read me edits #2913

merged 27 commits into from
Oct 19, 2021

Conversation

mtoffl01
Copy link
Contributor

Description

I added "Setting up your environment" and "Testing locally" sections to the read me. "Setting up your environment" walks through installing python python and pyenv. "Testing locally" walks through installing riot, running tests, and running tests using the test agent.

@mtoffl01 mtoffl01 requested a review from a team as a code owner October 14, 2021 18:20
@mtoffl01 mtoffl01 added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 14, 2021
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, otherwise lgtm

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mtoffl01 and others added 5 commits October 14, 2021 15:17
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
…nto mtoff/ReadMe-edits

made changes within github as per suggestions on the pr, also made changes locally. want to merge
README.md Outdated Show resolved Hide resolved
mtoffl01 and others added 2 commits October 14, 2021 15:32
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
brettlangdon previously approved these changes Oct 14, 2021
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 nice job! Much needed docs for riot and the test agent! Just a few things I found

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small adjustments and I think we're good! 👍 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mtoffl01 and others added 2 commits October 18, 2021 11:27
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog
Kyle-Verhoog previously approved these changes Oct 18, 2021
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a small suggestion, otherwise LGTM! 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Kyle-Verhoog Kyle-Verhoog merged commit f7327c9 into master Oct 19, 2021
@Kyle-Verhoog Kyle-Verhoog deleted the mtoff/ReadMe-edits branch October 19, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants