-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtoff /read me edits #2913
Mtoff /read me edits #2913
Conversation
…ting for apm test agent section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, otherwise lgtm
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
…nto mtoff/ReadMe-edits made changes within github as per suggestions on the pr, also made changes locally. want to merge
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 nice job! Much needed docs for riot and the test agent! Just a few things I found
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small adjustments and I think we're good! 👍 👍
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a small suggestion, otherwise LGTM! 👍
Description
I added "Setting up your environment" and "Testing locally" sections to the read me. "Setting up your environment" walks through installing python python and pyenv. "Testing locally" walks through installing riot, running tests, and running tests using the test agent.