From 490d98b374e6e94b35d6c3bbfe0d03ed2a74136b Mon Sep 17 00:00:00 2001 From: Marco Costa Date: Thu, 13 Jul 2023 16:03:07 -0700 Subject: [PATCH 1/2] Internal:Fix environment variable for remote configuration polling interval --- lib/datadog/core/configuration/settings.rb | 3 ++- lib/datadog/core/remote/ext.rb | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/datadog/core/configuration/settings.rb b/lib/datadog/core/configuration/settings.rb index 3edffa85348..acd932a6f6f 100644 --- a/lib/datadog/core/configuration/settings.rb +++ b/lib/datadog/core/configuration/settings.rb @@ -541,8 +541,9 @@ def initialize(*_) # Tune remote configuration polling interval. # - # @default `DD_REMOTE_CONFIGURATION_POLL_INTERVAL_SECONDS` environment variable, otherwise `5.0` seconds. + # @default `DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS` environment variable, otherwise `5.0` seconds. # @return [Float] + # @!visibility private option :poll_interval_seconds do |o| o.default { env_to_float(Core::Remote::Ext::ENV_POLL_INTERVAL_SECONDS, 5.0) } end diff --git a/lib/datadog/core/remote/ext.rb b/lib/datadog/core/remote/ext.rb index 833aaec1362..a9bd38f744f 100644 --- a/lib/datadog/core/remote/ext.rb +++ b/lib/datadog/core/remote/ext.rb @@ -5,7 +5,7 @@ module Core module Remote module Ext ENV_ENABLED = 'DD_REMOTE_CONFIGURATION_ENABLED' - ENV_POLL_INTERVAL_SECONDS = 'DD_REMOTE_CONFIGURATION_POLL_INTERVAL_SECONDS' + ENV_POLL_INTERVAL_SECONDS = 'DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS' end end end From fe971f4b1cf6fcb0ee398cc945916553eac23e01 Mon Sep 17 00:00:00 2001 From: Marco Costa Date: Fri, 14 Jul 2023 14:15:50 -0700 Subject: [PATCH 2/2] Improve private language --- lib/datadog/core/configuration/settings.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/datadog/core/configuration/settings.rb b/lib/datadog/core/configuration/settings.rb index acd932a6f6f..b1eb701a0f5 100644 --- a/lib/datadog/core/configuration/settings.rb +++ b/lib/datadog/core/configuration/settings.rb @@ -540,6 +540,7 @@ def initialize(*_) end # Tune remote configuration polling interval. + # This is a private setting. Do not use outside of Datadog. It might change at any point in time. # # @default `DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS` environment variable, otherwise `5.0` seconds. # @return [Float]