Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about property metrics #18678

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds note about property metrics to instruct users on how to collect these

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

rahulkaukuntla
rahulkaukuntla previously approved these changes Sep 26, 2024
drichards-87
drichards-87 previously approved these changes Sep 26, 2024
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions from Docs and approved the PR.

vsphere/README.md Outdated Show resolved Hide resolved
vsphere/README.md Outdated Show resolved Hide resolved
vsphere/README.md Outdated Show resolved Hide resolved
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@sarah-witt sarah-witt merged commit 965ba2d into master Sep 26, 2024
39 checks passed
@sarah-witt sarah-witt deleted the sarah/add-note-readme-property branch September 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants