Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sy/elastic sc tags #18687

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Sy/elastic sc tags #18687

wants to merge 6 commits into from

Conversation

steveny91
Copy link
Contributor

What does this PR do?

The host tag should have been reserved since it's observed to create new hosts in the infra list. This change hopes to change that by removing it from the service checks. This will be opt in as to not break any backwards compatibility.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (d837ba9) to head (fbaff0a).
Report is 19 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
elastic 93.41% <100.00%> (+0.08%) ⬆️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 marked this pull request as ready for review September 27, 2024 11:38
Kyle-Neale
Kyle-Neale previously approved these changes Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants