-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new collect_default_jvm_metrics flag for JMXFetch integrations #8153
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
type: number | ||
|
||
- name: collect_default_jvm_metrics | ||
description: Allows disabling the collection of default JVM metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Allows disabling the collection of default JVM metrics | |
description: Enables the collection of default JVM metrics |
Small nit but feel like this wording would be more clear since it is disabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if this was not clear! Actually this defaults to true. Perhaps I should call that out in the doc?
For context - the existing behavior is to collect default JVM metrics but I wanted to add a flag to explicitly disable that.
I thought it may be misleading to have a disable_collect_default_jvm_metrics: true
because that logic feels backwards to me.
Is this option related to Lines 7 to 12 in b7221e2
|
Nope! This is a different behavior and it is specific to the instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment regarding defaults and clarity.
What does this PR do?
Added docs for
collect_default_jvm_metrics
. This flag allows users to disable default jvm metrics in JMXFetchRelated PRs:
DataDog/datadog-agent#6923
DataDog/jmxfetch#345
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached