From e966b1982300f65b8fa9d9adc7e4f1eba60daaa8 Mon Sep 17 00:00:00 2001
From: Bob Weinand <bob.weinand@datadoghq.com>
Date: Tue, 27 Aug 2024 15:42:21 +0200
Subject: [PATCH] Fix accidental blocking socket in crashtracking

Rust stdlib UnixListener is not async by default unlike the tokio one. It did apparently not fail during manual testing, but CI showed it sometimes failing.

Explicitly making it set_nonblocking(true).

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
---
 crashtracker/src/receiver.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/crashtracker/src/receiver.rs b/crashtracker/src/receiver.rs
index d2f9ea3a8..d0ee0deca 100644
--- a/crashtracker/src/receiver.rs
+++ b/crashtracker/src/receiver.rs
@@ -41,7 +41,12 @@ pub fn get_unix_socket(socket_path: impl AsRef<str>) -> anyhow::Result<UnixListe
         use std::os::linux::net::SocketAddrExt;
         std::os::unix::net::SocketAddr::from_abstract_name(socket_path.as_ref())
             .and_then(|addr| {
-                std::os::unix::net::UnixListener::bind_addr(&addr).and_then(UnixListener::from_std)
+                std::os::unix::net::UnixListener::bind_addr(&addr)
+                    .and_then(|listener| {
+                        listener.set_nonblocking(true)?;
+                        Ok(listener)
+                    })
+                    .and_then(UnixListener::from_std)
             })
             .map_err(anyhow::Error::msg)
     };