Skip to content

fix(config): add service env field back #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

fix(config): add service env field back #1237

merged 1 commit into from
Sep 24, 2025

Conversation

@dmehala
Copy link
Contributor

@dmehala dmehala commented Sep 23, 2025

Description

0cc3f7 introduced a regression where service env could not be set. This commit re-introduce the service env field.

@dmehala dmehala requested a review from a team as a code owner September 23, 2025 15:26
@dmehala
fix: add service env field back
14047bd 
`0cc3f7` introduced a regression where service env could not be set.
This commit re-introduce the service env field.
@dmehala dmehala force-pushed the dmehala/config-memfd-add-env-field branch from 750e64d to 14047bd Compare September 23, 2025 15:27
@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-09-23 15:39:13

Comparing candidate commit 14047bd in PR branch dmehala/config-memfd-add-env-field with baseline commit 0cc3f7f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.993ms 61.457ms ± 2.097ms 61.208ms ± 0.048ms 61.257ms 61.358ms 71.240ms 81.267ms 32.77% 8.711 76.276 3.40% 0.148ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.166ms; 61.747ms] or [-0.473%; +0.473%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.855µs 534.872µs ± 0.913µs 534.639µs ± 0.345µs 535.016µs 536.988µs 538.665µs 539.095µs 0.83% 2.296 5.872 0.17% 0.065µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1854960.831op/s 1869612.361op/s ± 3180.246op/s 1870420.255op/s ± 1206.722op/s 1871552.284op/s 1872486.201op/s 1872934.162op/s 1873167.601op/s 0.15% -2.283 5.797 0.17% 224.877op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.952µs 380.669µs ± 0.332µs 380.636µs ± 0.195µs 380.825µs 381.264µs 381.709µs 381.793µs 0.30% 0.872 1.025 0.09% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2619220.363op/s 2626959.322op/s ± 2289.054op/s 2627183.975op/s ± 1346.365op/s 2628573.007op/s 2629867.999op/s 2631095.699op/s 2631910.496op/s 0.18% -0.866 1.010 0.09% 161.861op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.251µs 190.547µs ± 0.185µs 190.529µs ± 0.105µs 190.639µs 190.850µs 190.983µs 191.752µs 0.64% 1.964 9.346 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5215078.530op/s 5248047.084op/s ± 5077.292op/s 5248532.127op/s ± 2880.073op/s 5251073.341op/s 5254932.578op/s 5256031.319op/s 5256212.034op/s 0.15% -1.943 9.183 0.10% 359.019op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.869µs 37.061µs ± 0.118µs 37.045µs ± 0.104µs 37.168µs 37.241µs 37.300µs 37.323µs 0.75% 0.205 -1.297 0.32% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26793223.143op/s 26982590.300op/s ± 85831.560op/s 26994517.735op/s ± 75628.449op/s 27063871.972op/s 27091631.955op/s 27116536.783op/s 27123282.338op/s 0.48% -0.199 -1.302 0.32% 6069.208op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.011µs 46.136µs ± 0.189µs 46.109µs ± 0.031µs 46.146µs 46.226µs 46.317µs 48.299µs 4.75% 9.421 96.822 0.41% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20704230.161op/s 21675399.041op/s ± 85729.032op/s 21687717.405op/s ± 14533.257op/s 21700081.330op/s 21714529.340op/s 21720628.376op/s 21734099.021op/s 0.21% -9.299 94.673 0.39% 6061.958op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.745µs; 534.998µs] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869171.609op/s; 1870053.112op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.623µs; 380.715µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2626642.081op/s; 2627276.563op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.522µs; 190.573µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5247343.420op/s; 5248750.748op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.045µs; 37.078µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26970694.872op/s; 26994485.729op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.110µs; 46.162µs] or [-0.057%; +0.057%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21663517.821op/s; 21687280.260op/s] or [-0.055%; +0.055%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.103µs 89.284µs ± 0.191µs 89.254µs ± 0.053µs 89.318µs 89.431µs 89.552µs 91.651µs 2.68% 9.674 115.923 0.21% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.257µs; 89.310µs] or [-0.030%; +0.030%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.345ms 14.414ms ± 0.035ms 14.410ms ± 0.018ms 14.429ms 14.466ms 14.547ms 14.608ms 1.37% 1.916 6.860 0.25% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.409ms; 14.419ms] or [-0.034%; +0.034%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 156.696µs 157.841µs ± 0.427µs 157.767µs ± 0.174µs 157.981µs 158.424µs 158.737µs 161.612µs 2.44% 3.661 29.819 0.27% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [157.782µs; 157.900µs] or [-0.037%; +0.037%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.955µs 5.030µs ± 0.040µs 5.031µs ± 0.037µs 5.055µs 5.100µs 5.103µs 5.108µs 1.52% 0.095 -0.983 0.80% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.024µs; 5.036µs] or [-0.111%; +0.111%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.198µs 3.225µs ± 1.423µs 3.007µs ± 0.026µs 3.036µs 3.680µs 13.950µs 14.896µs 395.38% 7.317 54.816 44.01% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.028µs; 3.422µs] or [-6.114%; +6.114%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.260ms 6.311ms ± 0.032ms 6.303ms ± 0.017ms 6.324ms 6.362ms 6.421ms 6.465ms 2.56% 1.564 3.825 0.51% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.306ms; 6.315ms] or [-0.070%; +0.070%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.393µs 185.936µs ± 0.462µs 185.856µs ± 0.175µs 186.026µs 186.625µs 187.836µs 188.191µs 1.26% 2.980 9.849 0.25% 0.033µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5313743.333op/s 5378214.797op/s ± 13257.791op/s 5380518.695op/s ± 5070.653op/s 5385622.341op/s 5389295.418op/s 5392445.617op/s 5393933.820op/s 0.25% -2.958 9.732 0.25% 937.467op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.893µs 17.984µs ± 0.044µs 17.983µs ± 0.030µs 18.012µs 18.068µs 18.092µs 18.103µs 0.67% 0.306 -0.216 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55240591.344op/s 55604591.597op/s ± 137213.468op/s 55609373.672op/s ± 92423.390op/s 55708148.306op/s 55828294.514op/s 55881428.555op/s 55889299.735op/s 0.50% -0.293 -0.226 0.25% 9702.457op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.360µs 10.468µs ± 0.045µs 10.468µs ± 0.028µs 10.494µs 10.546µs 10.578µs 10.612µs 1.38% 0.244 0.021 0.43% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 94228840.450op/s 95531892.943op/s ± 413784.478op/s 95527227.141op/s ± 258144.000op/s 95820519.456op/s 96224226.991op/s 96344259.750op/s 96527284.680op/s 1.05% -0.219 -0.004 0.43% 29258.981op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.872µs; 186.000µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5376377.395op/s; 5380052.199op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.978µs; 17.990µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55585575.130op/s; 55623608.064op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.462µs; 10.474µs] or [-0.060%; +0.060%] None None None
normalization/normalize_name/normalize_name/good throughput [95474546.394op/s; 95589239.492op/s] or [-0.060%; +0.060%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.941µs 34.371µs ± 0.705µs 34.069µs ± 0.032µs 34.116µs 35.719µs 35.918µs 38.968µs 14.38% 2.522 8.462 2.05% 0.050µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.273µs; 34.469µs] or [-0.284%; +0.284%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.665µs 26.192µs ± 10.423µs 18.215µs ± 0.434µs 35.481µs 45.329µs 53.740µs 56.395µs 209.60% 0.816 -0.660 39.69% 0.737µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.747µs; 27.636µs] or [-5.515%; +5.515%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.411µs 2.440µs ± 0.022µs 2.435µs ± 0.006µs 2.442µs 2.492µs 2.503µs 2.612µs 7.24% 3.625 20.690 0.88% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.437µs; 2.443µs] or [-0.123%; +0.123%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.916µs 3.918µs 0.19% -2.204 13.938 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255209360.005op/s 255684472.812op/s ± 194284.948op/s 255692214.180op/s ± 109661.635op/s 255787607.256op/s 255902190.880op/s 256015036.320op/s 256911982.276op/s 0.48% 2.230 14.119 0.08% 13738.020op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.592µs 78.820µs ± 0.461µs 78.813µs ± 0.314µs 79.131µs 79.508µs 79.895µs 80.745µs 2.45% 0.464 1.271 0.58% 0.033µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12384696.540op/s 12687550.562op/s ± 74030.264op/s 12688250.141op/s ± 50429.399op/s 12736934.051op/s 12797398.515op/s 12844535.099op/s 12887949.948op/s 1.57% -0.411 1.139 0.58% 5234.730op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.804µs 71.299µs ± 0.291µs 71.250µs ± 0.182µs 71.461µs 71.839µs 72.155µs 72.335µs 1.52% 0.707 0.486 0.41% 0.021µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13824621.828op/s 14025671.596op/s ± 57072.549op/s 14035019.270op/s ± 35806.794op/s 14065244.083op/s 14110800.056op/s 14119178.751op/s 14123589.219op/s 0.63% -0.683 0.428 0.41% 4035.639op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.919µs 3.919µs 0.21% -0.732 7.439 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255137053.816op/s 255665121.102op/s ± 194602.526op/s 255685334.981op/s ± 98574.584op/s 255773107.250op/s 255923562.887op/s 255956355.243op/s 256907246.835op/s 0.48% 0.753 7.565 0.08% 13760.477op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.887µs 68.590µs ± 0.324µs 68.577µs ± 0.180µs 68.736µs 69.060µs 69.360µs 70.521µs 2.83% 1.454 6.357 0.47% 0.023µs 1 200
credit_card/is_card_number/378282246310005 throughput 14180108.552op/s 14579690.696op/s ± 68393.163op/s 14582050.954op/s ± 38254.374op/s 14621945.350op/s 14677388.479op/s 14712545.487op/s 14730402.360op/s 1.02% -1.368 5.835 0.47% 4836.127op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.931µs 44.980µs ± 0.027µs 44.977µs ± 0.016µs 44.993µs 45.028µs 45.061µs 45.121µs 0.32% 1.195 3.211 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22162547.878op/s 22231933.596op/s ± 13509.580op/s 22233551.696op/s ± 8020.173op/s 22241510.388op/s 22249467.011op/s 22254679.480op/s 22256341.960op/s 0.10% -1.188 3.177 0.06% 955.272op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.690µs 5.698µs ± 0.007µs 5.697µs ± 0.002µs 5.700µs 5.708µs 5.713µs 5.766µs 1.21% 5.931 56.502 0.11% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 173435884.378op/s 175496763.776op/s ± 199529.116op/s 175541799.117op/s ± 68878.013op/s 175590566.398op/s 175666618.052op/s 175733709.805op/s 175758569.381op/s 0.12% -5.852 55.359 0.11% 14108.839op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.891µs 3.910µs ± 0.003µs 3.910µs ± 0.001µs 3.911µs 3.915µs 3.917µs 3.918µs 0.20% -1.075 11.802 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255258290.855op/s 255748667.323op/s ± 179280.948op/s 255767645.395op/s ± 84535.657op/s 255850543.277op/s 255950642.333op/s 256051688.568op/s 257017414.387op/s 0.49% 1.102 11.991 0.07% 12677.077op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.016µs 64.508µs ± 0.102µs 64.523µs ± 0.035µs 64.555µs 64.615µs 64.627µs 64.665µs 0.22% -3.101 11.455 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15464396.320op/s 15501883.905op/s ± 24554.815op/s 15498458.678op/s ± 8342.605op/s 15507199.607op/s 15520863.379op/s 15611514.361op/s 15621108.895op/s 0.79% 3.119 11.547 0.16% 1736.288op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.404µs 53.741µs ± 0.110µs 53.751µs ± 0.069µs 53.817µs 53.907µs 53.946µs 54.015µs 0.49% -0.461 0.234 0.20% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18513271.442op/s 18607970.862op/s ± 37978.503op/s 18604210.649op/s ± 23902.729op/s 18629648.908op/s 18680507.358op/s 18708109.112op/s 18725279.127op/s 0.65% 0.473 0.250 0.20% 2685.486op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.911µs ± 0.003µs 3.910µs ± 0.001µs 3.912µs 3.915µs 3.919µs 3.920µs 0.24% -0.495 8.680 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255117662.300op/s 255699472.641op/s ± 179339.258op/s 255728089.263op/s ± 82371.454op/s 255797915.247op/s 255898433.892op/s 255989468.663op/s 256856889.041op/s 0.44% 0.517 8.800 0.07% 12681.201op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.834µs 50.174µs ± 0.167µs 50.177µs ± 0.118µs 50.284µs 50.435µs 50.550µs 50.719µs 1.08% 0.223 -0.170 0.33% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19716348.777op/s 19930939.601op/s ± 66124.926op/s 19929623.545op/s ± 46894.856op/s 19982633.094op/s 20029645.880op/s 20062571.051op/s 20066441.996op/s 0.69% -0.206 -0.198 0.33% 4675.738op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.934µs 44.991µs ± 0.055µs 44.977µs ± 0.021µs 45.005µs 45.056µs 45.241µs 45.395µs 0.93% 3.837 21.025 0.12% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22028770.760op/s 22226727.450op/s ± 27096.801op/s 22233743.445op/s ± 10586.783op/s 22241642.379op/s 22250038.985op/s 22252904.531op/s 22254751.639op/s 0.09% -3.806 20.736 0.12% 1916.033op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.691µs 5.698µs ± 0.004µs 5.698µs ± 0.002µs 5.700µs 5.705µs 5.707µs 5.708µs 0.19% 0.545 0.155 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 175183530.951op/s 175505869.470op/s ± 109813.003op/s 175514541.381op/s ± 68868.378op/s 175580560.751op/s 175675533.236op/s 175714192.967op/s 175725790.068op/s 0.12% -0.542 0.150 0.06% 7764.952op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.911µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255657546.787op/s; 255711398.837op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.756µs; 78.884µs] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12677290.680op/s; 12697810.445op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.259µs; 71.339µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14017761.890op/s; 14033581.303op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255638151.063op/s; 255692091.140op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.545µs; 68.635µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/378282246310005 throughput [14570212.061op/s; 14589169.330op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [44.977µs; 44.984µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22230061.298op/s; 22233805.894op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.697µs; 5.699µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/x371413321323331 throughput [175469110.960op/s; 175524416.593op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.910µs; 3.910µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255723820.708op/s; 255773513.938op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.494µs; 64.523µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15498480.843op/s; 15505286.966op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.725µs; 53.756µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18602707.407op/s; 18613234.317op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.910µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255674617.944op/s; 255724327.337op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.151µs; 50.197µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19921775.322op/s; 19940103.880op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [44.983µs; 44.999µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22222972.094op/s; 22230482.806op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.697µs; 5.698µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [175490650.444op/s; 175521088.496op/s] or [-0.009%; +0.009%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 247.966ns 255.275ns ± 11.447ns 250.920ns ± 1.696ns 254.065ns 286.027ns 299.157ns 303.944ns 21.13% 2.622 6.091 4.47% 0.809ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.689ns; 256.861ns] or [-0.621%; +0.621%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 14047bd 1758641237 dmehala/config-memfd-add-env-field
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.180ms 8.199ms ± 0.010ms 8.197ms ± 0.006ms 8.204ms 8.218ms 8.227ms 8.244ms 0.57% 1.094 2.181 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.197ms; 8.200ms] or [-0.017%; +0.017%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.66%. Comparing base (0cc3f7f) to head (14047bd).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   71.69%   71.66%   -0.03%     
==========================================
  Files         354      354              
  Lines       56138    56139       +1     
==========================================
- Hits        40247    40232      -15     
- Misses      15891    15907      +16
Components Coverage Δ
datadog-crashtracker 49.30% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.30% <ø> (ø)
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.29% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.98% <ø> (-0.04%) ⬇️
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (ø)
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.08% <ø> (ø)
datdog-sidecar-ffi 11.37% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.75% <ø> (ø)
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmehala
Copy link
Contributor Author

dmehala commented Sep 24, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 24, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-24 14:33:16 UTC ℹ️ Start processing command /merge

2025-09-24 14:33:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).

2025-09-24 14:54:59 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f61c42a into main Sep 24, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dmehala/config-memfd-add-env-field branch September 24, 2025 14:54
@morrisonlevi morrisonlevi changed the title fix: add service env field back fix(config): add service env field back Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paullegranddc paullegranddc paullegranddc approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmehala @codecov-commenter @paullegranddc