Allow submitting Vec<Vec<Span>> asynchronously
#1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
force-pushed
the
bengl/async-vec-vec-span
branch
from
27f0ac3 to
6f00810
Compare
BenchmarksComparisonBenchmark execution time: 2025-11-17 21:59:42 Comparing candidate commit 699b3a0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 699b3a0 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
=======================================
Coverage 70.97% 70.98%
=======================================
Files 390 390
Lines 62586 62593 +7
=======================================
+ Hits 44419 44430 +11
+ Misses 18167 18163 -4
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
bengl
force-pushed
the
bengl/async-vec-vec-span
branch
from
6f00810 to
3e4c8ac
Compare
ekump
reviewed
Nov 4, 2025
| #[no_mangle] | ||
| pub extern "C" fn ddog_set_span_trace_id(span: &mut SpanBytes, value: u64) { | ||
| span.trace_id = value; | ||
| span.trace_id = value as u128; |
Contributor
There was a problem hiding this comment.
What is the benefit of making trace_id u128 internally if we can only accept u64 as input?
Contributor
There was a problem hiding this comment.
protocol v1 will be u128, so it will happen sooner or later.
ekump
reviewed
Nov 4, 2025
datadog-sidecar/src/unix.rs
Outdated
| #[cfg(target_os = "linux")] | ||
| if let Err(e) = init_crashtracker(trampoline_data.dependency_paths) { | ||
| warn!("Failed to initialize crashtracker: {e}"); | ||
| tracing::warn!("Failed to initialize crashtracker: {e}"); |
Contributor
There was a problem hiding this comment.
style nit: why not include warn in the import on line 23?
VianneyRuhlmann
approved these changes
Nov 6, 2025
| (*index).try_into() | ||
| pub fn get_or_insert(&mut self, s: T) -> Result<u32, std::num::TryFromIntError> { | ||
| if let Some(index) = self.map.get_index_of(s.borrow()) { | ||
| (index).try_into() |
Contributor
There was a problem hiding this comment.
Suggested change
| (index).try_into() | |
| index.try_into() |
| .block_on(async { self.send_trace_chunks_inner(trace_chunks).await }) | ||
| } | ||
|
|
||
| pub async fn send_trace_chunks_async<T: SpanText>( |
Contributor
There was a problem hiding this comment.
We try to keep all public functions documented with rustdoc
bengl
force-pushed
the
bengl/async-vec-vec-span
branch
from
3e4c8ac to
326e055
Compare
bengl
force-pushed
the
bengl/async-vec-vec-span
branch
from
326e055 to
699b3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Title says it all
Motivation
I want to be able to use https://napi.rs's ability to work with tokio directly, rather than just blocking.
Additional notes
This is currently rebased on top of #1266, and should be re-re-based once that's merged.