-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding metadata aliases for widgets in screenboards and timeboards #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two quick questions 😄 Overall looks great though, will give it a test later today 🚀
@@ -26,6 +26,11 @@ resource "datadog_timeboard" "redis" { | |||
request { | |||
q = "avg:redis.info.latency_ms{$host}" | |||
type = "bars" | |||
metadata_json = jsonencode({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to make this example work locally. Are you running TF 0.12? Is it possible there is a difference in syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I notice the way you call functions seems to be different between 0.11 and 0.12
I also see jsonencode called out in the 0.12 changelog, is this going to be breaking - https://github.com/hashicorp/terraform/releases
UPDATE: I kept trying to get the syntax right for this but haven't been able to make it work on Terraform v0.11.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll look into this and update the docs when I figure out how to make this work on TF < 0.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I figured out the way to do it and amended the documentation. Please give it a go. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this 🚀
Thanks for your review! I'm merging it. |
…lias Allow adding metadata aliases for widgets in screenboards and timeboards
Fixes #61