Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding metadata aliases for widgets in screenboards and timeboards #215

Merged
merged 1 commit into from
May 23, 2019
Merged

Allow adding metadata aliases for widgets in screenboards and timeboards #215

merged 1 commit into from
May 23, 2019

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented May 22, 2019

Fixes #61

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two quick questions 😄 Overall looks great though, will give it a test later today 🚀

@@ -26,6 +26,11 @@ resource "datadog_timeboard" "redis" {
request {
q = "avg:redis.info.latency_ms{$host}"
type = "bars"
metadata_json = jsonencode({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to make this example work locally. Are you running TF 0.12? Is it possible there is a difference in syntax?

Copy link
Contributor

@nmuesch nmuesch May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I notice the way you call functions seems to be different between 0.11 and 0.12
I also see jsonencode called out in the 0.12 changelog, is this going to be breaking - https://github.com/hashicorp/terraform/releases

UPDATE: I kept trying to get the syntax right for this but haven't been able to make it work on Terraform v0.11.10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll look into this and update the docs when I figure out how to make this work on TF < 0.12.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I figured out the way to do it and amended the documentation. Please give it a go. Thanks!

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this 🚀

@bkabrda
Copy link
Contributor Author

bkabrda commented May 23, 2019

Thanks for your review! I'm merging it.

@bkabrda bkabrda merged commit e542bfa into DataDog:master May 23, 2019
jbenais pushed a commit to jbenais/terraform-provider-datadog that referenced this pull request Aug 20, 2019
…lias

Allow adding metadata aliases for widgets in screenboards and timeboards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog Timeboard: Metadata key
2 participants