Mention units explicitly #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
All of the parameters are in seconds: https://docs.datadoghq.com/api/?lang=python#create-a-test. There can be some confusion because some datadog docs say its in minutes e.g. in https://docs.datadoghq.com/synthetics/api_tests/?tab=httptest#alert-conditions it is mentioned: ``` At least one location was in failure (at least one assertion failed) during the last X minutes, ``` Also, one of the parameters is called `min_failure_duration`, which caused some confusion whether the `min` referred to minimum or minutes : ). Specify the units explicilty, and save others from being confused like we were.
nmuesch
approved these changes
Jun 13, 2019
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the parameters are in seconds: https://docs.datadoghq.com/api/?lang=python#create-a-test.
There can be some confusion because some datadog docs say its in
minutes e.g. in https://docs.datadoghq.com/synthetics/api_tests/?tab=httptest#alert-conditions
it is mentioned:
Also, one of the parameters is called
min_failure_duration,which caused some confusion whether the
minreferred tominimum or minutes : ).
Specify the units explicilty, and save others from being confused
like we were.