Update changelog #240
Merged
Update changelog #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
bkabrda
suggested changes
Jun 18, 2019
There was a problem hiding this comment.
Good job compiling all of these. I've left some comments inline and also have 2 general comments:
- For links to PRs, you should be using format
[GH-XXX]as described in [1]. - You should be using category names required by hashicorp automation [2] (I don't see
DOCSorINTERNALthere).
[1] https://www.terraform.io/docs/extend/best-practices/versioning.html#entry-format
[2] https://www.terraform.io/docs/extend/best-practices/versioning.html#categorization
CHANGELOG.md
Outdated
|
|
||
|
|
||
| INTERNAL: | ||
| * `datadog_monitor`: Start deprecating the silence attribute, support `-1` to unmute a scope, and get fix spruious diffs. ([#221](https://github.com/terraform-providers/terraform-provider-datadog/issues/221)) |
CHANGELOG.md
Outdated
|
|
||
| IMPROVEMENTS: | ||
| * `datadog_monitor`: Use ForceNew when changing the Monitor type ([#236](https://github.com/terraform-providers/terraform-provider-datadog/issues/236)) | ||
| * Update the vendored go client to `v2.21.0`. ([#230](https://github.com/terraform-providers/terraform-provider-datadog/issues/230)) |
There was a problem hiding this comment.
I'd propose moving this to bottom, as it's something that's transparent to users of the provider (least important from my POV)
CHANGELOG.md
Outdated
| * `datadog_monitor`: Start deprecating the silence attribute, support `-1` to unmute a scope, and get fix spruious diffs. ([#221](https://github.com/terraform-providers/terraform-provider-datadog/issues/221)) | ||
| * Fix up the GCP and User acceptance tests ([#238](https://github.com/terraform-providers/terraform-provider-datadog/issues/238)) | ||
| * Fix up the `datadog_downtime` and `datadog_monitor` acceptance tests. ([#234](https://github.com/terraform-providers/terraform-provider-datadog/issues/234)) | ||
| * Cleanup go mod. ([#227](https://github.com/terraform-providers/terraform-provider-datadog/issues/227)) |
There was a problem hiding this comment.
IMO this is not important at all for end users and I'd just leave it out of the changelog.
CHANGELOG.md
Outdated
|
|
||
| INTERNAL: | ||
| * `datadog_monitor`: Start deprecating the silence attribute, support `-1` to unmute a scope, and get fix spruious diffs. ([#221](https://github.com/terraform-providers/terraform-provider-datadog/issues/221)) | ||
| * Fix up the GCP and User acceptance tests ([#238](https://github.com/terraform-providers/terraform-provider-datadog/issues/238)) |
There was a problem hiding this comment.
I think changes in the test suite are unimportant to end users and I'd leave all of these entries out.
CHANGELOG.md
Outdated
| * `datadog_timebaord`: Add example on constructing dynamic timebaords. **NOTE** only supported with Terraform >= 0.12 ([#232](https://github.com/terraform-providers/terraform-provider-datadog/issues/232)) | ||
| * `datadog_monitor`: Add example section for monitors configurations. ([#220](https://github.com/terraform-providers/terraform-provider-datadog/issues/220)) | ||
| * `datadog_monitor`: Add link to the mapping of monitor types. ([#213](https://github.com/terraform-providers/terraform-provider-datadog/issues/213)) | ||
| * `datadog_monitor`: Add clarify about API path not ending in `/api`. ([#207](https://github.com/terraform-providers/terraform-provider-datadog/issues/207)) |
CHANGELOG.md
Outdated
| DOCS: | ||
| * `datadog_monitor`: Add an example of an anomaly monitor ([#239](https://github.com/terraform-providers/terraform-provider-datadog/issues/239)) | ||
| * `datadog_monitor`: Clarify the units being used for `tick_every` and `min_failure_duration`. ([#233](https://github.com/terraform-providers/terraform-provider-datadog/issues/233)) Thanks [pratikmallya](https://github.com/pratikmallya) | ||
| * `datadog_timebaord`: Add example on constructing dynamic timebaords. **NOTE** only supported with Terraform >= 0.12 ([#232](https://github.com/terraform-providers/terraform-provider-datadog/issues/232)) |
CHANGELOG.md
Outdated
| IMPROVEMENTS: | ||
| * `datadog_monitor`: Use ForceNew when changing the Monitor type ([#236](https://github.com/terraform-providers/terraform-provider-datadog/issues/236)) | ||
| * Update the vendored go client to `v2.21.0`. ([#230](https://github.com/terraform-providers/terraform-provider-datadog/issues/230)) | ||
| * `datadog_synthetics_test`: Support syntetics monitors in composite monitors. ([#222](https://github.com/terraform-providers/terraform-provider-datadog/issues/222)) |
There was a problem hiding this comment.
Typo: synthetics (you're missing the h)
|
Thanks for the review. Mostly I was just following the existing changelog format. We need tooling around this 😄 |
jbenais
pushed a commit
to jbenais/terraform-provider-datadog
that referenced
this pull request
Aug 20, 2019
* Update changelog * Address review * Fix links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the changelog ready for the 2.0.0 release
I think I got everything, and tried to give credit in the changelog for external contributions.