Skip to content

Update Row Grouping example to use 2D arrays #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

kthorngren
Copy link
Contributor

The Row Grouping example uses 1D arrays with the order() API which breaks the use of var currentOrder = table.order()[0];. This change is to use the 2D array data structure, that is consistent with the order option and clicking a column header to sort, in the event handler. This is to fix the issue found in this thread.

This contribution follows the project's existing license (MIT).

@AllanJard AllanJard merged commit f698fe2 into DataTables:master Apr 3, 2025
@AllanJard
Copy link
Contributor

Nice one - thank you. It should be that the return from order() is consistent regardless of the input. That has actually been fixed for 2.3, but yup, I'm quite happy that the example reflects this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants