Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix tenable #11102 #11103

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

manuel-sommer
Copy link
Contributor

Copy link

dryrunsecurity bot commented Oct 21, 2024

DryRun Security Summary

The pull request focuses on improving the functionality and accuracy of the Tenable CSV report parser, including adding a new test case to verify the parsing of a Tenable scan report for a specific issue related to the use of medium-strength SSL/TLS cipher suites, updating the get_findings function to handle the parsing of the "Steps to Remediate" field and improve the logic for converting severity values, and potential improvements to the handling of CVE and CPE values associated with the findings.

Expand for full summary

Summary:

The code changes in this pull request are focused on improving the functionality and accuracy of the Tenable CSV report parser, which is an important component of the application security toolchain. The changes include:

  1. Adding a new test case to verify the parsing of a Tenable scan report for a specific issue (issue Tenable report field name change #11102) related to the use of medium-strength SSL/TLS cipher suites. This is a security-relevant finding, as the use of medium-strength ciphers can potentially lead to cryptographic attacks or brute-force attacks.

  2. Updating the get_findings function in the TenableCSVParser class to handle the parsing of the "Steps to Remediate" field for findings, and improving the logic for converting severity values.

  3. Potential improvements to the handling of CVE and CPE values associated with the findings, to ensure the extracted information is accurate and reliable.

Overall, the changes appear to be focused on enhancing the security-related functionality of the Tenable CSV report parser, which is a positive step from an application security perspective.

Files Changed:

  1. unittests/tools/test_tenable_parser.py: This file has been updated to include a new test case, test_parse_issue_11102, which verifies the parsing of a Tenable scan report for a specific issue related to the use of medium-strength SSL/TLS cipher suites.

  2. unittests/scans/tenable/issue_11102.csv: This file contains the Tenable scan report data for the issue Tenable report field name change #11102, which is used in the new test case.

  3. dojo/tools/tenable/csv_format.py: This file has been updated to improve the handling of the "Steps to Remediate" field and the severity conversion logic in the TenableCSVParser class.

Code Analysis

We ran 9 analyzers against 3 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit a75d562 into DefectDojo:bugfix Oct 26, 2024
73 checks passed
@manuel-sommer manuel-sommer deleted the fix_tenable_11102 branch October 27, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants