Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIRA Finding Groups: Accommodate status function inconsistency #11125

Merged
merged 2 commits into from
Oct 27, 2024
Merged

JIRA Finding Groups: Accommodate status function inconsistency #11125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d999f51
JIRA Finding Groups: Accommodate status function inconsistency
Maffooch Oct 24, 2024
58fe271
Fix ruff
Maffooch Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dojo/jira_link/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,13 @@ def can_be_pushed_to_jira(obj, form=None):
elif isinstance(obj, Finding_Group):
if not obj.findings.all():
return False, f"{to_str_typed(obj)} cannot be pushed to jira as it is empty.", "error_empty"
if "Active" not in obj.status():
# Accommodating a strange behavior where a finding group sometimes prefers `obj.status` rather than `obj.status()`
try:
not_active = "Active" not in obj.status()
except TypeError: # TypeError: 'str' object is not callable
not_active = "Active" not in obj.status
# Determine if the finding group is not active
if not_active:
return False, f"{to_str_typed(obj)} cannot be pushed to jira as it is not active.", "error_inactive"

else:
Expand Down
Loading