-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unittest documentation #11128 #11143
Conversation
DryRun Security SummaryThe provided text summarizes an update to the documentation for writing a parser for the DefectDojo application, including changes to the development environment setup, guidance on running unit tests, expanded information on the "Factory contract" and best practices for secure parser development. Expand for full summarySummary: This code change appears to be an update to the documentation for how to write a parser for the DefectDojo application. The key changes include updates to the development environment setup instructions, additional guidance on running unit tests for specific parsers, and expanded documentation on the "Factory contract" that parsers must follow, including required methods and class naming conventions. The documentation also provides best practices for parser development, such as using secure libraries for parsing input data, handling missing data gracefully, leveraging pre-defined deduplication algorithms, and ensuring comprehensive unit tests are written. From an application security perspective, these changes are positive as they emphasize secure coding practices and help to maintain a consistent and secure design across the different parsers in the application. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny suggestions on the examples
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
@kiblik Last call before we merge this |
No description provided.