Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unittest documentation #11128 #11143

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

manuel-sommer
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the docs label Oct 28, 2024
Copy link

dryrunsecurity bot commented Oct 28, 2024

DryRun Security Summary

The provided text summarizes an update to the documentation for writing a parser for the DefectDojo application, including changes to the development environment setup, guidance on running unit tests, expanded information on the "Factory contract" and best practices for secure parser development.

Expand for full summary

Summary:

This code change appears to be an update to the documentation for how to write a parser for the DefectDojo application. The key changes include updates to the development environment setup instructions, additional guidance on running unit tests for specific parsers, and expanded documentation on the "Factory contract" that parsers must follow, including required methods and class naming conventions. The documentation also provides best practices for parser development, such as using secure libraries for parsing input data, handling missing data gracefully, leveraging pre-defined deduplication algorithms, and ensuring comprehensive unit tests are written. From an application security perspective, these changes are positive as they emphasize secure coding practices and help to maintain a consistent and secure design across the different parsers in the application.

Files Changed:

  • docs/content/en/contributing/how-to-write-a-parser.md: This file has been updated to provide more detailed and comprehensive documentation for developers on how to write a parser for the DefectDojo application. The changes include updates to the development environment setup instructions, new guidance on running unit tests, expanded information on the "Factory contract" and best practices for parser development, and additional details on other files that may need to be updated to support new file types or parser functionality.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@manuel-sommer manuel-sommer requested a review from kiblik October 28, 2024 13:05
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny suggestions on the examples

docs/content/en/contributing/how-to-write-a-parser.md Outdated Show resolved Hide resolved
docs/content/en/contributing/how-to-write-a-parser.md Outdated Show resolved Hide resolved
manuel-sommer and others added 2 commits October 28, 2024 21:36
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
@manuel-sommer manuel-sommer requested a review from cneill October 28, 2024 20:37
@mtesauro
Copy link
Contributor

mtesauro commented Nov 1, 2024

@kiblik Last call before we merge this

@mtesauro mtesauro merged commit 8a08e60 into DefectDojo:bugfix Nov 2, 2024
73 checks passed
@manuel-sommer manuel-sommer deleted the update_doc_unittest branch November 2, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants