-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS Docs Overhaul - theming change, many new articles #11258
Conversation
…ticle 'about_docs'
DryRun Security SummaryThe changes in this pull request focus on updating the project's Expand for full summarySummary: The changes in this pull request are primarily focused on updating the project's The Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Is it possible to increase the versions of Hugo and Node? django-DefectDojo/.github/workflows/gh-pages.yml Lines 17 to 26 in 090b2c7
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Note for maintainers: This will need to be adjusted as well https://github.com/DefectDojo-Inc/Documentation/blob/c6e1a446c3dbf2c931972cfbbdaef3ee20df77c8/.github/workflows/deploy-gh-pages-branch.yml#L11-L20 |
I agree with @kiblik about making sure we rev the versions as part of this upgrade to the docs site. Can't wait for docs dark mode 😄 |
@kiblik yes, that change was done in this commit. |
Tests will need to be updated to point at the new doc paths:
|
This should be settled now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will likely be some revving on this to make sure the automation is set correctly here
Will have to do that once it is in dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This PR changes the base theme from Docsy into the more workable 'Doks' theme. (It has a dark mode - sold). It also adds many new tutorials and guides to our docs.
Hugo is still a dependency. However with this version of the repo there is no need to install the theme as a git submodule. Instead,
cd
intodocs
,npm install
to pull the theme and thennpm run dev
to view the docs locally with the new theme in place.