Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate TS 4.7's new union order in levelup tests #60016

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

sandersn
Copy link
Contributor

Looks like TS 4.7's union order changed again? @weswigham you might want to know about this.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 22, 2022

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60016,
  "author": "sandersn",
  "headCommitOid": "b66945a88215cfe2f20133f1f412e60bc6ca339b",
  "mergeBaseOid": "a0d76dbe7db780a83e51e2b7b04f9e97257be325",
  "lastPushDate": "2022-04-22T21:39:42.000Z",
  "lastActivityDate": "2022-04-22T21:40:14.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "levelup",
      "kind": "edit",
      "files": [
        {
          "path": "types/levelup/levelup-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "MeirionHughes",
        "danwbyrne",
        "carsonfarmer",
        "istherepie"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1106901227,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Apr 22, 2022
@typescript-bot
Copy link
Contributor

🔔 @MeirionHughes @danwbyrne @carsonfarmer @istherepie — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sandersn sandersn merged commit 04d422c into master Apr 22, 2022
@sandersn sandersn deleted the reorder-levelup-test-types-again branch April 22, 2022 21:45
@weswigham
Copy link
Contributor

Again? Wat. News to me. Dunno what change'd prompt it, but since we request diagnostics after these types in the tests, I assume any services changes might create union order changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants