Feature/dei 58 new time add as coord #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riables-to-be-included-in-outputdataset
… state to rule_based_model. Not working yet
Made some small code improvements Renamed utls to list_utils Changed IRule output_variable_name back to string Moved creation of composite dataset from RuleBasedModel to dataset_utils
…ed-in-outputdataset
…tdataset' into feature/DEI-44-ugrid-conventions
…tdataset' into feature/DEI-44-ugrid-conventions
…ew-time-add-as-coord
wschoonveld
reviewed
Mar 16, 2023
| result_dataset = processor.process_rules(output_dataset, logger) | ||
|
|
||
| assert "time_month" in result_dataset.coords | ||
| assert (result_dataset.time_month.values == input_array).all() |
There was a problem hiding this comment.
it appears it is now only tested that no duplicates occur.
Maybe with a view extra statements it can be tested that the coords are also copied if not present?
(or am I missing something?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.