fix: Remove identifier alias from cast builtin function

DerekStride · Feb 18, 2023 · e4e43ba · e4e43ba
1 parent eac9da2
commit e4e43ba
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 19 deletions.
diff --git a/grammar.js b/grammar.js
@@ -1339,7 +1339,7 @@ module.exports = grammar({
     ),
 
     cast: $ => seq(
-      field('name', alias($.keyword_cast, $.identifier)),
+      field('name', $.keyword_cast),
       '(',
       seq(
         field('parameter', $._expression),

diff --git a/src/grammar.json b/src/grammar.json
diff --git a/src/node-types.json b/src/node-types.json
diff --git a/src/parser.c b/src/parser.c
diff --git a/test/corpus/casting.txt b/test/corpus/casting.txt
@@ -13,7 +13,7 @@ SELECT CAST(1 AS TEXT);
       (select_expression
         (term
           (cast
-            (identifier)
+            (keyword_cast)
             (literal)
             (keyword_as)
             (keyword_text)))))))
@@ -33,7 +33,7 @@ SELECT CAST(1 AS TEXT) AS fieldname;
       (select_expression
         (term
           value: (cast
-            name: (identifier)
+            name: (keyword_cast)
             parameter: (literal)
             (keyword_as)
             (keyword_text))
@@ -83,7 +83,7 @@ SELECT
       (select_expression
         (term
           value: (cast
-            name: (identifier)
+            name: (keyword_cast)
             parameter: (literal)
             (keyword_as)
             (int
@@ -116,7 +116,7 @@ CAST (100 AS NUMERIC(32)),
       (select_expression
         (term
           value: (cast
-            name: (identifier)
+            name: (keyword_cast)
             parameter: (literal)
             (keyword_as)
             (numeric
@@ -148,7 +148,7 @@ SELECT CAST ("1" AS UNSIGNED INTEGER);
       (select_expression
         (term
           value: (cast
-            name: (identifier)
+            name: (keyword_cast)
             parameter: (literal)
             (keyword_as)
             (int
@@ -174,7 +174,7 @@ SELECT '1 day 10 seconds'::INTERVAL, CAST('1 month' AS INTERVAL)
             (keyword_interval)))
         (term
           value: (cast
-            name: (identifier)
+            name: (keyword_cast)
             parameter: (literal)
             (keyword_as)
             (keyword_interval)))))))
diff --git a/test/corpus/window_functions.txt b/test/corpus/window_functions.txt
@@ -565,7 +565,7 @@ FROM
                     (keyword_false))
                   (keyword_end))
                 (cast
-                  (identifier)
+                  (keyword_cast)
                   (field
                     (identifier))
                   (keyword_as)
@@ -622,7 +622,7 @@ FROM
                     (keyword_end)))
                 (order_target
                   (cast
-                    (identifier)
+                    (keyword_cast)
                     (field
                       (identifier))
                     (keyword_as)