fix(a11y): DES-2482 cms icons, role as none (only i.fa)
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2023
wesleyboar
changed the title
i.fa)i.fa)
3 tasks
wesleyboar
changed the title
i.fa)i.fa) ⏸️
wesleyboar
commented
Oct 4, 2023
There was a problem hiding this comment.
The intended change here is only adding role="none" to the <i class="…"></i>s.
But DOS line endings are causing a problem…
- I can not stop VS Code from doing that.
- I tried using VIM to edit and preserve line endings. It's better than it was.
wesleyboar
changed the title
i.fa) ⏸️i.fa)
jarosenb
approved these changes
Oct 25, 2023
jarosenb
deleted the
bugfix/DES-2482-cms-icons-role-as-none-ONLY-FA-ICONS
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Waiting on:
Overview / Summary:
Add
role="none"to FontAwesome icons.PR Status:
Related Jira tickets:
Testing Steps:
CMS
fa fa-.<i class="fa fa-…></i>are now<i role="none" class="fa fa-…></i>.Portal
fa fa-.<i class="fa fa-…></i>are now<i role="none" class="fa fa-…></i>.UI Photos:
Skipped.
Notes:
This does not fix other icons that need
role="none". For that, see #1051 and #1053.