Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when dns-records/:id is not a valid ID #445

Closed
humphd opened this issue Mar 25, 2023 · 0 comments · Fixed by #554
Closed

Error when dns-records/:id is not a valid ID #445

humphd opened this issue Mar 25, 2023 · 0 comments · Fixed by #554
Assignees
@Myrfion
Labels
bug Something isn't working category: data Anything related to data management and structure category: front end Front end part of our web service
Milestone
Milestone 1.0a

Comments

@humphd
Copy link
Contributor

humphd commented Mar 25, 2023

I accidentally typed the wrong URL, and got this crash on staging:

Screenshot 2023-03-25 at 7 41 45 PM

Here we're trying to use dev as an ID for a DNS Record in Prisma, and it crashes. We should deal with this call throwing, and send an error response that we can use to show a friendly message, see #391.
@humphd humphd added bug Something isn't working category: front end Front end part of our web service category: data Anything related to data management and structure labels Mar 25, 2023
@Myrfion Myrfion self-assigned this Mar 27, 2023
@SerpentBytes SerpentBytes added this to the Milestone 0.9 milestone Apr 3, 2023
@Myrfion Myrfion mentioned this issue Apr 10, 2023
Merged
@Myrfion Myrfion linked a pull request Apr 10, 2023 that will close this issue
Add error and catch boundaries #554
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Myrfion Myrfion

Labels
bug Something isn't working category: data Anything related to data management and structure category: front end Front end part of our web service
Projects
None yet
Milestone
Milestone 1.0a
Development

Successfully merging a pull request may close this issue.

Add error and catch boundaries DevelopingSpace/starchart
4 participants
@humphd @Myrfion @SerpentBytes @Eakam1007