Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker-build failure #250

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: docker-build failure #250

merged 1 commit into from
Feb 21, 2023

Conversation

SerpentBytes
Copy link
Contributor

@SerpentBytes SerpentBytes commented Feb 20, 2023 •
edited
Loading

Description

This PR could potentially fix the Docker build job failing due to Docker Engine not being able to find the imports located in the /img directory, as we are ignoring it in .dockerignore.

@SerpentBytes SerpentBytes marked this pull request as ready for review February 20, 2023 19:35
@SerpentBytes SerpentBytes requested review from humphd, a user and sfrunza13 February 20, 2023 19:35
@SerpentBytes SerpentBytes self-assigned this Feb 20, 2023
humphd
humphd reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this. Let's move the image we're using in the source under the app/* folder. The top-level img folder is for screenshots and docs.

@SerpentBytes SerpentBytes force-pushed the fix-docker-test-failing branch from b6d546a to 407cca9 Compare February 20, 2023 20:10
@SerpentBytes
Copy link
Contributor Author

SerpentBytes commented Feb 20, 2023 •
edited
Loading

I have moved the image used by the project to app/assets and updated the import statement in certificate/loading.tsx

@SerpentBytes SerpentBytes requested a review from humphd February 20, 2023 20:13
humphd
humphd requested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the img/license file too? it goes with this file

@SerpentBytes
Import images used by project from app/assets
7e425a8 
 * Remove /img
 * import image assets from app/assets
 * Move img/LICENSEto app/assets
@SerpentBytes SerpentBytes force-pushed the fix-docker-test-failing branch from 407cca9 to 7e425a8 Compare February 20, 2023 21:43
@SerpentBytes SerpentBytes requested a review from humphd February 20, 2023 21:46
humphd
humphd approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, I totally missed it in my review before.

@humphd humphd requested a review from Ririio February 20, 2023 22:29
Ririio
Ririio approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Ririio Ririio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I didn't know doing that could cause docker to fail

@SerpentBytes SerpentBytes merged commit 3ba6e81 into DevelopingSpace:main Feb 21, 2023
@SerpentBytes
Copy link
Contributor Author

I'm sorry I didn't know doing that could cause docker to fail

It happens. Part of the process.

@SerpentBytes SerpentBytes deleted the fix-docker-test-failing branch February 21, 2023 03:34
@SerpentBytes SerpentBytes added this to the Milestone 0.4 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ririio Ririio Ririio approved these changes

@humphd humphd humphd approved these changes

@sfrunza13 sfrunza13 Awaiting requested review from sfrunza13

Assignees

@SerpentBytes SerpentBytes

Labels
None yet
Projects
None yet
Milestone
Milestone 0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@SerpentBytes @humphd @Ririio