feat: DNS propagation wait worker #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
ghost
requested review from
Genne23v
reviewed
Mar 8, 2023
SerpentBytes
reviewed
Mar 9, 2023
SerpentBytes
reviewed
Mar 9, 2023
SerpentBytes
previously approved these changes
Mar 9, 2023
Genne23v
reviewed
Mar 9, 2023
| */ | ||
| await addDnsRequest({ | ||
| username, |
There was a problem hiding this comment.
@dadolhay I'm going to break down this function into 1. Add a record to DB with pending status 2. Route53 update and update DB status once Route53 work is complete. Let me know if you see any concern with this.
There was a problem hiding this comment.
@Genne23v
It's still going to be a flow, right? so I create a job to handle this, and the job flow adds the db entry, handles the route53 api, then updates the status to complete
Am I understanding you correctly?
There was a problem hiding this comment.
Initial DB record creation won't be a part of flow as it completes the work immediately. Then the rest of jobs will be run as flow.
humphd
requested changes
Mar 9, 2023
SerpentBytes
approved these changes
Mar 9, 2023
humphd
approved these changes
Mar 9, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169