Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry playwright tests at least once #340

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Retry playwright tests at least once #340

merged 1 commit into from
Mar 14, 2023

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Mar 14, 2023 •
edited
Loading

Videos and traces are configured to be generated on the first retry. So, changing the number of retries outside of the CI environment to 1 would allow for easier debugging when running tests locally

@Eakam1007 Eakam1007 added the category: testing Unit tests, end to end tests label Mar 14, 2023
@Eakam1007 Eakam1007 added this to the Milestone 0.6 milestone Mar 14, 2023
@Eakam1007 Eakam1007 self-assigned this Mar 14, 2023
@Eakam1007 Eakam1007 marked this pull request as ready for review March 14, 2023 21:11
sfrunza13
sfrunza13 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@sfrunza13 sfrunza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, all for this. Where does it put the files that are generated?

@Eakam1007
Copy link
Contributor Author

Eakam1007 commented Mar 14, 2023 •
edited
Loading

It puts them under the test-results folder. This is configured here:

starchart/playwright.config.ts

Line 119 in 4453612

outputDir: 'test-results/',

@Eakam1007 Eakam1007 merged commit 03f8931 into DevelopingSpace:main Mar 14, 2023
@Eakam1007 Eakam1007 deleted the playwright-retry-update branch March 14, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfrunza13 sfrunza13 sfrunza13 approved these changes

@humphd humphd humphd approved these changes

Assignees

@Eakam1007 Eakam1007

Labels
category: testing Unit tests, end to end tests
Projects
None yet
Milestone
Milestone 0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Eakam1007 @humphd @sfrunza13