-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration for editing dns records #369
Conversation
Seems like tests are failing due to the same error as the Type-Check error |
Can you rebase and update your code to use the new naming/layout that we landed in #349? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally, and had to make the following changes:
diff --git a/app/routes/__index/domains/$dnsRecordId.tsx b/app/routes/__index/domains/$dnsRecordId.tsx
index bbf83d9..b6398cf 100644
--- a/app/routes/__index/domains/$dnsRecordId.tsx
+++ b/app/routes/__index/domains/$dnsRecordId.tsx
@@ -5,7 +5,7 @@ import { z } from 'zod';
import { parseFormSafe } from 'zodix';
import type { ActionArgs, LoaderArgs } from '@remix-run/node';
import DnsRecordForm from '~/components/dns-record/form';
-import { updateDnsRequest } from '~/queues/dns/dns-flow.server';
+import { updateDnsRequest } from '~/queues/dns/update-record-flow.server';
import { requireUser } from '~/session.server';
import { getRecordById } from '~/models/record.server';
@@ -55,7 +55,7 @@ export const action = async ({ request }: ActionArgs) => {
id: Number(data.id),
username: user.username,
type: data.type,
- name: data.name,
+ subdomain: data.name,
value: data.value,
});
You should also rebase, since a lot has changed since you wrote this code.
@humphd updated to new terminology and updated terminology inside of the table component itself, except the filename, because I am not sure if it is a good idea to do it in this PR (it would be a lot of changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. A few things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the table heading Name
to Subdomain
as well on line 123 of app/components/domains-table.tsx
What it changes
closes #331