-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dns reconciler queue #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I love normal vs. limp mode! Lots of great problem solving and interesting patterns in here.
I've left a bunch of questions and comments.
@humphd Thank you! Updates pushed, and I'll ask for some help with the e2e tests. No rush, we can talk about it tomorrow! Again, thanks for the very quick reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is well organized and comments are easy to understand. I added only one comment. Feel free to update or keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging this locally, the following change gets the e2e tests to pass for me locally:
diff --git a/app/root.tsx b/app/root.tsx
index a4a8f08..89550eb 100644
--- a/app/root.tsx
+++ b/app/root.tsx
@@ -12,7 +12,6 @@ import {
import { getUser } from './session.server';
import theme from './theme';
-import { addReconcilerJob } from './queues/reconciler/reconciler-queue.server';
import type { MetaFunction, LoaderArgs, LinksFunction } from '@remix-run/node';
@@ -37,8 +36,6 @@ export async function loader({ request, context }: LoaderArgs) {
});
}
-addReconcilerJob();
-
function Document({ children }: { children: React.ReactNode }) {
// We need the nonce generated by the server via helmetjs to put on scripts
const { nonce } = useLoaderData<typeof loader>();
diff --git a/server.ts b/server.ts
index a604867..7765fd0 100644
--- a/server.ts
+++ b/server.ts
@@ -8,6 +8,7 @@ import helmet from 'helmet';
import cors from 'cors';
import logger from '~/lib/logger.server';
+import { addReconcilerJob } from '~/queues/reconciler/reconciler-queue.server';
import type { Request, Response } from 'express';
@@ -81,6 +82,8 @@ const port = process.env.PORT || 8080;
const server = app.listen(port, () => {
// require the built app so we're ready when the first request comes in
require(BUILD_DIR);
+ // start the DNS reconciler
+ addReconcilerJob();
logger.info(`✅ app ready: http://localhost:${port}`);
});
@humphd Thanks for the suggestion! It seems to have solved the issue! |
@humphd When you are around, can I get an approve if all is well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 ship it!
* feat: Dns Reconciler queue * fix: init * fix: comments * improvements * small fixes * fix: error during testing Credit: @humphd
Closes #396