Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Fixing the style of certificate text #489

Merged
merged 1 commit into from
Mar 31, 2023
Merged

FE: Fixing the style of certificate text #489

merged 1 commit into from
Mar 31, 2023

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Mar 31, 2023

Should fix the issue with certificate not having the correct format when displayed

image

@Ririio Ririio added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Mar 31, 2023
@Ririio Ririio added this to the Milestone 0.8 milestone Mar 31, 2023
@Ririio Ririio requested review from humphd, Myrfion and Eakam1007 March 31, 2023 13:37
@Ririio Ririio self-assigned this Mar 31, 2023
humphd
humphd approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Please file separate issues on:

  1. copy-paste not including the newlines
  2. multiple inclusions of the value (should only be 1)

@Eakam1007
Copy link
Contributor

Is this fixing a specific issue? If so, could you please link it to this PR?

@Ririio Ririio merged commit 14c32e1 into DevelopingSpace:main Mar 31, 2023
@Ririio Ririio deleted the issue-453 branch March 31, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eakam1007 Eakam1007 Eakam1007 approved these changes

@humphd humphd humphd approved these changes

@Myrfion Myrfion Awaiting requested review from Myrfion

Assignees

@Ririio Ririio

Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Milestone
Milestone 0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Ririio @Eakam1007 @humphd