Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send notification when certificate completion succeeds #510

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Send notification when certificate completion succeeds #510

merged 3 commits into from
Apr 4, 2023

Conversation

SerpentBytes
Copy link
Contributor

@SerpentBytes SerpentBytes commented Apr 4, 2023 •
edited
Loading

Description

Resolves #109

Steps to test

  1. Run the project
  2. Request a certificate
  3. Navigate to http://localhost:8025 when the UI updates with the info on the newly created certificate

@SerpentBytes SerpentBytes requested review from a user and humphd April 4, 2023 18:13
@SerpentBytes SerpentBytes marked this pull request as ready for review April 4, 2023 18:19
@SerpentBytes SerpentBytes self-assigned this Apr 4, 2023
@SerpentBytes SerpentBytes added category: notifications A service to notify users about their certificates/domains category: certificates Creating certificates, encryption labels Apr 4, 2023
@SerpentBytes SerpentBytes added this to the Milestone 0.9 milestone Apr 4, 2023
@SerpentBytes SerpentBytes changed the title Send notification when certificate completion succeeds/fails Send notification when certificate completion succeeds Apr 4, 2023
@SerpentBytes SerpentBytes requested a review from humphd April 4, 2023 20:08
humphd
humphd previously approved these changes Apr 4, 2023
View reviewed changes
@SerpentBytes @Eakam1007
Update app/queues/certificate/order-completer-worker.server.ts
6ff23ec 
Co-authored-by: Eakam <eakam1007@gmail.com>
@SerpentBytes SerpentBytes requested review from humphd and Eakam1007 April 4, 2023 22:34
@SerpentBytes SerpentBytes merged commit 155b284 into DevelopingSpace:main Apr 4, 2023
@SerpentBytes SerpentBytes deleted the issue-109 branch April 5, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eakam1007 Eakam1007 Eakam1007 approved these changes

@humphd humphd humphd approved these changes

@Genne23v Genne23v Awaiting requested review from Genne23v

Assignees

@SerpentBytes SerpentBytes

Labels
category: certificates Creating certificates, encryption category: notifications A service to notify users about their certificates/domains
Projects
None yet
Milestone
Milestone 0.9
Development

Successfully merging this pull request may close these issues.

Send email notification when SSL certificate order is complete and ready
3 participants
@SerpentBytes @humphd @Eakam1007