Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing page responsiveness #522

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Apr 5, 2023

Resolves #496

Changes made

  • Made DNS Records and Certificate cards get rendered using a flex-direction of column until the md (768px - Chakra UI default) breakpoint is reached. Essentially the cards will show vertically stacked instead of horizontally up to a bigger screen size than before. Thanks @Ririio for the suggestion
  • Removed redundant Flex component for heading
  • Updated the width of the heading to be 80% on sm (480px - Chakra UI default) breakpoint and up. The heading's width was too small compared to the cards.
  • Added a width to the cards container so that they don't stretch to fit the page before the md breakpoint

Before and After Screenshots

2XL screen size (width >= 1536px)

Before

image

After

image
Extra Large screen size (width < 1536px)

Before

image

After

image
Large screen size (width < 1280px)

Before

image

After

image
Medium screen size (width < 992px)

Before

image

After

image
Small screen size (width < 768px)

Before and After

image image
Extra small screen size (width < 480px) - no change

Before and After (no change)

image image

Steps to Test

  • Run app locally
  • Navigate to landing page
  • Open developer tools and using the toggle device emulation, adjust the width and height to check for responsiveness

@Eakam1007 Eakam1007 added this to the Milestone 0.9 milestone Apr 5, 2023
@Eakam1007 Eakam1007 self-assigned this Apr 5, 2023
@Ririio
Copy link
Contributor

Ririio commented Apr 5, 2023

It seems that "small-screen" is always causing an issue-- looks too wide. I would recommend checking the breakpoint we have established, and change the values there. I was testing this out a couple of days back, and I get the feeling that small and xs are too small of a gap

@Eakam1007
Copy link
Contributor Author

Eakam1007 commented Apr 5, 2023

It seems that "small-screen" is always causing an issue-- looks too wide. I would recommend checking the breakpoint we have established, and change the values there. I was testing this out a couple of days back, and I get the feeling that small and xs are too small of a gap

Sorry what exactly do you want for the current small screen breakpoint? Make the medium cover more of it, and make the cards show horizontally instead?

@Ririio
Copy link
Contributor

Ririio commented Apr 5, 2023

Sorry what exactly do you want for the current small screen breakpoint? Make the medium cover more of it, and make the cards show horizontally instead?

I like the idea of it being vertical. I just find the cards a bit too wide. If you checked the breakpoint file, the difference between sm and xs are just far too small compared to sm and md.

@Eakam1007
Copy link
Contributor Author

Oh, I have defined the width of the cards manually for that breakpoint. I could just reduce it if you want?

@Ririio
Copy link
Contributor

Ririio commented Apr 5, 2023

Oh, I have defined the width of the cards manually for that breakpoint. I could just reduce it if you want?

Sure, just a tiny bit smaller to make the card look not so fat

@Eakam1007
Copy link
Contributor Author

How about this @Ririio:
image

@Eakam1007
Copy link
Contributor Author

I have updated the original PR comment as well

@Eakam1007 Eakam1007 requested a review from Ririio April 5, 2023 04:28
@Eakam1007 Eakam1007 merged commit 5165658 into DevelopingSpace:main Apr 5, 2023
@Eakam1007 Eakam1007 deleted the 496-improve-landing-page-responsiveness branch April 5, 2023 12:43
@humphd
Copy link
Contributor

humphd commented Apr 5, 2023

Just tested this locally, and was about to Approve as well. Nice work, @Eakam1007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: landing page not fully responsive
4 participants