-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve landing page responsiveness #522
Improve landing page responsiveness #522
Conversation
It seems that "small-screen" is always causing an issue-- looks too wide. I would recommend checking the breakpoint we have established, and change the values there. I was testing this out a couple of days back, and I get the feeling that small and xs are too small of a gap |
Sorry what exactly do you want for the current small screen breakpoint? Make the medium cover more of it, and make the cards show horizontally instead? |
I like the idea of it being vertical. I just find the cards a bit too wide. If you checked the breakpoint file, the difference between |
Oh, I have defined the width of the cards manually for that breakpoint. I could just reduce it if you want? |
Sure, just a tiny bit smaller to make the card look not so fat |
How about this @Ririio: |
I have updated the original PR comment as well |
Just tested this locally, and was about to Approve as well. Nice work, @Eakam1007. |
Resolves #496
Changes made
flex-direction
ofcolumn
until themd
(768px - Chakra UI default) breakpoint is reached. Essentially the cards will show vertically stacked instead of horizontally up to a bigger screen size than before. Thanks @Ririio for the suggestionsm
(480px - Chakra UI default) breakpoint and up. The heading's width was too small compared to the cards.md
breakpointBefore and After Screenshots
2XL screen size (width >= 1536px)
Before
After
Extra Large screen size (width < 1536px)
Before
After
Large screen size (width < 1280px)
Before
After
Medium screen size (width < 992px)
Before
After
Small screen size (width < 768px)
Before and After
Extra small screen size (width < 480px) - no change
Before and After (no change)
Steps to Test
toggle device emulation
, adjust the width and height to check for responsiveness